Skip to content

Commit 8f6f1e6

Browse files
youkaichaovadiklyutiy
authored andcommitted
[misc] skip p2p check by default (vllm-project#21904)
1 parent 8cfd4e7 commit 8f6f1e6

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

vllm/envs.py

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -668,12 +668,14 @@ def get_vllm_port() -> Optional[int]:
668668
(os.environ.get("VLLM_ALLOW_RUNTIME_LORA_UPDATING", "0").strip().lower() in
669669
("1", "true")),
670670

671-
# By default, vLLM will check the peer-to-peer capability itself,
672-
# in case of broken drivers. See https://github.com/vllm-project/vllm/blob/a9b15c606fea67a072416ea0ea115261a2756058/vllm/distributed/device_communicators/custom_all_reduce_utils.py#L101-L108 for details. # noqa
673-
# If this env var is set to 1, vLLM will skip the peer-to-peer check,
674-
# and trust the driver's peer-to-peer capability report.
671+
# We assume drivers can report p2p status correctly.
672+
# If the program hangs when using custom allreduce,
673+
# potantially caused by a bug in the driver (535 series),
674+
# if might be helpful to set VLLM_SKIP_P2P_CHECK=0
675+
# so that vLLM can verify if p2p is actually working.
676+
# See https://github.com/vllm-project/vllm/blob/a9b15c606fea67a072416ea0ea115261a2756058/vllm/distributed/device_communicators/custom_all_reduce_utils.py#L101-L108 for details. # noqa
675677
"VLLM_SKIP_P2P_CHECK":
676-
lambda: os.getenv("VLLM_SKIP_P2P_CHECK", "0") == "1",
678+
lambda: os.getenv("VLLM_SKIP_P2P_CHECK", "1") == "1",
677679

678680
# List of quantization kernels that should be disabled, used for testing
679681
# and performance comparisons. Currently only affects MPLinearKernel

0 commit comments

Comments
 (0)