remove get_date_first_seen (use indexcard.created)

Author: aaxelb

share/models/source_unique_identifier.py

@@ -1,6 +1,3 @@
-import datetime
-from typing import Optional
-
 from django.db import models
 
 from share.util import BaseJSONAPIMeta
@@ -22,18 +19,6 @@ class JSONAPIMeta(BaseJSONAPIMeta):
     class Meta:
         unique_together = ('identifier', 'source_config')
 
-    def get_date_first_seen(self) -> Optional[datetime.datetime]:
-        """when the first datum for this suid was added
-        """
-        from trove.models import ArchivedResourceDescription
-        return (
-            ArchivedResourceDescription.objects
-            .filter(indexcard__source_record_suid=self)
-            .order_by('created')
-            .values_list('created', flat=True)
-            .first()
-        )
-
     def get_backcompat_sharev2_suid(self):
         '''get an equivalent "v2_push" suid for this suid
 

tests/share/models/test_suid.py

@@ -34,7 +34,6 @@ def run_input_output_test(self, given_input, expected_output):
     def _get_deriver(self, input_doc: DeriverTestDoc):
         _mock_suid = mock.Mock()
         _mock_suid.id = '--suid_id--'
-        _mock_suid.get_date_first_seen.return_value = datetime.datetime(2345, 1, 1)
         _mock_suid.get_backcompat_sharev2_suid.return_value = _mock_suid
         _mock_suid.identifier = '--sourceunique-id--'
         _mock_suid.source_config.label = '--sourceconfig-label--'
@@ -47,4 +46,5 @@ def _get_deriver(self, input_doc: DeriverTestDoc):
         _mock_resource_description.focus_iri = input_doc.focus_iri
         _mock_resource_description.indexcard.id = '--indexcard-id--'
         _mock_resource_description.indexcard.source_record_suid = _mock_suid
+        _mock_resource_description.indexcard.created = datetime.datetime(2345, 1, 1)
         return self.deriver_class(_mock_resource_description)

tests/trove/derive/_base.py

@@ -158,7 +158,7 @@ def derive_card_as_text(self):
             # metadata about the record/indexcard in this system
             'id': IDObfuscator.encode(_suid),
             'indexcard_id': self.upstream_description.indexcard.id,
-            'date_created': _suid.get_date_first_seen().isoformat(),
+            'date_created': self.upstream_description.indexcard.created.isoformat(),
             'date_modified': self.upstream_description.modified.isoformat(),
             'sources': [_source_name],
             'source_config': _suid.source_config.label,