feat(registration-recent-activity): run lint fix

sh-andriy · sh-andriy · commit 5ad3caacf602 · 2025-09-10T17:37:03.000+03:00
diff --git a/src/app/core/constants/environment.token.ts b/src/app/core/constants/environment.token.ts
@@ -1,8 +1,9 @@
 import { InjectionToken } from '@angular/core';
 
-import { environment } from 'src/environments/environment';
 import { AppEnvironment } from '@shared/models/environment.model';
 
+import { environment } from 'src/environments/environment';
+
 export const ENVIRONMENT = new InjectionToken<AppEnvironment>('App Environment', {
   providedIn: 'root',
   factory: () => environment as AppEnvironment,
diff --git a/src/app/features/project/overview/components/recent-activity/recent-activity.component.spec.ts b/src/app/features/project/overview/components/recent-activity/recent-activity.component.spec.ts
@@ -1,18 +1,20 @@
-import { ComponentFixture, TestBed } from '@angular/core/testing';
 import { provideStore, Store } from '@ngxs/store';
-import { ActivatedRoute } from '@angular/router';
-
-import { provideHttpClient, withInterceptorsFromDi } from '@angular/common/http';
-import { provideHttpClientTesting } from '@angular/common/http/testing';
 
 import { TranslateService } from '@ngx-translate/core';
+
 import { of } from 'rxjs';
 
-import { RecentActivityComponent } from './recent-activity.component';
+import { provideHttpClient, withInterceptorsFromDi } from '@angular/common/http';
+import { provideHttpClientTesting } from '@angular/common/http/testing';
+import { ComponentFixture, TestBed } from '@angular/core/testing';
+import { ActivatedRoute } from '@angular/router';
+
 import { ActivityLogDisplayService } from '@shared/services';
 import { GetActivityLogs } from '@shared/stores/activity-logs';
 import { ActivityLogsState } from '@shared/stores/activity-logs/activity-logs.state';
 
+import { RecentActivityComponent } from './recent-activity.component';
+
 describe('RecentActivityComponent', () => {
   let fixture: ComponentFixture<RecentActivityComponent>;
   let store: Store;
diff --git a/src/app/features/project/overview/project-overview.component.spec.ts b/src/app/features/project/overview/project-overview.component.spec.ts
@@ -1,19 +1,21 @@
-import { ComponentFixture, TestBed } from '@angular/core/testing';
-import { RouterTestingModule } from '@angular/router/testing';
 import { provideStore, Store } from '@ngxs/store';
-import { ActivatedRoute } from '@angular/router';
+
+import { TranslateService } from '@ngx-translate/core';
+
+import { DialogService } from 'primeng/dynamicdialog';
+
 import { of } from 'rxjs';
 
 import { provideHttpClient, withInterceptorsFromDi } from '@angular/common/http';
 import { provideHttpClientTesting } from '@angular/common/http/testing';
+import { ComponentFixture, TestBed } from '@angular/core/testing';
+import { ActivatedRoute } from '@angular/router';
+import { RouterTestingModule } from '@angular/router/testing';
 
-import { ProjectOverviewComponent } from './project-overview.component';
+import { DataciteService, ToastService } from '@osf/shared/services';
 import { GetActivityLogs } from '@shared/stores/activity-logs';
 
-import { DataciteService } from '@osf/shared/services';
-import { DialogService } from 'primeng/dynamicdialog';
-import { TranslateService } from '@ngx-translate/core';
-import { ToastService } from '@osf/shared/services';
+import { ProjectOverviewComponent } from './project-overview.component';
 
 describe('ProjectOverviewComponent', () => {
   let fixture: ComponentFixture<ProjectOverviewComponent>;
diff --git a/src/app/features/registry/pages/recent-activity/registration-recent-activity.component.spec.ts b/src/app/features/registry/pages/recent-activity/registration-recent-activity.component.spec.ts
@@ -1,14 +1,15 @@
-import { provideHttpClient, withInterceptorsFromDi } from '@angular/common/http';
-import { provideHttpClientTesting } from '@angular/common/http/testing';
+import { provideStore, Store } from '@ngxs/store';
+
 import { TranslateService } from '@ngx-translate/core';
-import { of } from 'rxjs';
-import { ActivityLogDisplayService } from '@shared/services';
 
-import { provideStore, Store } from '@ngxs/store';
+import { of } from 'rxjs';
 
+import { provideHttpClient, withInterceptorsFromDi } from '@angular/common/http';
+import { provideHttpClientTesting } from '@angular/common/http/testing';
 import { ComponentFixture, TestBed } from '@angular/core/testing';
 import { ActivatedRoute } from '@angular/router';
 
+import { ActivityLogDisplayService } from '@shared/services';
 import { ClearActivityLogsStore, GetRegistrationActivityLogs } from '@shared/stores/activity-logs';
 import { ActivityLogsState } from '@shared/stores/activity-logs/activity-logs.state';
 
diff --git a/src/app/features/registry/pages/recent-activity/registration-recent-activity.component.ts b/src/app/features/registry/pages/recent-activity/registration-recent-activity.component.ts
@@ -3,22 +3,21 @@ import { createDispatchMap, select } from '@ngxs/store';
 import { TranslatePipe } from '@ngx-translate/core';
 
 import { PaginatorState } from 'primeng/paginator';
+import { Skeleton } from 'primeng/skeleton';
 
 import { DatePipe } from '@angular/common';
-import { Skeleton } from 'primeng/skeleton';
 import { ChangeDetectionStrategy, Component, computed, inject, OnDestroy, signal } from '@angular/core';
 import { ActivatedRoute } from '@angular/router';
 
+import { ENVIRONMENT } from '@core/constants/environment.token';
 import { CustomPaginatorComponent } from '@shared/components';
+import { ACTIVITY_LOGS_DEFAULT_PAGE_SIZE } from '@shared/constants/activity-logs';
 import {
   ActivityLogsSelectors,
   ClearActivityLogsStore,
   GetRegistrationActivityLogs,
 } from '@shared/stores/activity-logs';
 
-import { ENVIRONMENT } from '@core/constants/environment.token';
-import { ACTIVITY_LOGS_DEFAULT_PAGE_SIZE } from '@shared/constants/activity-logs';
-
 @Component({
   selector: 'osf-registration-recent-activity',
   imports: [TranslatePipe, DatePipe, CustomPaginatorComponent, Skeleton],
diff --git a/src/app/shared/models/activity-logs/activity-log-with-display.model.ts b/src/app/shared/models/activity-logs/activity-log-with-display.model.ts
@@ -1,4 +1,5 @@
 import { SafeHtml } from '@angular/platform-browser';
+
 import { ActivityLog } from './activity-logs.model';
 
 export interface ActivityLogWithDisplay extends ActivityLog {
diff --git a/src/app/shared/models/activity-logs/activity-logs.model.ts b/src/app/shared/models/activity-logs/activity-logs.model.ts
@@ -14,10 +14,7 @@ export interface ActivityLog {
     paramsNode: { id: string; title: string };
     paramsProject: null;
     pointer: Pointer | null;
-    preprintProvider?:
-      | string
-      | { url: string; name: string }
-      | null;
+    preprintProvider?: string | { url: string; name: string } | null;
     addon?: string;
     anonymousLink?: boolean;
     file?: { name: string; url: string };
diff --git a/src/app/shared/models/activity-logs/index.ts b/src/app/shared/models/activity-logs/index.ts
@@ -1,3 +1,3 @@
+export * from './activity-log-with-display.model';
 export * from './activity-logs.model';
 export * from './activity-logs-json-api.model';
-export * from './activity-log-with-display.model';
diff --git a/src/app/shared/services/activity-logs/activity-logs.service.spec.ts b/src/app/shared/services/activity-logs/activity-logs.service.spec.ts
@@ -2,12 +2,13 @@ import { HttpTestingController } from '@angular/common/http/testing';
 import { inject, TestBed } from '@angular/core/testing';
 
 import { ActivityLogDisplayService } from '@shared/services';
+
 import { ActivityLogsService } from './activity-logs.service';
 
 import {
-  getActivityLogsResponse,
-  buildRegistrationLogsUrl,
   buildNodeLogsUrl,
+  buildRegistrationLogsUrl,
+  getActivityLogsResponse,
 } from '@testing/data/activity-logs/activity-logs.data';
 import { OSFTestingStoreModule } from '@testing/osf.testing.module';
 
diff --git a/src/app/shared/services/activity-logs/activity-logs.service.ts b/src/app/shared/services/activity-logs/activity-logs.service.ts
@@ -1,5 +1,6 @@
 import { Observable } from 'rxjs';
 import { map } from 'rxjs/operators';
+
 import { inject, Injectable } from '@angular/core';
 
 import { ActivityLogsMapper } from '@shared/mappers/activity-logs.mapper';
@@ -32,7 +33,7 @@ export class ActivityLogsService {
     };
   }
 
-  fetchLogs(projectId: string, page: number = 1, pageSize: number): Observable<PaginatedData<ActivityLogWithDisplay[]>> {
+  fetchLogs(projectId: string, page = 1, pageSize: number): Observable<PaginatedData<ActivityLogWithDisplay[]>> {
     const url = `${this.apiUrl}/nodes/${projectId}/logs/`;
     const params: Record<string, unknown> = {
       'embed[]': ['original_node', 'user', 'linked_node', 'linked_registration', 'template_node', 'group'],
@@ -50,7 +51,7 @@ export class ActivityLogsService {
 
   fetchRegistrationLogs(
     registrationId: string,
-    page: number = 1,
+    page = 1,
     pageSize: number
   ): Observable<PaginatedData<ActivityLogWithDisplay[]>> {
     const url = `${this.apiUrl}/registrations/${registrationId}/logs/`;
diff --git a/src/app/shared/stores/activity-logs/activity-logs.selectors.spec.ts b/src/app/shared/stores/activity-logs/activity-logs.selectors.spec.ts
@@ -1,8 +1,9 @@
-import { TestBed } from '@angular/core/testing';
 import { provideStore, Store } from '@ngxs/store';
 
-import { ActivityLogsState } from './activity-logs.state';
+import { TestBed } from '@angular/core/testing';
+
 import { ActivityLogsSelectors } from './activity-logs.selectors';
+import { ActivityLogsState } from './activity-logs.state';
 
 describe('ActivityLogsSelectors', () => {
   let store: Store;
diff --git a/src/app/shared/stores/activity-logs/activity-logs.selectors.ts b/src/app/shared/stores/activity-logs/activity-logs.selectors.ts
@@ -1,4 +1,5 @@
 import { Selector } from '@ngxs/store';
+
 import { ActivityLog, ActivityLogWithDisplay } from '@shared/models/activity-logs';
 
 import { ActivityLogsStateModel } from './activity-logs.model';
diff --git a/src/app/shared/stores/activity-logs/activity-logs.state.spec.ts b/src/app/shared/stores/activity-logs/activity-logs.state.spec.ts
@@ -1,17 +1,18 @@
 import { provideStore, Store } from '@ngxs/store';
+
+import { provideHttpClient } from '@angular/common/http';
 import { HttpTestingController, provideHttpClientTesting } from '@angular/common/http/testing';
 import { inject, TestBed } from '@angular/core/testing';
-import { provideHttpClient } from '@angular/common/http';
 
 import { ActivityLogDisplayService } from '@shared/services';
 
 import { ClearActivityLogsStore, GetActivityLogs, GetRegistrationActivityLogs } from './activity-logs.actions';
 import { ActivityLogsState } from './activity-logs.state';
 
 import {
-  getActivityLogsResponse,
-  buildRegistrationLogsUrl,
   buildNodeLogsUrl,
+  buildRegistrationLogsUrl,
+  getActivityLogsResponse,
 } from '@testing/data/activity-logs/activity-logs.data';
 
 describe('State: ActivityLogs', () => {
diff --git a/src/app/shared/stores/activity-logs/activity-logs.state.ts b/src/app/shared/stores/activity-logs/activity-logs.state.ts
@@ -1,4 +1,5 @@
 import { Action, State, StateContext } from '@ngxs/store';
+
 import { catchError, EMPTY } from 'rxjs';
 import { tap } from 'rxjs/operators';
 
diff --git a/src/testing/data/activity-logs/activity-logs.data.ts b/src/testing/data/activity-logs/activity-logs.data.ts
@@ -1,5 +1,5 @@
-import structuredClone from 'structured-clone';
 import { environment } from 'src/environments/environment';
+import structuredClone from 'structured-clone';
 
 export const ACTIVITY_LOGS_EMBEDS_QS =
   'embed%5B%5D=original_node&embed%5B%5D=user&embed%5B%5D=linked_node&embed%5B%5D=linked_registration&embed%5B%5D=template_node&embed%5B%5D=group';
@@ -13,7 +13,12 @@ export function buildRegistrationLogsUrl(
   return `${apiBase}/v2/registrations/${registrationId}/logs/?${ACTIVITY_LOGS_EMBEDS_QS}&page=${page}&page%5Bsize%5D=${pageSize}`;
 }
 
-export function buildNodeLogsUrl(projectId: string, page: number, pageSize: number, apiBase = environment.apiDomainUrl) {
+export function buildNodeLogsUrl(
+  projectId: string,
+  page: number,
+  pageSize: number,
+  apiBase = environment.apiDomainUrl
+) {
   return `${apiBase}/v2/nodes/${projectId}/logs/?${ACTIVITY_LOGS_EMBEDS_QS}&page=${page}&page%5Bsize%5D=${pageSize}`;
 }
 
@@ -37,12 +42,12 @@ export function makeActivityLogsResponse(logs: AnyObj[] = [], total?: number) {
   const data = logs.length
     ? logs
     : [
-      makeActivityLog(),
-      makeActivityLog({
-        id: 'log2',
-        attributes: { action: 'create', date: '2024-01-02T00:00:00Z', params: {} },
-      }),
-    ];
+        makeActivityLog(),
+        makeActivityLog({
+          id: 'log2',
+          attributes: { action: 'create', date: '2024-01-02T00:00:00Z', params: {} },
+        }),
+      ];
 
   return structuredClone({
     data,

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`import { SafeHtml } from '@angular/platform-browser';`
	`2`	`+`
`2`	`3`	`import { ActivityLog } from './activity-logs.model';`
`3`	`4`
`4`	`5`	`export interface ActivityLogWithDisplay extends ActivityLog {`