fix(addons): fix redirect addons terms button (#846)

Author: futa-ikeda

src/app/features/settings/settings-addons/components/connect-addon/connect-addon.component.html

@@ -33,12 +33,24 @@ <h2>
                 routerLink="/settings/addons"
                 data-test-addon-cancel-button
               ></p-button>
-              <p-button
-                [label]="'settings.addons.form.buttons.next' | translate"
-                class="w-10rem btn-full-width"
-                (onClick)="activateCallback(ProjectAddonsStepperValue.SETUP_NEW_ACCOUNT)"
-                data-test-addon-terms-confirm-button
-              ></p-button>
+              @if (addonTypeString() === AddonType.REDIRECT) {
+                <p-button
+                  [label]="
+                    'settings.addons.connectAddon.redirectAddons.goToService'
+                      | translate: { serviceName: addon()?.displayName }
+                  "
+                  class="w-10rem btn-full-width"
+                  (onClick)="goToService()"
+                  data-test-addon-redirect-button
+                />
+              } @else {
+                <p-button
+                  [label]="'settings.addons.form.buttons.next' | translate"
+                  class="w-10rem btn-full-width"
+                  (onClick)="activateCallback(ProjectAddonsStepperValue.SETUP_NEW_ACCOUNT)"
+                  data-test-addon-terms-confirm-button
+                ></p-button>
+              }
             </div>
           </section>
         </ng-template>

src/app/features/settings/settings-addons/components/connect-addon/connect-addon.component.ts

@@ -119,6 +119,22 @@ export class ConnectAddonComponent {
     });
   }
 
+  goToService() {
+    if (!this.redirectUrl()) return;
+
+    const newWindow = window.open(
+      this.redirectUrl()!.toString(),
+      '_blank',
+      'popup,width=600,height=600,scrollbars=yes,resizable=yes'
+    );
+    if (newWindow) {
+      this.router.navigate([`${this.baseUrl()}/addons`]);
+      newWindow.focus();
+    } else {
+      this.toastService.showError('addons.redirect.popUpError');
+    }
+  }
+
   private startOauthFlow(createdAddon: AuthorizedAccountModel): void {
     this.addonAuthUrl.set(createdAddon.authUrl!);
     window.open(createdAddon.authUrl!, '_blank');

src/app/shared/helpers/addon-type.helper.ts

@@ -48,6 +48,8 @@ export function getAddonTypeString(addon: AddonModel | AuthorizedAccountModel |
     return AddonType.STORAGE;
   } else if (isLinkAddon(addon)) {
     return AddonType.LINK;
+  } else if (isRedirectAddon(addon)) {
+    return AddonType.REDIRECT;
   } else {
     return AddonType.CITATION;
   }