Merge pull request #361 from hmoco/feature/auto

[EOSF-601] Only send metrics when license is actually being saved

Author: brianjgeiger

app/controllers/submit.js

@@ -399,16 +399,6 @@ export default Ember.Controller.extend(Analytics, BasicsValidations, NodeActions
                 basicsLicense,
                 licenseValid
             });
-
-            if (this.get('initialLicenseChangeMade') || this.get('editMode')) {
-                Ember.get(this, 'metrics')
-                    .trackEvent({
-                        category: 'dropdown',
-                        action: 'select',
-                        label: `${this.get('editMode') ? 'Edit' : 'Submit'} - Edit License`
-                    });
-            }
-            this.set('initialLicenseChangeMade', true);
         },
         applyLicenseToggle(apply) {
             this.set('applyLicense', apply);
@@ -762,6 +752,12 @@ export default Ember.Controller.extend(Analytics, BasicsValidations, NodeActions
                     },
                     license: this.get('basicsLicense.licenseType')
                 });
+                Ember.get(this, 'metrics')
+                    .trackEvent({
+                        category: 'dropdown',
+                        action: 'select',
+                        label: `${this.get('editMode') ? 'Edit' : 'Submit'} - Edit License`
+                    });
             }
 
             Promise.all([

package.json

@@ -39,8 +39,8 @@
     "ember-cli-code-coverage": "0.3.11",
     "ember-cli-dependency-checker": "1.2.0",
     "ember-cli-dropzonejs": "0.7.0",
-    "ember-cli-fake-server": "0.3.2",
     "ember-cli-eslint": "3.0.3",
+    "ember-cli-fake-server": "0.3.2",
     "ember-cli-htmlbars": "1.0.3",
     "ember-cli-htmlbars-inline-precompile": "0.3.6",
     "ember-cli-inject-live-reload": "1.4.0",
@@ -58,17 +58,16 @@
     "ember-collection": "1.0.0-alpha.6",
     "ember-cp-validations": "2.9.4",
     "ember-data": "2.7.0",
-    "ember-export-application-global": "1.0.5",
     "ember-data-factory-guy": "2.11.6",
+    "ember-export-application-global": "1.0.5",
     "ember-faker": "^1.1.1",
     "ember-font-awesome": "2.1.1",
     "ember-get-config": "0.0.4",
     "ember-i18n": "4.3.1",
     "ember-link-action": "0.0.35",
-    "ember-lodash": "3.10.0",
     "ember-load-initializers": "0.5.1",
     "ember-metrics": "0.6.3",
-    "ember-osf": "0.5.0",
+    "ember-osf": "0.5.2",
     "ember-page-title": "3.0.6",
     "ember-power-select": "1.0.0-beta.7",
     "ember-read-more": "0.0.13",

yarn.lock

@@ -2662,14 +2662,6 @@ [email protected]:
   version "0.5.1"
   resolved "https://registry.yarnpkg.com/ember-load-initializers/-/ember-load-initializers-0.5.1.tgz#76e3db23c111dbdcd3ae6f687036bf0b56be0cbe"
 
-[email protected]:
-  version "3.10.0"
-  resolved "https://registry.yarnpkg.com/ember-lodash/-/ember-lodash-3.10.0.tgz#a717dffea1e93c1583d5f91f793fed74ed66c20b"
-  dependencies:
-    broccoli-merge-trees "^1.1.1"
-    ember-cli-babel "^5.1.6"
-    lodash-es "3.10.1"
-
 [email protected]:
   version "0.6.3"
   resolved "https://registry.yarnpkg.com/ember-metrics/-/ember-metrics-0.6.3.tgz#9716a4bb68e6e59a6631b9cd5698e75b264b6d30"
@@ -2697,9 +2689,9 @@ ember-new-computed@^1.0.2:
   dependencies:
     ember-cli-babel "^5.1.5"
 
-[email protected].0:
-  version "0.5.0"
-  resolved "https://registry.yarnpkg.com/ember-osf/-/ember-osf-0.5.0.tgz#849d804644546cfded596311f688dd10855688cf"
+[email protected].2:
+  version "0.5.2"
+  resolved "https://registry.yarnpkg.com/ember-osf/-/ember-osf-0.5.2.tgz#e5617e6b6f41dd5bcbc97d4e996fa6e6f2521175"
   dependencies:
     broccoli-funnel "^1.0.1"
     broccoli-merge-trees "^1.1.1"
@@ -4657,10 +4649,6 @@ lockfile@~1.0.1:
   version "1.0.3"
   resolved "https://registry.yarnpkg.com/lockfile/-/lockfile-1.0.3.tgz#2638fc39a0331e9cac1a04b71799931c9c50df79"
 
-[email protected]:
-  version "3.10.1"
-  resolved "https://registry.yarnpkg.com/lodash-es/-/lodash-es-3.10.1.tgz#a1c85d9829c9009004339dc3846dbabb46cf4e19"
-
 lodash._arraycopy@^3.0.0:
   version "3.0.0"
   resolved "https://registry.yarnpkg.com/lodash._arraycopy/-/lodash._arraycopy-3.0.0.tgz#76e7b7c1f1fb92547374878a562ed06a3e50f6e1"