Skip to content

Commit 0da7bb7

Browse files
authored
fixed redundant unless (#2597)
1 parent e91e375 commit 0da7bb7

File tree

1 file changed

+33
-39
lines changed

1 file changed

+33
-39
lines changed

app/guid-node/template.hbs

Lines changed: 33 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -99,55 +99,49 @@
9999
@label={{t 'node.left_nav.registrations'}}
100100
/>
101101
{{/unless}}
102-
{{#unless this.currentUser.viewOnlyToken}}
103-
{{#if (and (not this.viewOnly) this.model.taskInstance.value.userHasReadPermission)}}
102+
{{#if (and (not this.viewOnly) this.model.taskInstance.value.userHasReadPermission)}}
103+
<leftNav.link
104+
data-test-contributors-link
105+
data-analytics-name='Contributors'
106+
@href='/{{this.model.taskInstance.value.id}}/contributors/'
107+
@icon='users'
108+
@label={{t 'node.left_nav.contributors'}}
109+
/>
110+
{{#if this.useGravyWaffle}}
104111
<leftNav.link
105-
data-test-contributors-link
106-
data-analytics-name='Contributors'
107-
@href='/{{this.model.taskInstance.value.id}}/contributors/'
108-
@icon='users'
109-
@label={{t 'node.left_nav.contributors'}}
112+
data-test-addons-link
113+
data-analytics-name='Add-ons'
114+
@route='guid-node.addons'
115+
@models={{array this.model.taskInstance.value.id}}
116+
@icon='database'
117+
@label={{t 'node.left_nav.add-ons'}}
118+
/>
119+
{{else}}
120+
<leftNav.link
121+
data-test-addons-link
122+
data-analytics-name='Add-ons'
123+
@href='/{{this.model.taskInstance.value.id}}/addons/'
124+
@icon='database'
125+
@label={{t 'node.left_nav.add-ons'}}
110126
/>
111127
{{/if}}
112-
{{#if (and (not this.viewOnly) this.model.taskInstance.value.userHasWritePermission)}}
113-
{{#if this.useGravyWaffle}}
114-
<leftNav.link
115-
data-test-addons-link
116-
data-analytics-name='Add-ons'
117-
@route='guid-node.addons'
118-
@models={{array this.model.taskInstance.value.id}}
119-
@icon='database'
120-
@label={{t 'node.left_nav.add-ons'}}
121-
/>
122-
{{else}}
123-
<leftNav.link
124-
data-test-addons-link
125-
data-analytics-name='Add-ons'
126-
@href='/{{this.model.taskInstance.value.id}}/addons/'
127-
@icon='database'
128-
@label={{t 'node.left_nav.add-ons'}}
129-
/>
130-
{{/if}}
131-
{{/if}}
132-
{{/unless}}
128+
{{/if}}
133129
<leftNav.link
134130
data-test-verified-links-link
135131
data-analytics-name='Linked services'
136132
@route='guid-node.links'
137133
@icon='link'
138134
@label={{t 'node.left_nav.links'}}
139135
/>
140-
{{#unless this.currentUser.viewOnlyToken}}
141-
{{#if (and (not this.viewOnly) this.model.taskInstance.value.userHasReadPermission)}}
142-
<leftNav.link
143-
data-test-settings-link
144-
data-analytics-name='Settings'
145-
@href='/{{this.model.taskInstance.value.id}}/settings/'
146-
@icon='cogs'
147-
@label={{t 'node.left_nav.settings'}}
148-
/>
149-
{{/if}}
150-
{{/unless}}
136+
{{#if (and (not this.viewOnly) this.model.taskInstance.value.userHasReadPermission)}}
137+
<leftNav.link
138+
data-test-settings-link
139+
data-analytics-name='Settings'
140+
@href='/{{this.model.taskInstance.value.id}}/settings/'
141+
@icon='cogs'
142+
@label={{t 'node.left_nav.settings'}}
143+
/>
144+
{{/if}}
151145
</layout.leftNavOld>
152146
<layout.main local-class='OverviewBody'>
153147
<div data-analytics-scope='Node' role='main'>

0 commit comments

Comments
 (0)