Skip to content

Commit 4320073

Browse files
authored
[No ticket] Update language and counts on summary page (#2381)
- Ticket: [No ticket] - Feature flag: n/a ## Purpose - Update and clarify language on summary page ## Summary of Changes - Update Registration count to account for embargoed registrations - Update label - Update labels for Licenses, Add-ons, Storage Region graphs
1 parent 0a3b593 commit 4320073

File tree

4 files changed

+13
-9
lines changed

4 files changed

+13
-9
lines changed

app/institutions/dashboard/-components/chart-kpi-wrapper/component-test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,7 @@ module('Integration | institutions | dashboard | -components | kpi-chart-wrapper
224224

225225
// And the title is verified
226226
assert.dom(`${parentDom} [data-test-chart-title]`)
227-
.hasText('Licenses');
227+
.hasText('Top 10 Licenses');
228228

229229
// And the expanded data position 0 name is verified
230230
assert.dom(`${parentDom} [data-test-expanded-name="0"]`)
@@ -259,7 +259,7 @@ module('Integration | institutions | dashboard | -components | kpi-chart-wrapper
259259

260260
// And the title is verified
261261
assert.dom(`${parentDom} [data-test-chart-title]`)
262-
.hasText('Add-ons');
262+
.hasText('Top 10 Add-ons');
263263

264264
// And the expanded data position 0 name is verified
265265
assert.dom(`${parentDom} [data-test-expanded-name="0"]`)
@@ -295,7 +295,7 @@ module('Integration | institutions | dashboard | -components | kpi-chart-wrapper
295295

296296
// And the title is verified
297297
assert.dom(`${parentDom} [data-test-chart-title]`)
298-
.hasText('Storage Regions');
298+
.hasText('Top Storage Regions');
299299

300300
// And the expanded data position 0 name is verified
301301
assert.dom(`${parentDom} [data-test-expanded-name="0"]`)

app/institutions/dashboard/-components/total-count-kpi-wrapper/component-test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ module('Integration | institutions | dashboard | -components | total-count-kpi-w
8080
assert.dom(parentContainer)
8181
.exists('The Total Registration Widget exists');
8282
assert.dom(parentContainer)
83-
.hasText('100 OSF Registrations');
83+
.hasText('300 OSF Public and Embargoed Registrations');
8484
assert.dom(`${parentContainer} [data-test-kpi-icon]`)
8585
.hasAttribute('data-icon', 'archive');
8686

app/institutions/dashboard/-components/total-count-kpi-wrapper/component.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,10 @@ export default class TotalCountKpiWrapperComponent extends Component<TotalCountK
4141
return summaryMetrics.privateProjectCount + summaryMetrics.publicProjectCount;
4242
}
4343

44+
private calculateRegistrations(summaryMetrics: InstitutionSummaryMetricModel): number {
45+
return summaryMetrics.embargoedRegistrationCount + summaryMetrics.publicRegistrationCount;
46+
}
47+
4448
@task
4549
@waitFor
4650
private async loadData(): Promise<void> {
@@ -70,7 +74,7 @@ export default class TotalCountKpiWrapperComponent extends Component<TotalCountK
7074
},
7175
{
7276
title: this.intl.t('institutions.dashboard.kpi-panel.registrations'),
73-
total: metrics.summaryMetrics.publicRegistrationCount,
77+
total: this.calculateRegistrations(metrics.summaryMetrics),
7478
icon: 'archive',
7579
},
7680
{

translations/en-us.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -837,7 +837,7 @@ institutions:
837837
kpi-panel:
838838
users: 'Total Users'
839839
projects: 'OSF Public and Private Projects'
840-
registrations: 'OSF Registrations'
840+
registrations: 'OSF Public and Embargoed Registrations'
841841
preprints: 'OSF Preprints'
842842
storage: 'Total Storage in {unit}'
843843
file-count: 'Total Public File Count'
@@ -859,9 +859,9 @@ institutions:
859859
total-osf-objects:
860860
title: 'Total OSF Objects'
861861
preprints: 'Preprints'
862-
licenses: 'Licenses'
863-
add-ons: 'Add-ons'
864-
storage-regions: 'Storage Regions'
862+
licenses: 'Top 10 Licenses'
863+
add-ons: 'Top 10 Add-ons'
864+
storage-regions: 'Top Storage Regions'
865865
public-vs-private-data-storage:
866866
title: 'Public vs Private Data Storage'
867867
public: 'Public Data Storage'

0 commit comments

Comments
 (0)