Skip to content

Commit 626c5cb

Browse files
committed
Fix make-decision-dd failing tests
1 parent 04ed397 commit 626c5cb

File tree

2 files changed

+3
-7
lines changed

2 files changed

+3
-7
lines changed

lib/osf-components/addon/components/registries/review-actions-list/component.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import { A } from '@ember/array';
12
import { action } from '@ember/object';
23
import { inject as service } from '@ember/service';
34
import Component from '@glimmer/component';
@@ -28,14 +29,13 @@ export default class ReviewActionsList extends Component<Args> {
2829

2930
get latestAction() {
3031
const { reviewActions } = this;
31-
return (reviewActions || [])[0];
32+
return A(reviewActions || []).objectAt(0);
3233
}
3334

3435
@task({ withTestWaiter: true })
3536
fetchActions = task(function *(this: ReviewActionsList) {
3637
try {
37-
const reviewActions = yield this.args.registration.reviewActions;
38-
this.reviewActions = reviewActions.toArray();
38+
this.reviewActions = yield this.args.registration.reviewActions;
3939
} catch (e) {
4040
captureException(e);
4141
this.toast.error(getApiErrorMessage(e));

mirage/config.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -242,10 +242,6 @@ export default function(this: Server) {
242242
relatedModelName: 'registration',
243243
});
244244
this.get('/providers/registrations/:parentID/registrations/', getProviderRegistrations);
245-
osfNestedResource(this, 'registration-provider', 'actions', {
246-
path: '/providers/registrations/:parentID/actions/',
247-
relatedModelName: 'review-action',
248-
});
249245
osfNestedResource(this, 'registration-provider', 'licensesAcceptable', {
250246
only: ['index'],
251247
path: '/providers/registrations/:parentID/licenses/',

0 commit comments

Comments
 (0)