Skip to content

Commit 684c877

Browse files
authored
[ENG-6567][ENG-6598] Fix dropdown placement for mobile (#2408)
* Fix dropdown placement for mobile * a11y fix for items per page dropdown
1 parent 30b2b8e commit 684c877

File tree

2 files changed

+10
-8
lines changed
  • app/institutions/dashboard/-components/institutional-users-list
  • lib/osf-components/addon/components/adjustable-paginator

2 files changed

+10
-8
lines changed

app/institutions/dashboard/-components/institutional-users-list/styles.scss

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,6 @@
139139

140140
&.mobile {
141141
max-width: none;
142-
right: 100%;
143142
}
144143
}
145144

lib/osf-components/addon/components/adjustable-paginator/template.hbs

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,15 @@
11
<span local-class='paginator__control'>
22
<div local-class='paginator__select-wrapper'>
3-
<select title={{t 'paginator.itemsPerPage'}} local-class='paginator__select' onchange={{action this.onPageSizeChange value='target.value'}}>
4-
{{#each this.pageSizeOptions as |page_size_option|}}
5-
<option value={{page_size_option}} selected={{eq page_size_option this.selectedPageSize}}>
6-
{{t 'paginator.itemsPerPage'}} {{page_size_option}}
7-
</option>
8-
{{/each}}
9-
</select>
3+
<label>
4+
{{t 'paginator.itemsPerPage'}}
5+
<select local-class='paginator__select' onchange={{action this.onPageSizeChange value='target.value'}}>
6+
{{#each this.pageSizeOptions as |page_size_option|}}
7+
<option value={{page_size_option}} selected={{eq page_size_option this.selectedPageSize}}>
8+
{{page_size_option}}
9+
</option>
10+
{{/each}}
11+
</select>
12+
</label>
1013
</div>
1114
</span>
1215

0 commit comments

Comments
 (0)