Feature/pbs 25 10 (#2578)

* fix: use compact IRIs to match the api

(yet todo: json-ld parsing that would handle either)

* fix: IRIs represented as {"@id": "..."}

* (partly) fix types

* [ENG-7876] Feature/file picker select root (#2556)

* Added the files

* Removed tokens

* Updates to display the selected root folder

* Added GFP to the files page

* Updates to add the root folder

* Added the manager to reload the wb once a new file or folder is selected

* Enabled the disabled button featuree again

* Fixed a test

* Updates to the flow for a token from the BE

* Added the final touches and removed pruned instructions

* Updates for the PR

* Updates to move all the google file picker code into the component

* Cleaned up comments and models

* Update for PR request

* do not send initiate_oauth after oauth flow is successful

* fix

* Removed a call to a function

* Added functionality so the GD menu item and select folder are not enabled until oauth token is loaded (#2571)

* Removed a call to a function

* Updates to disable the menu and select folder button until the token is loaded

* remove unnecessary group embed

* Fixed a css issue (#2577)

---------

Co-authored-by: abram axel booth <boothaa@gmail.com>
Co-authored-by: abram axel booth <aaxelb@users.noreply.github.com>
Co-authored-by: Lord Business <113387478+bp-cos@users.noreply.github.com>
Co-authored-by: Brian Pilati <brianpilati@cos.io>
Co-authored-by: John Tordoff <Johnetordoff@users.noreply.github.com>

Author: 4 people

app/config/environment.d.ts

@@ -141,6 +141,12 @@ declare const config: {
         doiUrlPrefix: string;
         dataciteTrackerRepoId: string;
         dataCiteTrackerUrl: string;
+        googleFilePicker: {
+            GOOGLE_FILE_PICKER_SCOPES: string;
+            GOOGLE_FILE_PICKER_CLIENT_ID: string;
+            GOOGLE_FILE_PICKER_API_KEY: string;
+            GOOGLE_FILE_PICKER_APP_ID: number;
+        }
     };
     social: {
         twitter: {

app/guid-node/files/provider/template.hbs

@@ -7,6 +7,7 @@
     >
         <div local-class='FileBrowser'>
             <FileBrowser
+                @configuredStorageAddon={{this.model.configuredStorageAddon}}
                 @manager={{manager}}
                 @selectable={{not this.model.providerTask.value.currentUser.viewOnlyToken}}
                 @enableUpload={{true}}

app/models/authorized-account.ts

@@ -1,4 +1,4 @@
-import Model, { attr } from '@ember-data/model';
+import Model, { attr} from '@ember-data/model';
 import { OperationKwargs } from 'ember-osf-web/models/addon-operation-invocation';
 
 export enum ConnectedCapabilities {
@@ -36,7 +36,6 @@ export default class AuthorizedAccountModel extends Model {
         return;
     }
 
-
     async getItemInfo(this: AuthorizedAccountModel, _itemId: string) : Promise<any> {
         // To be implemented in child classes
         return;

app/models/authorized-storage-account.ts

@@ -1,13 +1,16 @@
-import { AsyncBelongsTo, belongsTo } from '@ember-data/model';
+import { AsyncBelongsTo, attr, belongsTo } from '@ember-data/model';
 import { waitFor } from '@ember/test-waiters';
 import { task } from 'ember-concurrency';
 import { ConnectedStorageOperationNames, OperationKwargs } from 'ember-osf-web/models/addon-operation-invocation';
+import ExternalStorageServiceModel from 'ember-osf-web/models/external-storage-service';
 
-import ExternalStorageServiceModel from './external-storage-service';
 import AuthorizedAccountModel from './authorized-account';
 import UserReferenceModel from './user-reference';
 
 export default class AuthorizedStorageAccountModel extends AuthorizedAccountModel {
+    @attr('fixstring') serializeOauthToken!: string;
+    @attr('fixstring') oauthToken!: string;
+
     @belongsTo('user-reference', { inverse: 'authorizedStorageAccounts' })
     readonly accountOwner!: AsyncBelongsTo<UserReferenceModel> & UserReferenceModel;
 

app/models/index-card-search.ts

@@ -10,7 +10,7 @@ export interface SearchFilter {
     filterType?: string;
 }
 
-export const ShareMoreThanTenThousand = 'https://share.osf.io/vocab/2023/trove/ten-thousands-and-more';
+export const ShareMoreThanTenThousand = 'trove:ten-thousands-and-more';
 
 export default class IndexCardSearchModel extends Model {
     @attr('string') cardSearchText!: string;

app/models/search-result.ts

@@ -314,7 +314,7 @@ export default class SearchResultModel extends Model {
     }
 
     get isWithdrawn() {
-        return this.resourceMetadata.dateWithdrawn || this.resourceMetadata['https://osf.io/vocab/2022/withdrawal'];
+        return this.resourceMetadata.dateWithdrawn || this.resourceMetadata['osf:withdrawal'];
     }
 
     get configuredAddonNames() {

app/packages/addons-service/provider.ts

@@ -237,6 +237,7 @@ export default class Provider {
             accountOwner: this.userReference,
         });
         await newAccount.save();
+        newAccount.initiateOauth = null;
         return newAccount;
     }
 

config/environment.js

@@ -102,6 +102,13 @@ const {
     SHARE_SEARCH_URL: shareSearchUrl = 'http://localhost:8003/api/v2/search/creativeworks/_search',
     SOURCEMAPS_ENABLED: sourcemapsEnabled = true,
     SHOW_DEV_BANNER = false,
+
+    GOOGLE_FILE_PICKER_SCOPES,
+    /* eslint-disable-next-line max-len */
+    GOOGLE_FILE_PICKER_CLIENT_ID,
+    GOOGLE_FILE_PICKER_API_KEY,
+    GOOGLE_FILE_PICKER_APP_ID,
+
 } = { ...process.env, ...localConfig };
 
 module.exports = function(environment) {
@@ -224,6 +231,12 @@ module.exports = function(environment) {
             doiUrlPrefix: 'https://doi.org/',
             dataciteTrackerRepoId,
             dataCiteTrackerUrl,
+            googleFilePicker: {
+                GOOGLE_FILE_PICKER_SCOPES,
+                GOOGLE_FILE_PICKER_CLIENT_ID,
+                GOOGLE_FILE_PICKER_API_KEY,
+                GOOGLE_FILE_PICKER_APP_ID,
+            },
         },
         social: {
             twitter: {

lib/osf-components/addon/components/activity-log/component.ts

@@ -4,7 +4,7 @@ export default class ActivityLogComponent extends Component {
     public loadEmbeds = {
         embed:
             [
-                'group', 'linked_node', 'linked_registration', 'original_node',
+                'linked_node', 'linked_registration', 'original_node',
                 'template_node', 'user',
             ],
     };

lib/osf-components/addon/components/addons-service/configured-addon-edit/component.ts

@@ -1,7 +1,10 @@
 import { action } from '@ember/object';
+import { waitFor } from '@ember/test-waiters';
 import Component from '@glimmer/component';
 import { tracked } from '@glimmer/tracking';
-import { TaskInstance } from 'ember-concurrency';
+import { task, TaskInstance } from 'ember-concurrency';
+import { taskFor } from 'ember-concurrency-ts';
+
 
 import { Item, ItemType } from 'ember-osf-web/models/addon-operation-invocation';
 import AuthorizedAccountModel from 'ember-osf-web/models/authorized-account';
@@ -12,6 +15,7 @@ import ConfiguredAddonModel from 'ember-osf-web/models/configured-addon';
 import ConfiguredCitationAddonModel from 'ember-osf-web/models/configured-citation-addon';
 import ConfiguredComputingAddonModel from 'ember-osf-web/models/configured-computing-addon';
 import ConfiguredStorageAddonModel from 'ember-osf-web/models/configured-storage-addon';
+import ExternalStorageServiceModel from 'ember-osf-web/models/external-storage-service';
 
 
 interface Args {
@@ -25,6 +29,8 @@ export default class ConfiguredAddonEdit extends Component<Args> {
     @tracked selectedFolder = this.args.configuredAddon?.rootFolder;
     @tracked selectedFolderDisplayName = this.args.configuredAddon?.rootFolderName;
     @tracked currentItems: Item[] = [];
+    @tracked isWBGoogleDrive = false;
+    @tracked accountId!: string;
 
     originalName = this.displayName;
     originalRootFolder = this.selectedFolder;
@@ -34,6 +40,7 @@ export default class ConfiguredAddonEdit extends Component<Args> {
         super(owner, args);
         if (this.args.configuredAddon) {
             if (this.args.configuredAddon instanceof ConfiguredStorageAddonModel) {
+                taskFor(this.loadExternalStorageService).perform();
                 this.defaultKwargs['itemType'] = ItemType.Folder;
             }
             if (this.args.configuredAddon instanceof ConfiguredCitationAddonModel) {
@@ -42,6 +49,7 @@ export default class ConfiguredAddonEdit extends Component<Args> {
         }
         if (this.args.authorizedAccount) {
             if (this.args.authorizedAccount instanceof AuthorizedStorageAccountModel) {
+                taskFor(this.loadExternalStorageService).perform();
                 this.defaultKwargs['itemType'] = ItemType.Folder;
             }
             if (this.args.authorizedAccount instanceof AuthorizedCitationAccountModel) {
@@ -50,6 +58,28 @@ export default class ConfiguredAddonEdit extends Component<Args> {
         }
     }
 
+    /**
+     * This is called only to authorize because the current implementation will throw an
+     * error because the "root folder" is not yet set.
+     */
+    @task
+    @waitFor
+    async loadExternalStorageService() {
+        let external!: ExternalStorageServiceModel;
+        if (this.args.configuredAddon && this.args.configuredAddon instanceof ConfiguredStorageAddonModel) {
+            const baseAccount = await this.args.configuredAddon.baseAccount;
+            this.accountId = baseAccount?.id;
+            external = await this.args.configuredAddon.externalStorageService;
+        }
+        if (this.args.authorizedAccount && this.args.authorizedAccount instanceof AuthorizedStorageAccountModel) {
+            external = await this.args.authorizedAccount.externalStorageService;
+
+            this.accountId =  this.args.authorizedAccount.id;
+        }
+
+        this.isWBGoogleDrive = external?.wbKey === 'googledrive';
+    }
+
     get requiresRootFolder() {
         return !(
             this.args.authorizedAccount instanceof AuthorizedComputingAccountModel
@@ -58,6 +88,14 @@ export default class ConfiguredAddonEdit extends Component<Args> {
         );
     }
 
+    get isGoogleDrive(): boolean {
+        return this.isWBGoogleDrive;
+    }
+
+    get displayFileManager(): boolean {
+        return this.requiresRootFolder && !this.isGoogleDrive;
+    }
+
     get invalidDisplayName() {
         return !this.displayName || this.displayName?.trim().length === 0;
     }