Skip to content

Commit 8fd6d61

Browse files
author
chiku
committed
Avoid None check of enum_*_fields by prohibiting None type.
1 parent 212fae3 commit 8fd6d61

File tree

1 file changed

+4
-7
lines changed

1 file changed

+4
-7
lines changed

addon_service/admin/_base.py

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -46,11 +46,11 @@ def has_changed(self, initial, data):
4646

4747

4848
class GravyvaletModelAdmin(admin.ModelAdmin):
49-
enum_choice_fields: dict[str, type[enum.Enum]] | None = None
50-
enum_multiple_choice_fields: dict[str, type[enum.Enum]] | None = None
49+
enum_choice_fields: dict[str, type[enum.Enum]] = {}
50+
enum_multiple_choice_fields: dict[str, type[enum.Enum]] = {}
5151

5252
def formfield_for_dbfield(self, db_field, request, **kwargs):
53-
if self.enum_choice_fields and db_field.name in self.enum_choice_fields:
53+
if db_field.name in self.enum_choice_fields:
5454
_enum = self.enum_choice_fields[db_field.name]
5555
return forms.ChoiceField(
5656
label=db_field.verbose_name,
@@ -59,10 +59,7 @@ def formfield_for_dbfield(self, db_field, request, **kwargs):
5959
*self._list_enum_members(_enum),
6060
],
6161
)
62-
if (
63-
self.enum_multiple_choice_fields
64-
and db_field.name in self.enum_multiple_choice_fields
65-
):
62+
if db_field.name in self.enum_multiple_choice_fields:
6663
_enum = self.enum_multiple_choice_fields[db_field.name]
6764
return EnumNameMultipleChoiceField(
6865
choices=self._list_enum_members(_enum),

0 commit comments

Comments
 (0)