Skip to content

Commit fe04087

Browse files
committed
Merge branch 'hotfix/stop-logging-keen'
2 parents 5523707 + 206f3ee commit fe04087

File tree

2 files changed

+16
-6
lines changed

2 files changed

+16
-6
lines changed

mfr/core/remote_logging.py

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414

1515
async def log_analytics(request, metrics, is_error=False):
1616
"""Send events to Keen describing the action that occurred."""
17-
if settings.KEEN_PRIVATE_PROJECT_ID is None:
17+
if not settings.KEEN_ENABLE_LOGGING:
1818
return
1919

2020
keen_payload = copy.deepcopy(metrics)
@@ -78,11 +78,17 @@ async def log_analytics(request, metrics, is_error=False):
7878

7979
# send the private payload
8080
private_collection = 'mfr_errors' if is_error else 'mfr_action'
81-
await _send_to_keen(keen_payload, private_collection, settings.KEEN_PRIVATE_PROJECT_ID,
82-
settings.KEEN_PRIVATE_WRITE_KEY, keen_payload['handler']['type'],
83-
domain='private')
84-
85-
if keen_payload['handler']['type'] != 'render' or file_metadata is None or is_error:
81+
if ((is_error and settings.KEEN_PRIVATE_LOG_ERRORS) or settings.KEEN_PRIVATE_LOG_VIEWS):
82+
await _send_to_keen(keen_payload, private_collection, settings.KEEN_PRIVATE_PROJECT_ID,
83+
settings.KEEN_PRIVATE_WRITE_KEY, keen_payload['handler']['type'],
84+
domain='private')
85+
86+
if (
87+
keen_payload['handler']['type'] != 'render' or
88+
file_metadata is None or
89+
is_error or
90+
not settings.KEEN_PUBLIC_LOG_VIEWS
91+
):
8692
return
8793

8894
# build and ship the public file stats payload

mfr/server/settings.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,11 +43,15 @@
4343
keen_config = analytics_config.child('KEEN')
4444
KEEN_API_BASE_URL = keen_config.get('API_BASE_URL', 'https://api.keen.io')
4545
KEEN_API_VERSION = keen_config.get('API_VERSION', '3.0')
46+
KEEN_ENABLE_LOGGING = keen_config.get_bool('ENABLE_LOGGING', True)
4647

4748
keen_private_config = keen_config.child('PRIVATE')
4849
KEEN_PRIVATE_PROJECT_ID = keen_private_config.get_nullable('PROJECT_ID', None)
4950
KEEN_PRIVATE_WRITE_KEY = keen_private_config.get_nullable('WRITE_KEY', None)
51+
KEEN_PRIVATE_LOG_VIEWS = keen_private_config.get_bool('LOG_VIEWS', True)
52+
KEEN_PRIVATE_LOG_ERRORS = keen_private_config.get_bool('LOG_ERRORS', True)
5053

5154
keen_public_config = keen_config.child('PUBLIC')
5255
KEEN_PUBLIC_PROJECT_ID = keen_public_config.get_nullable('PROJECT_ID', None)
5356
KEEN_PUBLIC_WRITE_KEY = keen_public_config.get_nullable('WRITE_KEY', None)
57+
KEEN_PUBLIC_LOG_VIEWS = keen_public_config.get_bool('LOG_VIEWS', True)

0 commit comments

Comments
 (0)