Skip to content

Commit afdf68f

Browse files
committed
Fix review links in moderation digest for preprints & registrations
1 parent 4b52580 commit afdf68f

File tree

2 files changed

+7
-10
lines changed

2 files changed

+7
-10
lines changed

notifications/listeners.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ def reviews_withdraw_requests_notification_moderators(self, timestamp, context,
9797
# Set message
9898
context['message'] = f'has requested withdrawal of "{resource.title}".'
9999
# Set submission url
100-
context['reviews_submission_url'] = f'{DOMAIN}reviews/registries/{provider._id}/{resource._id}'
100+
context['reviews_submission_url'] = f'{DOMAIN}registries/{provider._id}/{resource._id}?mode=moderator'
101101
context['localized_timestamp'] = str(timestamp)
102102
NotificationType.Type.PROVIDER_NEW_PENDING_WITHDRAW_REQUESTS.instance.emit(
103103
subscribed_object=provider,

website/reviews/listeners.py

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ def reviews_withdraw_requests_notification_moderators(self, timestamp, context,
3232
from osf.models import NotificationType
3333

3434
context['message'] = f'has requested withdrawal of "{resource.title}".'
35-
context['reviews_submission_url'] = f'{DOMAIN}reviews/registries/{provider._id}/{resource._id}'
35+
context['reviews_submission_url'] = f'{DOMAIN}registries/{provider._id}/{resource._id}?mode=moderator'
3636

3737
context['provider_id'] = provider.id
3838
for group_name in ['moderator', 'admin']:
@@ -60,7 +60,7 @@ def reviews_withdrawal_requests_notification(self, timestamp, context):
6060

6161
preprint_word = preprint.provider.preprint_word
6262
context['message'] = f'has requested withdrawal of the {preprint_word} "{preprint.title}".'
63-
context['reviews_submission_url'] = f'{DOMAIN}reviews/preprints/{preprint.provider._id}/{preprint._id}'
63+
context['reviews_submission_url'] = f'{DOMAIN}preprints/{preprint.provider._id}/{preprint._id}?mode=moderator'
6464

6565
context['provider_id'] = preprint.provider.id
6666
for group_name in ['moderator', 'admin']:
@@ -85,16 +85,13 @@ def reviews_submit_notification_moderators(self, timestamp, resource, context):
8585

8686
provider = resource.provider
8787
context['provider_id'] = provider.id
88-
context['reviews_submission_url'] = (
89-
f'{DOMAIN}reviews/preprints/{provider._id}/{resource._id}'
90-
)
88+
context['reviews_submission_url'] = f'{DOMAIN}preprints/{provider._id}/{resource._id}?mode=moderator'
89+
9190
# Set submission url
9291
if provider.type == 'osf.preprintprovider':
93-
context['reviews_submission_url'] = (
94-
f'{DOMAIN}reviews/preprints/{provider._id}/{resource._id}'
95-
)
92+
context['reviews_submission_url'] = f'{DOMAIN}preprints/{provider._id}/{resource._id}?mode=moderator'
9693
elif provider.type == 'osf.registrationprovider':
97-
context['reviews_submission_url'] = f'{DOMAIN}{resource._id}?mode=moderator'
94+
context['reviews_submission_url'] = f'{DOMAIN}registries/{provider._id}/{resource._id}?mode=moderator'
9895
else:
9996
raise NotImplementedError(f'unsupported provider type {provider.type}')
10097

0 commit comments

Comments
 (0)