Skip to content

Commit 790bb78

Browse files
authored
Merge pull request #1178 from CesiumGS/works-on-mac-with-cmake4
Several maintenance items
2 parents 321236d + 6ba15b9 commit 790bb78

File tree

15 files changed

+26
-347
lines changed

15 files changed

+26
-347
lines changed

.github/workflows/build.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ jobs:
7070
# sed -n '/warning:/,/^$/p' output.log
7171
7272
Documentation:
73-
runs-on: ubuntu-22.04
73+
runs-on: ubuntu-24.04
7474
steps:
7575
- name: Install Doxygen
7676
run: |
@@ -92,7 +92,7 @@ jobs:
9292
- name: ccache
9393
uses: hendrikmuhs/[email protected]
9494
with:
95-
key: ccache-ubuntu-22.04-doxygen
95+
key: ccache-ubuntu-24.04-doxygen
9696
- name: Generate Documentation
9797
run: |
9898
npm install

.github/workflows/prod.yml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ on:
66
- 'cesium.com-staging'
77
jobs:
88
deploy-docs:
9-
runs-on: ubuntu-22.04
9+
runs-on: ubuntu-24.04
1010
env:
1111
AWS_ACCESS_KEY_ID: ${{ secrets.NATIVE_ACCESS_KEY }}
1212
AWS_SECRET_ACCESS_KEY: ${{ secrets.NATIVE_SECRET_KEY }}
@@ -15,9 +15,9 @@ jobs:
1515
- name: Install Doxygen
1616
run: |
1717
cd ~
18-
wget https://github.com/doxygen/doxygen/releases/download/Release_1_12_0/doxygen-1.12.0.linux.bin.tar.gz
19-
tar xzf doxygen-1.12.0.linux.bin.tar.gz
20-
export PATH=$PWD/doxygen-1.12.0/bin:$PATH
18+
wget https://github.com/doxygen/doxygen/releases/download/Release_1_13_2/doxygen-1.13.2.linux.bin.tar.gz
19+
tar xzf doxygen-1.13.2.linux.bin.tar.gz
20+
export PATH=$PWD/doxygen-1.13.2/bin:$PATH
2121
echo "PATH=$PATH" >> "$GITHUB_ENV"
2222
doxygen --version
2323
- name: Check out repository code
@@ -27,15 +27,15 @@ jobs:
2727
- name: ccache
2828
uses: hendrikmuhs/[email protected]
2929
with:
30-
key: ccache-ubuntu-22.04-doxygen
30+
key: ccache-ubuntu-24.04-doxygen
3131
- name: Cache vcpkg artifacts
3232
uses: actions/cache@v4
3333
with:
3434
path: ~/.ezvcpkg
35-
key: vcpkg-ubuntu-22.04-doxygen-${{ hashFiles('CMakeLists.txt') }}
35+
key: vcpkg-ubuntu-24.04-doxygen-${{ hashFiles('CMakeLists.txt') }}
3636
restore-keys: |
37-
vcpkg-ubuntu-22.04-doxygen-${{ hashFiles('CMakeLists.txt') }}
38-
vcpkg-ubuntu-22.04-doxygen
37+
vcpkg-ubuntu-24.04-doxygen-${{ hashFiles('CMakeLists.txt') }}
38+
vcpkg-ubuntu-24.04-doxygen
3939
- name: Mark documentation official
4040
if: ${{ github.ref_name == 'cesium.com' }}
4141
run: |

CMakeLists.txt

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,9 @@ if (NOT VCPKG_OVERLAY_PORTS)
6666
endif()
6767
endif()
6868

69-
list(APPEND VCPKG_OVERLAY_PORTS "${CMAKE_CURRENT_SOURCE_DIR}/extern/vcpkg/ports")
69+
if (EXISTS "${CMAKE_CURRENT_SOURCE_DIR}/extern/vcpkg/ports")
70+
list(APPEND VCPKG_OVERLAY_PORTS "${CMAKE_CURRENT_SOURCE_DIR}/extern/vcpkg/ports")
71+
endif()
7072

7173
message(STATUS "VCPKG_OVERLAY_PORTS ${VCPKG_OVERLAY_PORTS}")
7274

@@ -101,7 +103,7 @@ if(CESIUM_USE_EZVCPKG)
101103
list(APPEND PACKAGES_ALL ${PACKAGES_TEST})
102104

103105
ezvcpkg_fetch(
104-
COMMIT 2024.11.16
106+
COMMIT dbe35ceb30c688bf72e952ab23778e009a578f18
105107
PACKAGES ${PACKAGES_ALL}
106108
# Clean the build trees after building, so that we don't use a ton a disk space on the CI cache
107109
CLEAN_BUILDTREES

Cesium3DTilesSelection/test/TestTilesetSelectionAlgorithm.cpp

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1742,12 +1742,11 @@ TEST_CASE("Additive-refined tiles are added to the tilesFadingOut array") {
17421742
CHECK(updateResult.tilesToRenderThisFrame.size() == 4);
17431743

17441744
// Zoom way out
1745-
std::optional<Cartographic> position = viewState.getPositionCartographic();
1746-
REQUIRE(position);
1747-
position->height += 100000;
1745+
glm::dvec3 position =
1746+
viewState.getPosition() - 100000.0 * viewState.getDirection();
17481747

17491748
ViewState zoomedOut = ViewState(
1750-
Ellipsoid::WGS84.cartographicToCartesian(*position),
1749+
position,
17511750
viewState.getDirection(),
17521751
viewState.getUp(),
17531752
viewState.getViewportSize(),

extern/vcpkg/ports/README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
We prefer that cesium-native work with a stock release of vcpkg.
2+
However, if an overlay port is needed, it can be put in this directory.

extern/vcpkg/ports/ktx/0001-Use-vcpkg-zstd.patch

Lines changed: 0 additions & 122 deletions
This file was deleted.

extern/vcpkg/ports/ktx/0002-Fix-versioning.patch

Lines changed: 0 additions & 17 deletions
This file was deleted.

extern/vcpkg/ports/ktx/0003-mkversion.patch

Lines changed: 0 additions & 13 deletions
This file was deleted.

extern/vcpkg/ports/ktx/0004-quirks.patch

Lines changed: 0 additions & 21 deletions
This file was deleted.

extern/vcpkg/ports/ktx/0005-no-vendored-libs.patch

Lines changed: 0 additions & 17 deletions
This file was deleted.

0 commit comments

Comments
 (0)