earth centered 2D wip

lukemckinstry · lukemckinstry · commit 883932dc7944 · 2025-08-13T09:32:59.000-04:00
diff --git a/packages/engine/Source/Scene/Model/ModelDrawCommands.js b/packages/engine/Source/Scene/Model/ModelDrawCommands.js
@@ -278,8 +278,11 @@ ModelDrawCommands.createCommandBoundingSphere = function (
       );
       instanceBoundingSpheres.push(boundingSphere);
     }
-
-    return BoundingSphere.fromBoundingSpheres(instanceBoundingSpheres, result);
+    const combinedBoundingSphere = BoundingSphere.fromBoundingSpheres(
+      instanceBoundingSpheres,
+      result,
+    );
+    return combinedBoundingSphere;
   }
 
   return BoundingSphere.transform(
diff --git a/packages/engine/Source/Scene/Model/ModelSceneGraph.js b/packages/engine/Source/Scene/Model/ModelSceneGraph.js
@@ -483,7 +483,10 @@ function computeModelMatrix2D(sceneGraph, frameState) {
     scratchComputedTranslation,
   );
 
-  if (!Cartesian3.equals(translation, Cartesian3.ZERO)) {
+  if (
+    !Cartesian3.equals(translation, Cartesian3.ZERO) ||
+    sceneGraph.hasInstances
+  ) {
     sceneGraph._computedModelMatrix2D = Transforms.basisTo2D(
       frameState.mapProjection,
       computedModelMatrix,

Original file line number	Diff line number	Diff line change
`@@ -278,8 +278,11 @@ ModelDrawCommands.createCommandBoundingSphere = function (`
`278`	`278`	`);`
`279`	`279`	`instanceBoundingSpheres.push(boundingSphere);`
`280`	`280`	`}`
`281`		`-`
`282`		`- return BoundingSphere.fromBoundingSpheres(instanceBoundingSpheres, result);`
	`281`	`+ const combinedBoundingSphere = BoundingSphere.fromBoundingSpheres(`
	`282`	`+ instanceBoundingSpheres,`
	`283`	`+ result,`
	`284`	`+ );`
	`285`	`+ return combinedBoundingSphere;`
`283`	`286`	`}`
`284`	`287`
`285`	`288`	`return BoundingSphere.transform(`