Skip to content

Commit c73c62a

Browse files
committed
remove redundant label_number property
- #47 (comment)
1 parent f7264da commit c73c62a

File tree

4 files changed

+0
-97
lines changed

4 files changed

+0
-97
lines changed

chebai/preprocessing/datasets/base.py

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -525,18 +525,6 @@ def raw_file_names_dict(self) -> dict:
525525
"""
526526
raise NotImplementedError
527527

528-
@property
529-
def label_number(self) -> int:
530-
"""
531-
Returns the number of labels.
532-
533-
This property should be implemented by subclasses to provide the number of labels.
534-
535-
Returns:
536-
int: The number of labels. Returns -1 for seq2seq encoding.
537-
"""
538-
raise NotImplementedError
539-
540528

541529
class MergedDataset(XYBaseDataModule):
542530
MERGED = []
@@ -673,13 +661,6 @@ def processed_file_names(self) -> List[str]:
673661
"""
674662
return ["test.pt", "train.pt", "validation.pt"]
675663

676-
@property
677-
def label_number(self) -> int:
678-
"""
679-
Returns the number of labels from the first subset.
680-
"""
681-
return self.subsets[0].label_number
682-
683664
@property
684665
def limits(self):
685666
"""

chebai/preprocessing/datasets/chebi.py

Lines changed: 0 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -89,10 +89,6 @@ def setup_processed(self):
8989
os.path.join(self.processed_dir, f"{k}.pt"),
9090
)
9191

92-
@property
93-
def label_number(self):
94-
return 500
95-
9692

9793
class JCIData(JCIBase):
9894
READER = dr.OrdReader
@@ -546,10 +542,6 @@ def raw_file_names_dict(self) -> dict:
546542

547543
class JCIExtendedBase(_ChEBIDataExtractor):
548544

549-
@property
550-
def label_number(self):
551-
return 500
552-
553545
@property
554546
def _name(self):
555547
return "JCI_extended"
@@ -574,16 +566,6 @@ class ChEBIOverX(_ChEBIDataExtractor):
574566
READER: dr.ChemDataReader = dr.ChemDataReader
575567
THRESHOLD: int = None
576568

577-
@property
578-
def label_number(self) -> int:
579-
"""
580-
Returns the number of labels in the dataset.
581-
582-
Returns:
583-
int: The number of labels.
584-
"""
585-
return 854
586-
587569
@property
588570
def _name(self) -> str:
589571
"""
@@ -676,17 +658,6 @@ class ChEBIOver100(ChEBIOverX):
676658

677659
THRESHOLD: int = 100
678660

679-
def label_number(self) -> int:
680-
"""
681-
Returns the number of labels in the dataset.
682-
683-
Overrides the base class method to return the correct number of labels for this threshold.
684-
685-
Returns:
686-
int: The number of labels.
687-
"""
688-
return 854
689-
690661

691662
class ChEBIOver50(ChEBIOverX):
692663
"""
@@ -700,17 +671,6 @@ class ChEBIOver50(ChEBIOverX):
700671

701672
THRESHOLD: int = 50
702673

703-
def label_number(self) -> int:
704-
"""
705-
Returns the number of labels in the dataset.
706-
707-
Overrides the base class method to return the correct number of labels for this threshold.
708-
709-
Returns:
710-
int: The number of labels.
711-
"""
712-
return 1332
713-
714674

715675
class ChEBIOver100DeepSMILES(ChEBIOverXDeepSMILES, ChEBIOver100):
716676
"""

chebai/preprocessing/datasets/pubchem.py

Lines changed: 0 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -693,13 +693,6 @@ class PubchemChem(PubChem):
693693

694694
READER: Type[dr.ChemDataReader] = dr.ChemDataReader
695695

696-
@property
697-
def label_number(self) -> int:
698-
"""
699-
Returns the label number.
700-
"""
701-
return -1
702-
703696

704697
class PubchemBPE(PubChem):
705698
"""
@@ -713,13 +706,6 @@ class PubchemBPE(PubChem):
713706

714707
READER: Type[dr.ChemBPEReader] = dr.ChemBPEReader
715708

716-
@property
717-
def label_number(self) -> int:
718-
"""
719-
Returns the label number.
720-
"""
721-
return -1
722-
723709

724710
class SWJChem(SWJPreChem):
725711
"""
@@ -733,13 +719,6 @@ class SWJChem(SWJPreChem):
733719

734720
READER: Type[dr.ChemDataUnlabeledReader] = dr.ChemDataUnlabeledReader
735721

736-
@property
737-
def label_number(self) -> int:
738-
"""
739-
Returns the label number.
740-
"""
741-
return -1
742-
743722

744723
class SWJBPE(SWJPreChem):
745724
"""
@@ -753,13 +732,6 @@ class SWJBPE(SWJPreChem):
753732

754733
READER: Type[dr.ChemBPEReader] = dr.ChemBPEReader
755734

756-
@property
757-
def label_number(self) -> int:
758-
"""
759-
Returns the label number.
760-
"""
761-
return -1
762-
763735

764736
class PubChemTokens(PubChem):
765737
"""

chebai/preprocessing/datasets/tox21.py

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -39,11 +39,6 @@ def _name(self) -> str:
3939
"""Returns the name of the dataset."""
4040
return "Tox21MN"
4141

42-
@property
43-
def label_number(self) -> int:
44-
"""Returns the number of labels."""
45-
return 12
46-
4742
@property
4843
def raw_file_names(self) -> List[str]:
4944
"""Returns a list of raw file names."""
@@ -177,11 +172,6 @@ def _name(self) -> str:
177172
"""Returns the name of the dataset."""
178173
return "Tox21Chal"
179174

180-
@property
181-
def label_number(self) -> int:
182-
"""Returns the number of labels."""
183-
return 12
184-
185175
@property
186176
def raw_file_names(self) -> List[str]:
187177
"""Returns a list of raw file names."""

0 commit comments

Comments
 (0)