remove argument links to criterion #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@schnamo Could you please check if this solves your problem with the chebai dev branch? |
schnamo
approved these changes
Feb 14, 2025
Collaborator
schnamo
left a comment
schnamo
left a comment
There was a problem hiding this comment.
Thank you very much, Simon. This does solve the problem I had with the chebai dev branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #69, I added links between
chebi_versionarguments. This way, you only need to type in the chebi version once and avoid the potential for e.g. the semantic loss checking for inconsistencies in version 200, while the training data is from version 231.However, this leads to issues when someone is using a different loss function than
BCEWeighted. Then, the link leads to an argument of the loss function that does not exist, causing an error injsonargparse(the error is shown as anIndexError, but that is the error it raises while trying to generate an error message, not the actual error).For now, I removed the argument linking.