Skip to content

Commit 7a97479

Browse files
author
=
committed
Merged:
- [Fix Dockerfile megadose#210](megadose#210) - [Fix broken setup.py (missing dependencies) megadose#222](megadose#222) - [update version checker to load the JSON response megadose#230](megadose#230) Update Dockerfile and README for improved installation instructions - Upgrade Python base image to 3.13.9-slim-trixie (to address crit vulnerabilities in previous image) - Simplify Dockerfile installation commands - Add Docker usage instructions to README with a note on docker-buildx requirement (for futureproofing)
1 parent e490eab commit 7a97479

File tree

2 files changed

+10
-6
lines changed

2 files changed

+10
-6
lines changed

Dockerfile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
FROM python:3.11-slim-bullseye
1+
FROM python:3.13.9-slim-trixie
22
COPY . /opt/holehe
33
WORKDIR /opt/holehe
4-
RUN pip3 install requests && \
5-
python3 setup.py install
4+
RUN pip3 install --upgrade pip && \
5+
pip3 install .

README.md

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,12 +32,16 @@ cd holehe/
3232
python3 setup.py install
3333
```
3434

35-
### With Docker
36-
35+
### With Docker (To keep things comparmentalized)
36+
*<font style="color: #f00;">Note docker-buildx required</font>*
3737
```bash
38-
docker build . -t my-holehe-image
38+
docker buildx build -t my-holehe-image .
3939
docker run my-holehe-image holehe test@gmail.com
4040
```
41+
You can then create an alias by adding the following to your .bashrc/.zshrc etc.
42+
```ini
43+
alias holehe='docker run my-holehe-image holehe'
44+
```
4145

4246
## Quick Start
4347

0 commit comments

Comments
 (0)