Fix schedule_all_controllers to skip INVALID controllers when enabling (#400)

When enabling controller services, NiFi server correctly skips INVALID
controllers (those that cannot be enabled due to validation errors).
The client was incorrectly waiting for ALL controllers to reach ENABLED
state, causing a 30-second timeout when any controller was INVALID.

Now the polling logic only waits for VALID controllers when enabling.
When disabling, all controllers are still checked since any controller
can be disabled regardless of validation status.

Adds test for mixed VALID/INVALID controller scenario.

Author: Chaffelson

nipyapi/canvas.py

@@ -2153,6 +2153,12 @@ def schedule_all_controllers(pg_id, scheduled):
     all descendant controller services automatically. Waits for all controllers
     to reach the target state before returning.
 
+    Note:
+        When enabling, INVALID controllers (those with validation errors) are
+        skipped since NiFi cannot enable them. The function waits only for
+        VALID controllers to reach ENABLED state. When disabling, all
+        controllers are included since any controller can be disabled.
+
     Args:
         pg_id (str): The UUID of the Process Group
         scheduled (bool or str): True/False for ENABLED/DISABLED, or one of
@@ -2176,7 +2182,15 @@ def _all_controllers_in_state():
         controllers = list_all_controllers(pg_id)
         if not controllers:
             return True  # No controllers to wait for
-        return all(c.component.state == target_state for c in controllers)
+        # When enabling, only wait for VALID controllers (server skips INVALID ones)
+        # When disabling, all controllers can be disabled regardless of validation
+        if target_state == "ENABLED":
+            eligible = [c for c in controllers if c.component.validation_status == "VALID"]
+        else:
+            eligible = controllers
+        if not eligible:
+            return True  # No eligible controllers to wait for
+        return all(c.component.state == target_state for c in eligible)
 
     with nipyapi.utils.rest_exceptions():
         result = nipyapi.nifi.FlowApi().activate_controller_services(

tests/test_canvas.py

@@ -920,6 +920,41 @@ def test_schedule_all_controllers(fix_pg, fix_cont):
     assert c2.component.state == 'DISABLED'
 
 
+def test_schedule_all_controllers_with_invalid(fix_pg, fix_cont):
+    """Test schedule_all_controllers skips INVALID controllers when enabling.
+
+    NiFi server correctly skips INVALID controllers (they can't be enabled).
+    The client should only wait for VALID controllers to reach ENABLED state.
+    """
+    f_pg = fix_pg.generate()
+    # Create valid controller via fixture
+    valid_ctrl = fix_cont(parent_pg=f_pg, kind='CSVReader')
+    # Create invalid controller (SSLContextService requires keystore config)
+    invalid_ctrl = fix_cont(parent_pg=f_pg, kind='StandardSSLContextService')
+
+    # Verify preconditions
+    valid_ctrl = canvas.get_controller(valid_ctrl.id, 'id')
+    invalid_ctrl = canvas.get_controller(invalid_ctrl.id, 'id')
+    assert valid_ctrl.component.validation_status == 'VALID'
+    assert invalid_ctrl.component.validation_status == 'INVALID'
+
+    # Enable all - should complete without timeout
+    result = canvas.schedule_all_controllers(f_pg.id, True)
+    assert result.state == 'ENABLED'
+
+    # Valid controller should be ENABLED, invalid stays DISABLED
+    valid_ctrl = canvas.get_controller(valid_ctrl.id, 'id')
+    invalid_ctrl = canvas.get_controller(invalid_ctrl.id, 'id')
+    assert valid_ctrl.component.state == 'ENABLED'
+    assert invalid_ctrl.component.state == 'DISABLED'
+
+    # Disable all - should also work
+    result = canvas.schedule_all_controllers(f_pg.id, False)
+    assert result.state == 'DISABLED'
+    valid_ctrl = canvas.get_controller(valid_ctrl.id, 'id')
+    assert valid_ctrl.component.state == 'DISABLED'
+
+
 def test_delete_controller(fix_pg, fix_cont):
     f_pg = fix_pg.generate()
     f_c1 = fix_cont(parent_pg=f_pg)