return on error

Author: akaladarshi

e2e/test_claim_token_api.js

@@ -1,6 +1,5 @@
 import http from 'k6/http';
 import { check, sleep } from 'k6';
-import { Rate } from 'k6/metrics';
 import {
   API_CONFIG,
   TEST_ADDRESSES,
@@ -9,15 +8,11 @@ import {
   FaucetTypes
 } from './test_claim_token_api_config.js';
 
-// Custom metrics
-const errorRate = new Rate('errors');
-
 export const options = {
   vus: 1,
   iterations: 1,
   thresholds: {
     'checks': ['rate>=1.0'],           // 100% of checks MUST pass
-    'http_req_failed': ['rate<=0.0'],  // 0% HTTP failures allowed
     'http_req_duration': ['p(95)<5000'],
   },
 };
@@ -67,24 +62,34 @@ function testInputValidation() {
   faucetTypes.forEach((faucetType) => {
     TEST_ADDRESSES.INVALID.forEach((invalidAddress, index) => {
       const response = makeClaimRequest(faucetType, invalidAddress);
-      check(response, {
-        [`${faucetType} - Invalid address "${invalidAddress}" properly rejected (400 and error)`]: (r) =>
+      const checkName = `${faucetType} - Invalid address "${invalidAddress}" properly rejected (400 and error)`;
+      const passed = check(response, {
+        [checkName]: (r) =>
           r.status === STATUS_CODES.BAD_REQUEST &&
           r.body &&
           r.body.toLowerCase().includes("invalid")
-      }) || errorRate.add(1);
+      });
+
+      if (!passed) {
+        throw new Error(`❌ ${checkName}: Expected 400 with 'invalid', got ${response.status} - ${response.body}`);
+      }
     });
   });
 
   // Test all other invalid request scenarios (missing parameters, mainnet blocking, etc.)
   TEST_SCENARIOS.INVALID_REQUESTS.forEach((testCase) => {
     const response = makeClaimRequest(testCase.faucet_info, testCase.address);
-    check(response, {
-      [`${testCase.name}: properly handled (${testCase.expectedStatus} + "${testCase.expectedErrorContains}")`]: (r) =>
+    const checkName = `${testCase.name}: properly handled (${testCase.expectedStatus} + "${testCase.expectedErrorContains}")`;
+    const passed = check(response, {
+      [checkName]: (r) =>
         r.status === testCase.expectedStatus &&
         r.body &&
         r.body.toLowerCase().includes(testCase.expectedErrorContains.toLowerCase())
-    }) || errorRate.add(1);
+    });
+
+    if (!passed) {
+      throw new Error(`❌ ${checkName}: Expected ${testCase.expectedStatus} with '${testCase.expectedErrorContains}', got ${response.status} - ${response.body}`);
+    }
   });
 
   console.log('✅ Input validation tests completed');
@@ -97,16 +102,24 @@ function testRateLimiting() {
   TEST_SCENARIOS.RATE_LIMIT_TEST_COOLDOWN_CASES.forEach(testCase => {
     const response = makeClaimRequest(testCase.faucet_info, testCase.address);
 
-    check(response, {
-      [`${testCase.name}: Expected ${testCase.expectedStatus}, got ${response.status}`]: (r) =>
-        r.status === testCase.expectedStatus,
-    }) || errorRate.add(1);
+    const statusCheckName = `${testCase.name}: Expected ${testCase.expectedStatus}, got ${response.status}`;
+    const statusPassed = check(response, {
+      [statusCheckName]: (r) => r.status === testCase.expectedStatus,
+    });
+
+    if (!statusPassed) {
+      throw new Error(`❌ ${statusCheckName}`);
+    }
 
     if (response.status === STATUS_CODES.SUCCESS) {
-      check(response, {
-        [`${testCase.name}: ✅ Valid transaction hash`]: (r) =>
-          validateTransactionHash(r.body.trim()),
-      }) || errorRate.add(1);
+      const hashCheckName = `${testCase.name}: ✅ Valid transaction hash`;
+      const hashPassed = check(response, {
+        [hashCheckName]: (r) => validateTransactionHash(r.body.trim()),
+      });
+
+      if (!hashPassed) {
+        throw new Error(`❌ ${hashCheckName}: Invalid transaction hash format: ${response.body.trim()}`);
+      }
     }
 
     // Log results for debugging
@@ -121,4 +134,5 @@ function testRateLimiting() {
 export default function () {
   testInputValidation();
   testRateLimiting();
+  console.log('\n✅ All tests passed successfully!');
 }

e2e/test_claim_token_api_config.js

@@ -1,7 +1,7 @@
 // API Test Configuration
 export const API_CONFIG = {
   // Base URL - can be overridden by API_URL environment variable
-  BASE_URL: __ENV.API_URL || 'https://forest-explorer.chainsafe.dev',
+  BASE_URL: __ENV.API_URL || 'http://127.0.0.1:8787',
   ENDPOINT: '/api/claim_token',
 
   // Test timeouts