refactor the tests to work specific faucet

Author: akaladarshi

e2e/test_claim_token_api.js

@@ -16,20 +16,26 @@ export const options = {
   vus: 1,
   iterations: 1,
   thresholds: {
+    'checks': ['rate>=1.0'],           // 100% of checks MUST pass
+    'http_req_failed': ['rate<=0.0'],  // 0% HTTP failures allowed
     'http_req_duration': ['p(95)<5000'],
   },
 };
 
-function validateTransactionHash(txHash, expectedFormat) {
-  if (expectedFormat === 'ethereum') {
-    return txHash.startsWith('0x') && txHash.length === 66;
-  } else if (expectedFormat === 'filecoin') {
-    return txHash.length >= 46 && txHash.length <= 70;
+function validateTransactionHash(txHash) {
+  // Remove outer quotes if present
+  if (txHash.startsWith('"') && txHash.endsWith('"')) {
+    txHash = txHash.slice(1, -1);
   }
-  return false;
+  // Remove inner quotes if present
+  if (txHash.startsWith('"') && txHash.endsWith('"')) {
+    txHash = txHash.slice(1, -1);
+  }
+
+  // Both CalibnetFIL and CalibnetUSDFC now return Ethereum format: 0x + 64 hex chars = 66 total
+  return txHash.startsWith('0x') && txHash.length === 66;
 }
 
-// Helper function to make API request
 function makeClaimRequest(faucetInfo, address) {
   let url = `${API_CONFIG.BASE_URL}${API_CONFIG.ENDPOINT}`;
   const params = [];
@@ -84,10 +90,9 @@ function testInputValidation() {
   console.log('✅ Input validation tests completed');
 }
 
-// Test comprehensive rate limiting scenarios
 function testRateLimiting() {
-  console.log('\n📊 Testing Rate Limiting Scenarios...');
-  console.log('📝 Testing each address format: Success → Immediate rate limit');
+  console.log('\n📊 Testing Faucet-Specific Rate Limiting...');
+  console.log('📝 Pattern: One success per faucet → All addresses for that faucet get rate limited');
 
   TEST_SCENARIOS.RATE_LIMIT_TEST_COOLDOWN_CASES.forEach(testCase => {
     const response = makeClaimRequest(testCase.faucet_info, testCase.address);
@@ -97,14 +102,14 @@ function testRateLimiting() {
         r.status === testCase.expectedStatus,
     }) || errorRate.add(1);
 
-    if (response.status === STATUS_CODES.SUCCESS && testCase.expectedTxFormat) {
+    if (response.status === STATUS_CODES.SUCCESS) {
       check(response, {
-        [`${testCase.name}: ✅ Valid ${testCase.expectedTxFormat} transaction hash`]: (r) =>
-          validateTransactionHash(r.body.trim(), testCase.expectedTxFormat),
+        [`${testCase.name}: ✅ Valid transaction hash`]: (r) =>
+          validateTransactionHash(r.body.trim()),
       }) || errorRate.add(1);
     }
 
-    // Log unexpected cases for debugging
+    // Log results for debugging
     if (response.status !== testCase.expectedStatus) {
       console.log(`❌ ${testCase.name}: Expected ${testCase.expectedStatus}, got ${response.status} - ${response.body}`);
     }

e2e/test_claim_token_api_config.js

@@ -1,7 +1,7 @@
 // API Test Configuration
 export const API_CONFIG = {
   // Base URL - can be overridden by API_URL environment variable
-  BASE_URL: __ENV.API_URL || 'http://127.0.0.1:8787',
+  BASE_URL: __ENV.API_URL || 'https://forest-explorer.chainsafe.dev',
   ENDPOINT: '/api/claim_token',
 
   // Test timeouts
@@ -10,12 +10,12 @@ export const API_CONFIG = {
 };
 
 export const TEST_ADDRESSES = {
-  F1_FORMAT_ADDRESS: 'f1pxxbe7he3c6vcw5as3gfvq33kprpmlufgtjgfdq',
-  T1_FORMAT_ADDRESS: 't1pxxbe7he3c6vcw5as3gfvq33kprpmlufgtjgfdq',
-  T410_ADDRESS: 't410fv2oexfiizeuzm3xtoie3gnxfpfwwglg4q3dgxki',
-  ETH_FORMAT_ADDRESS: '0xAe9C4b9508c929966ef37209b336E5796D632CDc',
-  T0_ADDRESS: 't0163355',
-  ETH_ID_CORRESPONDING: '0xff00000000000000000000000000000000027e1b',
+  F1_FORMAT_ADDRESS: 'f175c2l7wplwrfuhbxqate3apti4sikzyq3y26uxq',
+  T1_FORMAT_ADDRESS: 't175c2l7wplwrfuhbxqate3apti4sikzyq3y26uxq',
+  T410_ADDRESS: 't410fo4ek6rlkukhpgnatfa75wxaz3zwnzj45har6u6a',
+  ETH_FORMAT_ADDRESS: '0x7708aF456aa28EF33413283FDB5C19de6CdCA79d',
+  T0_ADDRESS: 't0174726',
+  ETH_ID_CORRESPONDING: '0xff0000000000000000000000000000000002aa86',
 
   INVALID: [
     'invalidaddress',
@@ -66,12 +66,19 @@ export const TEST_SCENARIOS = {
       expectedErrorContains: 'missing'
     },
     {
-      name: 'Missing address parameter',
+      name: 'Missing address parameter CalibnetFIL',
       faucet_info: FaucetTypes.CalibnetFIL,
       address: null,
       expectedStatus: STATUS_CODES.INTERNAL_SERVER_ERROR,
       expectedErrorContains: 'missing'
     },
+    {
+      name: 'Missing address parameter CalibnetUSDFC',
+      faucet_info: FaucetTypes.CalibnetUSDFC,
+      address: null,
+      expectedStatus: STATUS_CODES.INTERNAL_SERVER_ERROR,
+      expectedErrorContains: 'missing'
+    },
     {
       name: 'MainnetFIL request (should be blocked)',
       faucet_info: FaucetTypes.MainnetFIL,
@@ -97,97 +104,61 @@ export const TEST_SCENARIOS = {
   ],
 
   RATE_LIMIT_TEST_COOLDOWN_CASES: [
-    // CalibnetFIL with t1 address: success → rate limited
-    {
-      name: 'CalibnetFIL with t1 address',
-      faucet_info: FaucetTypes.CalibnetFIL,
-      address: TEST_ADDRESSES.T1_FORMAT_ADDRESS,
-      expectedTxFormat: 'filecoin',
-      expectedStatus: STATUS_CODES.SUCCESS
-    },
+    // === CalibnetFIL Tests: One success → All addresses rate limited ===
     {
-      name: 'CalibnetFIL with t1 address (immediate retry - rate limited)',
+      name: 'CalibnetFIL with t1 address - SUCCESS (starts 60s cooldown for CalibnetFIL)',
       faucet_info: FaucetTypes.CalibnetFIL,
       address: TEST_ADDRESSES.T1_FORMAT_ADDRESS,
-      expectedTxFormat: 'filecoin',
-      expectedStatus: STATUS_CODES.TOO_MANY_REQUESTS
-    },
-
-    // CalibnetFIL with t410 and ETH address: success → rate limited
-    {
-      name: 'CalibnetFIL with t410 address',
-      faucet_info: FaucetTypes.CalibnetFIL,
-      address: TEST_ADDRESSES.T410_ADDRESS,
-      expectedTxFormat: 'filecoin',
       expectedStatus: STATUS_CODES.SUCCESS
     },
     {
-      name: 'CalibnetFIL with t410 address (immediate retry - rate limited)',
+      name: 'CalibnetFIL with t410 address - RATE LIMITED (within CalibnetFIL cooldown)',
       faucet_info: FaucetTypes.CalibnetFIL,
       address: TEST_ADDRESSES.T410_ADDRESS,
-      expectedTxFormat: 'filecoin',
       expectedStatus: STATUS_CODES.TOO_MANY_REQUESTS
     },
     {
-      name: 'CalibnetFIL with ETH address (immediate retry after t410 - rate limited as ETH and t410 are both same address)',
+      name: 'CalibnetFIL with ETH address - RATE LIMITED (within CalibnetFIL cooldown)',
       faucet_info: FaucetTypes.CalibnetFIL,
       address: TEST_ADDRESSES.ETH_FORMAT_ADDRESS,
-      expectedTxFormat: 'filecoin',
       expectedStatus: STATUS_CODES.TOO_MANY_REQUESTS
     },
-
-    // CalibnetFIL with t0 address: success → rate limited
     {
-      name: 'CalibnetFIL with t0 address',
+      name: 'CalibnetFIL with t0 address - RATE LIMITED (within CalibnetFIL cooldown)',
       faucet_info: FaucetTypes.CalibnetFIL,
       address: TEST_ADDRESSES.T0_ADDRESS,
-      expectedTxFormat: 'filecoin',
-      expectedStatus: STATUS_CODES.SUCCESS
+      expectedStatus: STATUS_CODES.TOO_MANY_REQUESTS
     },
     {
-      name: 'CalibnetFIL with t0 address (immediate retry - rate limited)',
+      name: 'CalibnetFIL with eth ID address - RATE LIMITED (within CalibnetFIL cooldown)',
       faucet_info: FaucetTypes.CalibnetFIL,
-      address: TEST_ADDRESSES.T0_ADDRESS,
-      expectedTxFormat: 'filecoin',
+      address: TEST_ADDRESSES.ETH_ID_CORRESPONDING,
       expectedStatus: STATUS_CODES.TOO_MANY_REQUESTS
     },
 
-    // CalibnetUSDFC with eth address: success → rate limited
+    // === CalibnetUSDFC Tests: Independent cooldown from CalibnetFIL ===
     {
-      name: 'CalibnetUSDFC with eth address',
+      name: 'CalibnetUSDFC with eth address - SUCCESS (starts 60s cooldown for CalibnetUSDFC)',
       faucet_info: FaucetTypes.CalibnetUSDFC,
       address: TEST_ADDRESSES.ETH_FORMAT_ADDRESS,
-      expectedTxFormat: 'ethereum',
       expectedStatus: STATUS_CODES.SUCCESS
     },
     {
-      name: 'CalibnetUSDFC with eth address (immediate retry - rate limited)',
-      faucet_info: FaucetTypes.CalibnetUSDFC,
-      address: TEST_ADDRESSES.ETH_FORMAT_ADDRESS,
-      expectedTxFormat: 'ethereum',
-      expectedStatus: STATUS_CODES.TOO_MANY_REQUESTS
-    },
-    {
-      name: 'CalibnetUSDFC with t410 address (immediate retry after ETH - rate limited as ETH and t410 are both same address)',
+      name: 'CalibnetUSDFC with t410 address - RATE LIMITED (within CalibnetUSDFC cooldown)',
       faucet_info: FaucetTypes.CalibnetUSDFC,
       address: TEST_ADDRESSES.T410_ADDRESS,
-      expectedTxFormat: 'ethereum',
       expectedStatus: STATUS_CODES.TOO_MANY_REQUESTS
     },
-
-    // CalibnetUSDFC with eth ID address: success → rate limited
     {
-      name: 'CalibnetUSDFC with eth ID address',
+      name: 'CalibnetUSDFC with t0 address - RATE LIMITED (within CalibnetUSDFC cooldown)',
       faucet_info: FaucetTypes.CalibnetUSDFC,
-      address: TEST_ADDRESSES.ETH_ID_CORRESPONDING,
-      expectedTxFormat: 'ethereum',
-      expectedStatus: STATUS_CODES.SUCCESS
+      address: TEST_ADDRESSES.T0_ADDRESS,
+      expectedStatus: STATUS_CODES.TOO_MANY_REQUESTS
     },
     {
-      name: 'CalibnetUSDFC with eth ID address (immediate retry - rate limited)',
+      name: 'CalibnetUSDFC with eth ID address - RATE LIMITED (within CalibnetUSDFC cooldown)',
       faucet_info: FaucetTypes.CalibnetUSDFC,
       address: TEST_ADDRESSES.ETH_ID_CORRESPONDING,
-      expectedTxFormat: 'ethereum',
       expectedStatus: STATUS_CODES.TOO_MANY_REQUESTS
     }
   ]