rename metrics env to FOREST_LIBP2P_METRICS_ENABLED

Author: David Himmelstrup

docs/docs/users/reference/env_variables.md

@@ -31,7 +31,7 @@ process.
 | `FOREST_TEST_RNG_FIXED_SEED`                              | non-negative integer             | empty                                          | 0                                                             | Override RNG with a reproducible one seeded by the value. This should never be used out of test context for security. |
 | `RUST_LOG`                                                | string                           | empty                                          | `debug,forest_libp2p::service=info`                           | Allows for log level customization.                                                                                   |
 | `FOREST_IGNORE_DRAND`                                     | 1 or true                        | empty                                          | 1                                                             | Ignore Drand validation.                                                                                              |
-| `FOREST_LIBP2P_METRICS`                                   | 1 or true                        | empty                                          | 1                                                             | Include `libp2p` metrics in Forest's Prometheus output.                                                               |
+| `FOREST_LIBP2P_METRICS_ENABLED`                           | 1 or true                        | empty                                          | 1                                                             | Include `libp2p` metrics in Forest's Prometheus output.                                                               |
 | `FOREST_F3_SIDECAR_RPC_ENDPOINT`                          | string                           | 127.0.0.1:23456                                | `127.0.0.1:23456`                                             | An RPC endpoint of F3 sidecar.                                                                                        |
 | `FOREST_F3_SIDECAR_FFI_ENABLED`                           | 1 or true                        | hard-coded per chain                           | 1                                                             | Whether or not to start the F3 sidecar via FFI                                                                        |
 | `FOREST_F3_CONSENSUS_ENABLED`                             | 1 or true                        | hard-coded per chain                           | 1                                                             | Whether or not to apply the F3 consensus to the node                                                                  |

src/libp2p/service.rs

@@ -76,9 +76,8 @@ pub(in crate::libp2p) mod metrics {
     }
 }
 
-const LIBP2P_METRICS: &str = "FOREST_LIBP2P_METRICS";
-fn enable_libp2p_metrics() -> bool {
-    crate::utils::misc::env::is_env_truthy(LIBP2P_METRICS)
+fn libp2p_metrics_enabled() -> bool {
+    crate::utils::misc::env::is_env_truthy(FOREST_LIBP2P_METRICS_ENABLED)
 }
 
 /// `Gossipsub` Filecoin blocks topic identifier.
@@ -300,7 +299,7 @@ where
         let mut bitswap_outbound_request_stream =
             bitswap_request_manager.outbound_request_stream().fuse();
         let mut peer_ops_rx_stream = self.peer_manager.peer_ops_rx().stream().fuse();
-        let metrics = if enable_libp2p_metrics() {
+        let metrics = if libp2p_metrics_enabled() {
             Some(Metrics::new(&mut crate::metrics::default_registry()))
         } else {
             None