Skip to content

Commit bb5e01d

Browse files
authored
chore: derive_more in tempdb (#6494)
1 parent a23d136 commit bb5e01d

File tree

2 files changed

+12
-51
lines changed

2 files changed

+12
-51
lines changed

src/db/parity_db.rs

Lines changed: 7 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -537,14 +537,7 @@ mod test {
537537
#[test]
538538
fn subscription_tests() {
539539
let db = TempParityDB::new();
540-
assert!(
541-
db.db
542-
.as_ref()
543-
.unwrap()
544-
.write_ops_broadcast_tx
545-
.read()
546-
.is_none()
547-
);
540+
assert!(db.write_ops_broadcast_tx.read().is_none());
548541
let data = [
549542
b"h'nglui mglw'nafh".to_vec(),
550543
b"Cthulhu".to_vec(),
@@ -557,17 +550,11 @@ mod test {
557550
Cid::new_v1(IPLD_RAW, MultihashCode::Blake2b256.digest(&data[1])),
558551
];
559552

560-
let mut rx1 = db.db.as_ref().unwrap().subscribe_write_ops();
561-
let mut rx2 = db.db.as_ref().unwrap().subscribe_write_ops();
553+
let mut rx1 = db.subscribe_write_ops();
554+
let mut rx2 = db.subscribe_write_ops();
562555

563556
assert!(has_subscribers(
564-
db.db
565-
.as_ref()
566-
.unwrap()
567-
.write_ops_broadcast_tx
568-
.read()
569-
.as_ref()
570-
.unwrap()
557+
db.write_ops_broadcast_tx.read().as_ref().unwrap()
571558
));
572559

573560
for (idx, cid) in cids.iter().enumerate() {
@@ -581,24 +568,11 @@ mod test {
581568
drop(rx2);
582569

583570
assert!(!has_subscribers(
584-
db.db
585-
.as_ref()
586-
.unwrap()
587-
.write_ops_broadcast_tx
588-
.read()
589-
.as_ref()
590-
.unwrap()
571+
db.write_ops_broadcast_tx.read().as_ref().unwrap()
591572
));
592573

593-
db.db.as_ref().unwrap().unsubscribe_write_ops();
574+
db.unsubscribe_write_ops();
594575

595-
assert!(
596-
db.db
597-
.as_ref()
598-
.unwrap()
599-
.write_ops_broadcast_tx
600-
.read()
601-
.is_none()
602-
);
576+
assert!(db.write_ops_broadcast_tx.read().is_none());
603577
}
604578
}

src/db/tests/db_utils/parity.rs

Lines changed: 5 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,14 @@
11
// Copyright 2019-2026 ChainSafe Systems
22
// SPDX-License-Identifier: Apache-2.0, MIT
33

4-
use std::ops::Deref;
5-
64
use crate::db::{parity_db::ParityDb, parity_db_config::ParityDbConfig};
75

86
/// Temporary, self-cleaning ParityDB
7+
#[derive(derive_more::AsRef, derive_more::Deref)]
98
pub struct TempParityDB {
10-
pub db: Option<ParityDb>,
9+
#[deref]
10+
#[as_ref]
11+
pub db: ParityDb,
1112
_dir: tempfile::TempDir, // kept for cleaning up during Drop
1213
}
1314

@@ -22,22 +23,8 @@ impl TempParityDB {
2223
let config = ParityDbConfig::default();
2324

2425
TempParityDB {
25-
db: Some(ParityDb::open(path, &config).unwrap()),
26+
db: ParityDb::open(path, &config).unwrap(),
2627
_dir: dir,
2728
}
2829
}
2930
}
30-
31-
impl Deref for TempParityDB {
32-
type Target = ParityDb;
33-
34-
fn deref(&self) -> &Self::Target {
35-
self.db.as_ref().unwrap()
36-
}
37-
}
38-
39-
impl AsRef<ParityDb> for TempParityDB {
40-
fn as_ref(&self) -> &ParityDb {
41-
self.db.as_ref().unwrap()
42-
}
43-
}

0 commit comments

Comments
 (0)