refactor: update todos

Author: clementsirieix

examples/llamaindex_workflow.py

@@ -16,6 +16,9 @@
 class JokeEvent(Event):
     joke: str
 
+class RewriteJoke(Event): 
+    joke: str
+
 
 class JokeFlow(Workflow):
     llm = OpenAI()
@@ -29,7 +32,11 @@ async def generate_joke(self, ev: StartEvent) -> JokeEvent:
         return JokeEvent(joke=str(response))
 
     @step()
-    async def critique_joke(self, ev: JokeEvent) -> StopEvent:
+    async def return_joke(self, ev: JokeEvent) -> RewriteJoke:
+        return RewriteJoke(joke=ev.joke + "What is funny?")
+
+    @step()
+    async def critique_joke(self, ev: RewriteJoke) -> StopEvent:
         joke = ev.joke
 
         prompt = f"Give a thorough analysis and critique of the following joke: {joke}"

literalai/exporter.py

@@ -13,6 +13,8 @@
 from literalai.prompt_engineering.prompt import PromptDict
 
 
+# TODO: Suppport Gemini models https://github.com/traceloop/openllmetry/issues/2419
+# TODO: Support llamaindex workflow https://github.com/traceloop/openllmetry/pull/2421
 class LoggingSpanExporter(SpanExporter):
     def __init__(
         self,
@@ -57,8 +59,6 @@ def force_flush(self, timeout_millis: float = 30000) -> bool:
         """Force flush the exporter."""
         return True
 
-    # TODO: error check with gemini error
-    # TODO: ttFirstToken
     def _create_step_from_span(self, span: ReadableSpan) -> Step:
         """Convert a span to a Step object"""
         attributes = span.attributes or {}