Skip to content

Commit 768c693

Browse files
committed
Remove extern crate
Now we have edition 2018 we do not need to use `macro_use` or `extern crate`; `pub use` works with macros. Notable exceptions are `alloc` and `test`. Also leave the serde rename because touching it opens a can of worms.
1 parent dcb89f4 commit 768c693

File tree

1 file changed

+6
-20
lines changed

1 file changed

+6
-20
lines changed

src/lib.rs

Lines changed: 6 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -59,32 +59,18 @@ extern crate test;
5959
#[cfg(feature = "no-std")]
6060
#[macro_use]
6161
extern crate alloc;
62-
#[cfg(feature = "no-std")]
63-
extern crate core2;
6462

65-
// Re-exported dependencies.
63+
// Re-export dependencies we control.
6664
pub use bitcoin_hashes as hashes;
67-
pub extern crate bech32;
68-
pub extern crate secp256k1;
69-
70-
#[cfg(feature = "no-std")]
71-
extern crate hashbrown;
65+
pub use secp256k1;
66+
pub use bech32;
67+
#[cfg(feature="bitcoinconsensus")]
68+
pub use bitcoinconsensus;
7269

73-
#[cfg(feature = "base64")]
74-
#[cfg_attr(docsrs, doc(cfg(feature = "base64")))]
75-
pub extern crate base64;
76-
77-
#[cfg(feature = "bitcoinconsensus")]
78-
extern crate bitcoinconsensus;
7970
#[cfg(feature = "serde")]
8071
#[macro_use]
8172
extern crate actual_serde as serde;
82-
#[cfg(all(test, feature = "serde"))]
83-
extern crate bincode;
84-
#[cfg(all(test, feature = "serde"))]
85-
extern crate serde_json;
86-
#[cfg(all(test, feature = "serde"))]
87-
extern crate serde_test;
73+
8874

8975
#[cfg(test)]
9076
#[macro_use]

0 commit comments

Comments
 (0)