Merge rust-bitcoin/rust-bitcoin#936: Make TaprooBuilder::finalize able to return keyspend only

7969b7a Make TaprooBuilder::finalize able to return keyspend only (Jeremy Rubin)

Pull request description:

ACKs for top commit:
  JeremyRubin:
    > ACK 7969b7a
  sanket1729:
    ACK 7969b7a
  apoelstra:
    ACK 7969b7a

Tree-SHA512: 26d0b730590f610a858061394faafaa74b13dd353f34ccf1c6166d0cbb62937010eed5661a887f7bea4f983ac9eab8cdca10a5fe7bd74f2dd5701a7782cbac64

Author: ChallengeDev210

src/util/taproot.rs

@@ -479,20 +479,21 @@ impl TaprootBuilder {
     }
 
     /// Creates a [`TaprootSpendInfo`] with the given internal key.
+    ///
+    // TODO: in a future breaking API change, this no longer needs to return result
     pub fn finalize<C: secp256k1::Verification>(
         mut self,
         secp: &Secp256k1<C>,
         internal_key: UntweakedPublicKey,
     ) -> Result<TaprootSpendInfo, TaprootBuilderError> {
-        if self.branch.len() > 1 {
-            return Err(TaprootBuilderError::IncompleteTree);
+        match self.branch.pop() {
+            None => Ok(TaprootSpendInfo::new_key_spend(secp, internal_key, None)),
+            Some(Some(node)) => {
+                Ok(TaprootSpendInfo::from_node_info(secp, internal_key, node))
+            }
+            _ => Err(TaprootBuilderError::IncompleteTree),
+
         }
-        let node = self
-            .branch
-            .pop()
-            .ok_or(TaprootBuilderError::EmptyTree)?
-            .expect("Builder invariant: last element of the branch must be some");
-        Ok(TaprootSpendInfo::from_node_info(secp, internal_key, node))
     }
 
     pub(crate) fn branch(&self) -> &[Option<NodeInfo>] {