Merge rust-bitcoin/rust-bitcoin#1122: Add docs re Rust 1.51.1

apoelstra · apoelstra · commit a36dad7726a8 · 2022-07-25T13:41:33.000Z
7f498ee Add docs re Rust 1.51.1 (Tobin C. Harding) Pull request description: After auditing the code base for 'msrv' the only remaining mention (excl. md files) is on `unsigned_abs`. Add docs to save the next guy looking up what version of Rust introduced `unsigned_abs`. (I also added an item to the [msrv tracking issue](rust-bitcoin/rust-bitcoin#1060).) ACKs for top commit: Kixunil: ACK 7f498ee apoelstra: ACK 7f498ee Tree-SHA512: 9b4bdca09d3f7ac1c0584f4eb5207983a064cfe81ed26952d00396b2e0019ef40eee192b7f09d36c68b8c4e1f8de9cac2d1f3ee0946626bae089b46fe38704ab
diff --git a/src/util/amount.rs b/src/util/amount.rs
@@ -336,7 +336,7 @@ fn dec_width(mut num: u64) -> usize {
     width
 }
 
-// NIH due to MSRV, impl copied from `core`
+// NIH due to MSRV, impl copied from `core::i8::unsigned_abs` (introduced in Rust 1.51.1).
 fn unsigned_abs(x: i8) -> u8 {
     x.wrapping_abs() as u8
 }

Original file line number	Diff line number	Diff line change
`@@ -336,7 +336,7 @@ fn dec_width(mut num: u64) -> usize {`
`336`	`336`	`width`
`337`	`337`	`}`
`338`	`338`
`339`		-// NIH due to MSRV, impl copied from `core`
	`339`	+// NIH due to MSRV, impl copied from `core::i8::unsigned_abs` (introduced in Rust 1.51.1).
`340`	`340`	`fn unsigned_abs(x: i8) -> u8 {`
`341`	`341`	`x.wrapping_abs() as u8`
`342`	`342`	`}`