Skip to content

Commit aed84ce

Browse files
committed
Merge rust-bitcoin/rust-bitcoin#795: Add new maintainers
9407d10 Be uniform in heading spacing (Tobin Harding) af9389d Add Kixunil, RCassata, and tcharding to maintainers (Tobin Harding) Pull request description: We recently added `CONTRIBUTING.md` but forgot to add @Kixunil . Also a couple days ago I was added to the repo. Patch two is trivial cleanup of whitespace. ACKs for top commit: sanket1729: utACK 9407d10. Did not verify emails :) Kixunil: ACK 9407d10 RCasatta: ACK 9407d10 elichai: ACK 9407d10 apoelstra: ACK 9407d10 Tree-SHA512: 032e847972a418a425f91364b8850a398f814406dc109f216cc783feefc7db9504e75c2f7f2d4b4d42b2bb44e7d4ef8c5641a7741389ce7ab2f9063d12afcc88
2 parents 7b58512 + 1bafe49 commit aed84ce

File tree

1 file changed

+11
-0
lines changed

1 file changed

+11
-0
lines changed

CONTRIBUTING.md

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ implementation and other Rust Bitcoin-related projects, which are hosted in the
88
mostly guidelines, not rules. Use your best judgment, and feel free to propose
99
changes to this document in a pull request.
1010

11+
1112
#### Table Of Contents
1213

1314
- [General](#general)
@@ -97,6 +98,7 @@ comment suggesting that you're working on it. If someone is already assigned,
9798
don't hesitate to ask if the assigned party or previous commenters are still
9899
working on it if it has been awhile.
99100

101+
100102
## Preparing PRs
101103

102104
The main library development happens in the `master` branch. This branch must
@@ -136,6 +138,7 @@ NB: Please keep in mind that the script above replaces `Cargo.lock` file, which
136138
is necessary to support current MSRV, incompatible with `stable` and newer cargo
137139
versions.
138140

141+
139142
### Peer review
140143

141144
Anyone may participate in peer review which is expressed by comments in the pull
@@ -144,6 +147,7 @@ test out the patch set and opine on the technical merits of the patch. Please,
144147
first review PR on the conceptual level before focusing on code style or
145148
grammar fixes.
146149

150+
147151
### Repository maintainers
148152

149153
Pull request merge requirements:
@@ -160,12 +164,16 @@ Current list of the project maintainers:
160164
- [Elichai Turkel](https://github.com/elichai)
161165
- [Sebastian Geisler](https://github.com/sgeisler)
162166
- [Sanket Kanjalkar](https://github.com/sanket1729)
167+
- [Martin Habovštiak](https://github.com/Kixunil)
168+
- [Riccardo Casatta](https://github.com/RCasatta)
169+
- [Tobin Harding](https://github.com/tcharding)
163170

164171

165172
## Coding conventions
166173

167174
Library reflects Bitcoin Core approach whenever possible.
168175

176+
169177
### Formatting
170178

171179
The repository currently does not use `rustfmt`.
@@ -181,12 +189,14 @@ and [how it is planned to coordinate it with crate refactoring](https://github.c
181189
For the new code it is recommended to follow style of the existing codebase and
182190
avoid any end-line space characters.
183191

192+
184193
### MSRV
185194

186195
The Minimal Supported Rust Version (MSRV) is 1.29; it is enforced by our CI.
187196
Later we plan to increase MSRV to support Rust 2018 and you are welcome to check
188197
the [tracking issue](https://github.com/rust-bitcoin/rust-bitcoin/issues/510).
189198

199+
190200
### Naming conventions
191201

192202
Naming of data structures/enums and their fields/variants must follow names used
@@ -195,6 +205,7 @@ in Bitcoin Core, with the following exceptions:
195205
snake_case for fields and variants);
196206
- omit `C`-prefixes.
197207

208+
198209
### Unsafe code
199210

200211
Use of `unsafe` code is prohibited unless there is a unanimous decision among

0 commit comments

Comments
 (0)