Skip to content

Commit b2c48d0

Browse files
committed
Add ci check for duplicate dependencies
Add a call to `cargo tree --duplicates` in the ci script to ensure that we do not have any duplicated dependencies. Kudos to Martin for the idea.
1 parent 9ee7b33 commit b2c48d0

File tree

1 file changed

+9
-0
lines changed

1 file changed

+9
-0
lines changed

contrib/test.sh

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,15 @@ if cargo --version | grep nightly; then
2222
NIGHTLY=true
2323
fi
2424

25+
# We should not have any duplicate dependencies. This catches mistakes made upgrading dependencies
26+
# in one crate and not in another (e.g. upgrade bitcoin_hashes in bitcoin but not in secp).
27+
duplicate_dependencies=$(cargo tree --target=all --all-features --duplicates | wc -l)
28+
if [ "$duplicate_dependencies" -ne 0 ]; then
29+
echo "Dependency tree is broken, contains duplicates"
30+
cargo tree --target=all --all-features --duplicates
31+
exit 1
32+
fi
33+
2534
echo "********* Testing std *************"
2635
# Test without any features other than std first
2736
cargo test --verbose --no-default-features --features="std"

0 commit comments

Comments
 (0)