Skip to content

Commit ff8010a

Browse files
committed
CA-4834 Merges feature/First-Name-Last-Name into develop
2 parents e0b7abe + 8e73360 commit ff8010a

File tree

6 files changed

+1054
-1081
lines changed

6 files changed

+1054
-1081
lines changed

src/main/java/com/shopify/model/ShopifyAddressUpdateRequest.java

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ public class ShopifyAddressUpdateRequest {
1919
private String firstName;
2020
@XmlElement(name = "last_name")
2121
private String lastname;
22-
private String name;
2322
private String company;
2423
private String address1;
2524
private String address2;
@@ -51,14 +50,6 @@ public void setLastname(final String lastname) {
5150
this.lastname = lastname;
5251
}
5352

54-
public String getName() {
55-
return name;
56-
}
57-
58-
public void setName(final String name) {
59-
this.name = name;
60-
}
61-
6253
public String getCompany() {
6354
return company;
6455
}

src/main/java/com/shopify/model/ShopifyOrderShippingAddressUpdateRequest.java

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -31,12 +31,8 @@ public static interface CompanyStep {
3131
LatitudeStep withCompany(final String company);
3232
}
3333

34-
public static interface NameStep {
35-
CompanyStep withName(final String name);
36-
}
37-
3834
public static interface LastNameStep {
39-
NameStep withLastName(final String lastName);
35+
CompanyStep withLastName(final String lastName);
4036
}
4137

4238
public static interface FirstNameStep {
@@ -93,7 +89,7 @@ private ShopifyOrderShippingAddressUpdateRequest(final Steps steps) {
9389
}
9490

9591
private static class Steps implements IdStep, Address1Step, Address2Step, CityStep, ProvinceStep, ProvinceCodeStep,
96-
ZipCodeStep, CountryStep, CountryCodeStep, PhoneStep, LatitudeStep, CompanyStep, LongitudeStep, NameStep,
92+
ZipCodeStep, CountryStep, CountryCodeStep, PhoneStep, LatitudeStep, CompanyStep, LongitudeStep,
9793
LastNameStep, FirstNameStep, BuildStep {
9894
private String id;
9995
private final ShopifyAddressUpdateRequest shippingAddress = new ShopifyAddressUpdateRequest();
@@ -110,7 +106,7 @@ public LastNameStep withFirstName(final String firstName) {
110106
}
111107

112108
@Override
113-
public NameStep withLastName(final String lastName) {
109+
public CompanyStep withLastName(final String lastName) {
114110
this.shippingAddress.setLastname(lastName);
115111
return this;
116112
}
@@ -181,12 +177,6 @@ public Address1Step withId(final String id) {
181177
return this;
182178
}
183179

184-
@Override
185-
public CompanyStep withName(final String name) {
186-
this.shippingAddress.setName(name);
187-
return this;
188-
}
189-
190180
@Override
191181
public ProvinceCodeStep withProvince(final String province) {
192182
this.shippingAddress.setProvince(province);

src/test/java/com/shopify/ShopifySdkDriver.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -563,8 +563,7 @@ public void givenSomeValuesWhenUpdatingAnOrderThenExpectValuesToBeUpdatedOnOrder
563563
.newBuilder().withId("1124214472765").withAddress1("Testing From SDK Driver2").withAddress2("Suite 100")
564564
.withCity("Scranton").withProvince("Pennsylvania").withProvinceCode("PA").withZip("18503")
565565
.withCountry("United States").withCountryCode("US").withPhone("9829374293874").withFirstName("Ryan")
566-
.withLastName("Kazokas").withName("Ryan Kazokas").withCompany("ChannelApe").withLatitude(null)
567-
.withLongitude(null).build();
566+
.withLastName("Kazokas").withCompany("ChannelApe").withLatitude(null).withLongitude(null).build();
568567

569568
final ShopifyOrder updateOrder = shopifySdk.updateOrderShippingAddress(shopifyOrderUpdateRequest);
570569
assertEquals("Testing From SDK Driver2", updateOrder.getShippingAddress().getAddress1());

src/test/java/com/shopify/ShopifySdkTest.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1932,7 +1932,7 @@ public void givenSomeValidAccessTokenAndSubdomainAndValidRequestWhenUpdatingOrde
19321932
.newBuilder().withId(someShopifyOrderId).withAddress1("224 Wyoming Ave").withAddress2("Suite 100")
19331933
.withCity("Scranton").withProvince("PEnnsylvania").withProvinceCode("PA").withZip("18503")
19341934
.withCountry("USA").withCountryCode("US").withPhone("123").withFirstName("Ryan").withLastName("Kazokas")
1935-
.withName("Ryan Kazokas").withCompany("ChannelApe").withLatitude(new BigDecimal(410.44444))
1935+
.withCompany("ChannelApe").withLatitude(new BigDecimal(410.44444))
19361936
.withLongitude(new BigDecimal(123.442)).build();
19371937

19381938
final String expectedResponseBodyString = getJsonString(ShopifyOrderRoot.class, shopifyOrderRoot);
@@ -1959,8 +1959,7 @@ public void givenSomeValidAccessTokenAndSubdomainAndValidRequestWhenUpdatingOrde
19591959
actualRequestBody.getContent().get("order").get("shipping_address").get("first_name").asText());
19601960
assertEquals("Kazokas",
19611961
actualRequestBody.getContent().get("order").get("shipping_address").get("last_name").asText());
1962-
assertEquals("Ryan Kazokas",
1963-
actualRequestBody.getContent().get("order").get("shipping_address").get("name").asText());
1962+
19641963
assertEquals("USA",
19651964
actualRequestBody.getContent().get("order").get("shipping_address").get("country").asText());
19661965
assertEquals("US",

src/test/java/com/shopify/model/ShopifyAddressUpdateRequestTest.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ public class ShopifyAddressUpdateRequestTest {
1313
private static final String SOME_PHONE = "3874928734234";
1414
private static final BigDecimal SOME_LONGITUDE = new BigDecimal(485.8323);
1515
private static final BigDecimal SOME_LATITUDE = new BigDecimal(41.489);
16-
private static final String SOME_NAME = "Ryan Kazokas";
1716
private static final String SOME_LAST_NAME = "Kazokas";
1817
private static final String SOME_FIRST_NAME = "Ryan";
1918
private static final String SOME_COUNTRY_CODE = "US";
@@ -35,7 +34,6 @@ public void givenSomeValuesWhenBuildingShopifyAddressUpdateRequestThenExpectCorr
3534
shopifyAddressUpdateRequest.setCountryCode(SOME_COUNTRY_CODE);
3635
shopifyAddressUpdateRequest.setFirstName(SOME_FIRST_NAME);
3736
shopifyAddressUpdateRequest.setLastname(SOME_LAST_NAME);
38-
shopifyAddressUpdateRequest.setName(SOME_NAME);
3937
shopifyAddressUpdateRequest.setLatitude(SOME_LATITUDE);
4038
shopifyAddressUpdateRequest.setLongitude(SOME_LONGITUDE);
4139
shopifyAddressUpdateRequest.setPhone(SOME_PHONE);

0 commit comments

Comments
 (0)