Skip to content

Commit 89b989e

Browse files
committed
Rename integration test docker and compose files
1 parent 9c7f76f commit 89b989e

File tree

5 files changed

+9
-11
lines changed

5 files changed

+9
-11
lines changed

src/test/java/org/phoebus/channelfinder/docker/ITUtil.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ public class ITUtil {
7575
public static final ObjectMapper MAPPER = new ObjectMapper();
7676

7777
public static final String CHANNELFINDER = "channelfinder";
78-
public static final String INTEGRATIONTEST_DOCKER_COMPOSE = "src/test/resources/docker-compose-integrationtest.yml";
78+
public static final String INTEGRATIONTEST_DOCKER_COMPOSE = "src/test/resources/compose.yml";
7979

8080
// code coverage
8181

File renamed without changes.

src/test/resources/INTEGRATIONTEST_DOCKER_RUN.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,12 +73,12 @@ mvn clean install test-compile failsafe:integration-test failsafe:verify --batch
7373
##### Build
7474

7575
* (Re) Build after change in `src/main/java` in order for change to be tested
76-
* `Dockerfile.integrationtest` relies on built code and not on Maven central
76+
* `Dockerfile` relies on built code and not on Maven central
7777
* Requires a deployable jar
7878

7979
##### Configuration
8080

81-
* Configuration in folder `src/test/java` and package `org.phoebus.channelfinder.docker`, e.g. urls and port numbers, is coupled to files `src/test/resources/Dockerfile.integrationtest` and `src/test/resources/docker-compose-integrationtest.yml` (beside `src/main/resources/application.properties`)
81+
* Configuration in folder `src/test/java` and package `org.phoebus.channelfinder.docker`, e.g. urls and port numbers, is coupled to files `src/test/resources/Dockerfile` and `src/test/resources/compose.yml` (beside `src/main/resources/application.properties`)
8282

8383
##### Debug
8484

src/test/resources/INTEGRATIONTEST_DOCKER_TUTORIAL.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,8 @@ It is possible to test ChannelFinder API by running ChannelFinder and Elasticsea
3333
##### Files
3434

3535
* folder `src/test/java` and package `org.phoebus.channelfinder.docker`
36-
* [docker-compose-integrationtest.yml](src/test/resources/docker-compose-integrationtest.yml)
37-
* [Dockerfile.integrationtest](src/test/resources/Dockerfile.integrationtest)
36+
* [compose.yml](src/test/resources/compose.yml)
37+
* [Dockerfile](src/test/resources/Dockerfile)
3838

3939
### Examples
4040

@@ -87,7 +87,7 @@ How
8787

8888
### How it works - big picture
8989

90-
Integration tests are implemented in test class annotated with `@Testcontainers`. Test class starts a docker container for the application (ChannelFinder service) and another docker container for elastic (Elasticsearch) through `src/test/resources/docker-compose-integrationtest.yml` and `src/test/resources/Dockerfile.integrationtest` after which JUnit tests are run.
90+
Integration tests are implemented in test class annotated with `@Testcontainers`. Test class starts a docker container for the application (ChannelFinder service) and another docker container for elastic (Elasticsearch) through `src/test/resources/compose.yml` and `src/test/resources/Dockerfile` after which JUnit tests are run.
9191

9292
```
9393
@Testcontainers
@@ -320,8 +320,8 @@ public class ChannelFinderChannelsIT {
320320

321321
##### Note
322322

323-
* (Re) Build after change in `src/main/java` is needed in order for change to be tested as `Dockerfile.integrationtest` relies on built code.
324-
* Configuration in folder `src/test/java` and package `org.phoebus.channelfinder.docker`, e.g. urls and port numbers, is coupled to files `src/test/resources/Dockerfile.integrationtest` and `src/test/resources/docker-compose-integrationtest.yml` (beside `src/main/resources/application.properties`).
323+
* (Re) Build after change in `src/main/java` is needed in order for change to be tested as `Dockerfile` relies on built code.
324+
* Configuration in folder `src/test/java` and package `org.phoebus.channelfinder.docker`, e.g. urls and port numbers, is coupled to files `src/test/resources/Dockerfile` and `src/test/resources/compose.yml` (beside `src/main/resources/application.properties`).
325325
* Both positive and negative tests are important to ensure validation works as expected.
326326

327327
### How to run

src/test/resources/docker-compose-integrationtest.yml renamed to src/test/resources/compose.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,7 @@
1818

1919
services:
2020
channelfinder:
21-
build:
22-
context: .
23-
dockerfile: Dockerfile.integrationtest
21+
build: .
2422
hostname: channelfinder
2523
networks:
2624
- channelfinder-net

0 commit comments

Comments
 (0)