Test removing an alias

Author: jacomago

client/demoApp/Db/Makefile

@@ -14,6 +14,7 @@ DB += somerecords.db
 DB += test_base.db
 DB += test_remove_infotag.db
 DB += test_remove_channel.db
+DB += test_remove_alias.db
 #----------------------------------------------------
 # If <anyname>.db template is not named <anyname>*.template add
 # <anyname>_template = <templatename>

client/demoApp/Db/test_base.db

@@ -15,3 +15,7 @@ record(longout, "$(P)lo:base_pv2") {
   info("hello", "world")
   info("archive", "default")
 }
+
+record(longout, "$(P)lo:base_pv3") {
+  alias("$(P)lo:base_pv3:alias")
+}

client/demoApp/Db/test_remove_alias.db

@@ -0,0 +1,20 @@
+
+record(ai, "$(P)ai:base_pv") {
+  info("test", "testing")
+  info("archive", "MONITOR@1")
+}
+
+record(longout, "$(P)lo:base_pv") {
+  info("test", "testing")
+  info("hello", "world")
+  info("archive", "default")
+}
+
+record(longout, "$(P)lo:base_pv2") {
+  info("test", "testing")
+  info("hello", "world")
+  info("archive", "default")
+}
+
+record(longout, "$(P)lo:base_pv3") {
+}

client/iocBoot/iocdemo/st_remove_alias.cmd

@@ -0,0 +1,31 @@
+#!../../bin/linux-x86_64-debug/demo
+
+## You may have to change demo to something else
+## everywhere it appears in this file
+
+< envPaths
+
+## Register all support components
+dbLoadDatabase("../../dbd/demo.dbd",0,0)
+demo_registerRecordDeviceDriver(pdbbase)
+
+var(reccastTimeout, 5.0)
+var(reccastMaxHoldoff, 5.0)
+
+epicsEnvSet("IOCNAME", "$(IOCSH_NAME)")
+epicsEnvSet("ENGINEER", "myself")
+epicsEnvSet("LOCATION", "myplace")
+
+epicsEnvSet("CONTACT", "mycontact")
+epicsEnvSet("BUILDING", "mybuilding")
+epicsEnvSet("SECTOR", "mysector")
+
+addReccasterEnvVars("CONTACT", "SECTOR")
+addReccasterEnvVars("BUILDING")
+
+## Load record instances
+dbLoadRecords("../../db/reccaster.db", "P=$(IOCSH_NAME):")
+dbLoadRecords("../../db/somerecords.db","P=$(IOCSH_NAME):")
+dbLoadRecords("../../db/test_remove_alias.db", "P=$(IOCSH_NAME):")
+
+iocInit()

server/tests/client_checks.py

@@ -12,8 +12,8 @@
 MAX_WAIT_SECONDS = 180
 TIME_PERIOD_INCREMENT = 2
 
-# (2 reccaster.db, 2 somerecords.db, 2 aliases in somerecords.db, 3 in test_base.db)
-BASE_IOC_CHANNEL_COUNT = 2 + (2 + 2) + 3
+# (2 reccaster.db, 2 somerecords.db, 2 aliases in somerecords.db, 4 and 1 alias in test_base.db)
+BASE_IOC_CHANNEL_COUNT = 2 + (2 + 2) + (4 + 1)
 
 
 def channel_match(channel0, channel1, properties_to_match: list[str]):

server/tests/test_bash_ioc.py

@@ -25,7 +25,7 @@
     encoding="utf-8",
 )
 
-BASE_CHANNEL_COUNT = 9
+BASE_CHANNEL_COUNT = 11  # one alias
 setup_compose = ComposeFixtureFactory(Path("docker") / Path("test-bash-ioc.yml")).return_fixture()
 
 
@@ -126,3 +126,28 @@ def test_remove_channel(self, setup_compose: DockerCompose) -> None:  # noqa: F8
         # Assert
         check_channel_property(cf_client, name=base_channel_name)
         check_channel_property(cf_client, name=base_channel_test_name, prop=INACTIVE_PROPERTY)
+
+
+class TestRemoveAlias:
+    def test_remove_alias(self, setup_compose: DockerCompose) -> None:  # noqa: F811
+        """
+        Test that removing an alias works correctly.
+        """
+        # Arrange
+        docker_ioc = start_ioc(setup_compose)
+        LOG.info("Waiting for channels to sync")
+        cf_client = create_client_and_wait(setup_compose, expected_channel_count=BASE_CHANNEL_COUNT)
+
+        # Check before alias status
+        LOG.debug('Checking ioc1-1 has ai:base_pv3 has an Active alias"')
+        base_channel_name = "IOC1-1:ai:base_pv3:has_alias"
+        check_channel_property(cf_client, name=base_channel_name)
+        base_channel_alias_name = "IOC1-1:ai:base_pv3:alias"
+        check_channel_property(cf_client, name=base_channel_alias_name)
+
+        # Act
+        restart_ioc(docker_ioc, cf_client, base_channel_name, "st_remove_alias")
+
+        # Assert
+        check_channel_property(cf_client, name=base_channel_name)
+        check_channel_property(cf_client, name=base_channel_alias_name, prop=INACTIVE_PROPERTY)