Node order control?

[robpridham]

I have a long workflow that saves images at each step. The save nodes have a dependency on a filename-generating node.

What I hoped to get:

• each 'save' node executes as soon as its inputs can be fulfilled - especially because they're not showing up in Comfy, this allows the outputs to be inspected mid-process

What actually happens:

• all the 'save' nodes execute together at the end

This is probably arbitrary - when they didn't have the filename dependency, this behaved as I hoped.

Can I do anything to change or influence the execution order? In the web UI I believe this would be defined by node number.

[Chaoses-Ib]

From what I can see, ComfyUI will execute the nodes according to their order in the prompt dict.

As for ComfyScript, the order of nodes in the prompt depends on the order they were called:

So if call save nodes first, they should appear first and then be executed first, if my guess is right.

Can you show the order of nodes in your workflow with the following code?

with Workflow(queue=False) as wf:
    ...
print(wf.api_format().keys())

[robpridham]

dict_keys(['Seed (rgthree).0'
, 'Seed (rgthree).1'
, 'CheckpointLoaderSimple.0'
, 'CLIPSetLastLayer.0'
, 'ImpactWildcardEncode.0'
, 'ImpactWildcardEncode.1'
, 'ImpactWildcardEncode.2'
, 'ImpactWildcardEncode.3'
, 'ImpactWildcardEncode.4'
, 'ImpactWildcardEncode.5'
, 'ImpactWildcardEncode.6'
, 'ConditioningConcat.0'
, 'ImpactWildcardEncode.7'
, 'ConditioningConcat.1'
, 'ConditioningConcat.2'
, 'ConditioningConcat.3'
, 'ConditioningConcat.4'
, 'ConditioningConcat.5'
, 'ConditioningConcat.6'
, 'ConditioningConcat.7'
, 'CLIPTextEncode.0'
, 'Seed (rgthree).2'
, 'Seed (rgthree).3'
, 'Seed (rgthree).4'
, 'EmptyLatentImage.0'
, 'LatentRotate.0'
, 'KSamplerAdvanced.0'
, 'KSamplerAdvanced.1'
, 'KSamplerAdvanced.2'
, 'KSamplerAdvanced.3'
, 'VAEDecode.0'
, 'PreviewImage.0'
, 'Get Date Time String (JPS).0'
, 'Text Concatenate.0'
, 'Text Concatenate.1'
, 'SaveImage.0'
, 'Text Concatenate.2'
, 'Seed (rgthree).5'
, 'UpscaleModelLoader.0'
, 'DenoiseScheduleHookProvider.0'
, 'CfgScheduleHookProvider.0'
, 'PixelKSampleHookCombine.0'
, 'PixelKSampleUpscalerProvider.0'
, 'IterativeImageUpscale.0'
, 'SaveImage.1'
, 'Text Concatenate.3'
, 'Seed (rgthree).6'
, 'UltralyticsDetectorProvider.0'
, 'SAMLoader.0'
, 'FaceDetailer.0'
, 'SaveImage.2'
, 'Text Concatenate.4'
, 'Seed (rgthree).7'
, 'UltralyticsDetectorProvider.1'
, 'FaceDetailer.1'
, 'SaveImage.3'])

It's Get Date Time String (JPS).0' that provides a component part of the filename, then put through a few Text Concatenate nodes.

This order is good, with early SaveImage declared before the later processing stages. but the actual execution is all the SaveImage nodes at the end, so I think this is a ComfyUI problem/limitation rather than a ComfyScript one.

I can avoid it - maybe only by chance - by moving some responsibility out of nodes and into Python code. I guess maybe one of your modes - like 'wait' or using 'real' mode - might get me closer to my goal if I needed this?

[Chaoses-Ib]

Could you test the workflow again with the following code put at the start?

import comfy_script.runtime.data as data
c = 0
def my_assign_id(self, obj: object) -> str:
    import builtins

    global c
    c += 1
    id = str(c)
    
    self._objid_id_map[builtins.id(obj)] = id
    self._id_obj_map[id] = obj
    return id
data.IdManager.assign_id = my_assign_id

from comfy_script.runtime import *
load()
from comfy_script.runtime.nodes import *

with Workflow():
    ...

This will change the id assignment to increasing integers, just like the web UI would do:

If changing this can fix the issue, it's just id assignment problem and should be easy to workaround. Otherwise it may be a little hard.

[Chaoses-Ib]

I guess maybe one of your modes - like 'wait' or using 'real' mode - might get me closer to my goal if I needed this?

Using real mode should give you full control of the execution order, at the cost of losing the node output cache and automatically model management.

I'm planning to add another mode that provides most benefits of both virtual and real mode (#29), though it may be a long way to go as it will make things more complex and I'm not sure if it's worthy.

[robpridham]

Could you test the workflow again with the following code put at the start?

Interesting! This didn't change the order, but it did restore the green 'active node' highlight in ComfyUI and the progress indicators in Iterative Upscaler, which was all previously missing from any script-generated workflows.