Skip to content

Commit 2b095f2

Browse files
committed
Removed magic numbers.
1 parent 61a5e42 commit 2b095f2

File tree

1 file changed

+16
-14
lines changed

1 file changed

+16
-14
lines changed

ocpp-v1_6/src/test/java/eu/chargetime/ocpp/feature/profile/test/ClientCoreProfileTest.java

Lines changed: 16 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,8 @@ of this software and associated documentation files (the "Software"), to deal
4545
*/
4646
public class ClientCoreProfileTest
4747
{
48+
private static final int SESSION_ZERO = 0;
49+
4850
private ClientCoreProfile core;
4951

5052
@Mock
@@ -232,7 +234,7 @@ public void handleRequest_aChangeAvailabilityRequest_callsHandleChangeAvailabili
232234
ChangeAvailabilityRequest request = new ChangeAvailabilityRequest();
233235

234236
// When
235-
core.handleRequest(0, request);
237+
core.handleRequest(SESSION_ZERO, request);
236238

237239
// Then
238240
verify(handler, times(1)).handleChangeAvailabilityRequest(eq(request));
@@ -244,7 +246,7 @@ public void handleRequest_aRemoteStartTransactionRequest_callsHandleRemoteStartT
244246
RemoteStartTransactionRequest request = new RemoteStartTransactionRequest();
245247

246248
// When
247-
core.handleRequest(0, request);
249+
core.handleRequest(SESSION_ZERO, request);
248250

249251
// Then
250252
verify(handler, times(1)).handleRemoteStartTransactionRequest(eq(request));
@@ -256,7 +258,7 @@ public void handleRequest_aRemoteStopTransactionRequest_callsHandleRemoteStopTra
256258
RemoteStopTransactionRequest request = new RemoteStopTransactionRequest();
257259

258260
// When
259-
core.handleRequest(0, request);
261+
core.handleRequest(SESSION_ZERO, request);
260262

261263
// Then
262264
verify(handler, times(1)).handleRemoteStopTransactionRequest(eq(request));
@@ -268,7 +270,7 @@ public void handleRequest_aResetRequest_callsHandleResetRequest() {
268270
ResetRequest request = new ResetRequest();
269271

270272
// When
271-
core.handleRequest(0, request);
273+
core.handleRequest(SESSION_ZERO, request);
272274

273275
// Then
274276
verify(handler, times(1)).handleResetRequest(eq(request));
@@ -280,7 +282,7 @@ public void handleRequest_anUnlockConnectorRequest_callsHandleUnlockConnectorReq
280282
UnlockConnectorRequest request = new UnlockConnectorRequest();
281283

282284
// When
283-
core.handleRequest(0, request);
285+
core.handleRequest(SESSION_ZERO, request);
284286

285287
// Then
286288
verify(handler, times(1)).handleUnlockConnectorRequest(eq(request));
@@ -293,7 +295,7 @@ public void handleRequest_aChangeAvailabilityRequest_returnsChangeAvailabilityCo
293295
ChangeAvailabilityRequest request = new ChangeAvailabilityRequest();
294296

295297
// When
296-
Confirmation conf = core.handleRequest(0, request);
298+
Confirmation conf = core.handleRequest(SESSION_ZERO, request);
297299

298300
// Then
299301
assertThat(conf, instanceOf(ChangeAvailabilityConfirmation.class));
@@ -315,7 +317,7 @@ public void handleRequest_aGetConfigurationRequest_callsHandleGetConfigurationRe
315317
GetConfigurationRequest request = new GetConfigurationRequest();
316318

317319
// When
318-
core.handleRequest(0, request);
320+
core.handleRequest(SESSION_ZERO, request);
319321

320322
// Then
321323
verify(handler, times(1)).handleGetConfigurationRequest(eq(request));
@@ -328,7 +330,7 @@ public void handleRequest_aGetConfigurationRequest_returnGetConfigurationConfirm
328330
GetConfigurationRequest request = new GetConfigurationRequest();
329331

330332
// When
331-
Confirmation conf = core.handleRequest(0, request);
333+
Confirmation conf = core.handleRequest(SESSION_ZERO, request);
332334

333335
// Then
334336
assertThat(conf, instanceOf(GetConfigurationConfirmation.class));
@@ -340,7 +342,7 @@ public void handleRequest_aDataTransferRequest_callsHandleDataTransferRequest()
340342
DataTransferRequest request = new DataTransferRequest();
341343

342344
// When
343-
core.handleRequest(0, request);
345+
core.handleRequest(SESSION_ZERO, request);
344346

345347
// Then
346348
verify(handler, times(1)).handleDataTransferRequest(eq(request));
@@ -353,7 +355,7 @@ public void handleRequest_aDataTransferRequest_returnDataTransferConfirmation()
353355
DataTransferRequest request = new DataTransferRequest();
354356

355357
// When
356-
Confirmation conf = core.handleRequest(0, request);
358+
Confirmation conf = core.handleRequest(SESSION_ZERO, request);
357359

358360
// Then
359361
assertThat(conf, instanceOf(DataTransferConfirmation.class));
@@ -374,7 +376,7 @@ public void handleRequest_aChangeConfigurationRequest_callsHandleChangeConfigura
374376
ChangeConfigurationRequest request = new ChangeConfigurationRequest();
375377

376378
// When
377-
core.handleRequest(0, request);
379+
core.handleRequest(SESSION_ZERO, request);
378380

379381
// Then
380382
verify(handler, times(1)).handleChangeConfigurationRequest(eq(request));
@@ -387,7 +389,7 @@ public void handleRequest_aChangeConfigurationRequest_returnsChangeConfiguration
387389
ChangeConfigurationRequest request = new ChangeConfigurationRequest();
388390

389391
// When
390-
Confirmation conf = core.handleRequest(0, request);
392+
Confirmation conf = core.handleRequest(SESSION_ZERO, request);
391393

392394
// Then
393395
assertThat(conf, instanceOf(ChangeConfigurationConfirmation.class));
@@ -408,7 +410,7 @@ public void handleRequest_aClearCacheRequest_callsHandleClearCacheRequest() {
408410
ClearCacheRequest request = new ClearCacheRequest();
409411

410412
// When
411-
core.handleRequest(0, request);
413+
core.handleRequest(SESSION_ZERO, request);
412414

413415
// Then
414416
verify(handler, times(1)).handleClearCacheRequest(request);
@@ -421,7 +423,7 @@ public void handleRequest_aClearCacheRequest_returnsClearCacheConfirmation() {
421423
ClearCacheRequest request = new ClearCacheRequest();
422424

423425
// When
424-
Confirmation conf = core.handleRequest(0, request);
426+
Confirmation conf = core.handleRequest(SESSION_ZERO, request);
425427

426428
// Then
427429
assertThat(conf, instanceOf(ClearCacheConfirmation.class));

0 commit comments

Comments
 (0)