For story TG-1: Implemented Server Stop Transaction feature.

Author: TVolden

ocpp-v1_6-test/src/main/java/eu/chargetime/ocpp/test/FakeCentralSystem.java

@@ -121,6 +121,13 @@ public StatusNotificationConfirmation handleStatusNotificationRequest(int sessio
                 StatusNotificationConfirmation confirmation = new StatusNotificationConfirmation();
                 return confirmation;
             }
+
+            @Override
+            public StopTransactionConfirmation handleStopTransactionRequest(int sessionIndex, StopTransactionRequest request) {
+                receivedRequest = request;
+                StopTransactionConfirmation confirmation = new StopTransactionConfirmation();
+                return confirmation;
+            }
         }));
         server.open("localhost", 8887, new ServerEvents() {
             @Override
@@ -271,4 +278,8 @@ public boolean hasHandledStartTransactionRequest() {
     public boolean hasHandledStatusNotificationRequest() {
         return receivedRequest instanceof StatusNotificationRequest;
     }
+
+    public boolean hasHandledStopTransactionRequest() {
+        return receivedRequest instanceof StopTransactionRequest;
+    }
 }

…me/ocpp/test/core/StopTransaction.groovy …cpp/test/core/StopTransactionSpec.groovyocpp-v1_6-test/src/test/groovy/eu/chargetime/ocpp/test/core/StopTransaction.groovy renamed to ocpp-v1_6-test/src/test/groovy/eu/chargetime/ocpp/test/core/StopTransactionSpec.groovy ocpp-v1_6-test/src/test/groovy/eu/chargetime/ocpp/test/core/StopTransaction.groovy renamed to ocpp-v1_6-test/src/test/groovy/eu/chargetime/ocpp/test/core/StopTransactionSpec.groovy

@@ -1,14 +1,14 @@
 package eu.chargetime.ocpp.test.core
 
+import eu.chargetime.ocpp.test.FakeCentralSystem
 import eu.chargetime.ocpp.test.FakeChargePoint
-import eu.chargetime.ocpp.test.OldFakeCentralSystem
 import spock.lang.Shared
 import spock.lang.Specification
 import spock.util.concurrent.PollingConditions
 
-class StopTransaction extends Specification {
+class StopTransactionSpec extends Specification {
     @Shared
-    OldFakeCentralSystem centralSystem = OldFakeCentralSystem.getInstance();
+    FakeCentralSystem centralSystem = FakeCentralSystem.getInstance();
     @Shared
     FakeChargePoint chargePoint = new FakeChargePoint();
 
@@ -32,12 +32,9 @@ class StopTransaction extends Specification {
 
         then:
         conditions.eventually {
-            assert centralSystem.hasReceivedStopTransactionRequest();
+            assert centralSystem.hasHandledStopTransactionRequest();
         }
 
-        when:
-        centralSystem.sendStopTransactionConfirmation();
-
         then:
         conditions.eventually {
             assert chargePoint.hasReceivedStopTransactionConfirmation();

ocpp-v1_6/src/main/java/eu/chargetime/ocpp/feature/profile/ServerCoreEventHandler.java

@@ -33,6 +33,7 @@ public interface ServerCoreEventHandler {
     HeartbeatConfirmation handleHeartbeatRequest(int sessionIndex, HeartbeatRequest request);
     MeterValuesConfirmation handleMeterValuesRequest(int sessionIndex, MeterValuesRequest request);
     StartTransactionConfirmation handleStartTransactionRequest(int sessionIndex, StartTransactionRequest request);
-
     StatusNotificationConfirmation handleStatusNotificationRequest(int sessionIndex, StatusNotificationRequest request);
+
+    StopTransactionConfirmation handleStopTransactionRequest(int sessionIndex, StopTransactionRequest request);
 }

ocpp-v1_6/src/main/java/eu/chargetime/ocpp/feature/profile/ServerCoreProfile.java

@@ -54,6 +54,7 @@ public ServerCoreProfile(ServerCoreEventHandler handler) {
         features.add(new ResetFeature(this));
         features.add(new StartTransactionFeature(this));
         features.add(new StatusNotificationFeature(this));
+        features.add(new StopTransactionFeature(this));
     }
 
     @Override
@@ -79,6 +80,8 @@ public Confirmation handleRequest(int sessionIndex, Request request) {
             result = handler.handleStartTransactionRequest(sessionIndex, (StartTransactionRequest) request);
         } else if (request instanceof StatusNotificationRequest) {
             result = handler.handleStatusNotificationRequest(sessionIndex, (StatusNotificationRequest) request);
+        } else if (request instanceof StopTransactionRequest) {
+            result = handler.handleStopTransactionRequest(sessionIndex, (StopTransactionRequest) request);
         }
 
         return result;

ocpp-v1_6/src/test/java/eu/chargetime/ocpp/feature/profile/test/ServerCoreProfileTest.java

@@ -268,6 +268,28 @@ public void handleRequest_aStatusNotificationRequest_callsHandleStatusNotificati
         verify(handler, times(1)).handleStatusNotificationRequest(eq(sessionId), eq(request));
     }
 
+    @Test
+    public void getFeatureList_containsStopTransactionFeature() {
+        // When
+        Feature[] features = core.getFeatureList();
+
+        // Then
+        assertThat(findFeature(features, "StopTransaction"), is(instanceOf(StopTransactionFeature.class)));
+    }
+
+    @Test
+    public void handleRequest_aStopTransactionRequest_callsHandleStopTransactionRequest() {
+        // Given
+        StopTransactionRequest request = new StopTransactionRequest();
+        int sessionId = 42;
+
+        // When
+        core.handleRequest(sessionId, request);
+
+        // Then
+        verify(handler, times(1)).handleStopTransactionRequest(eq(sessionId), eq(request));
+    }
+
     private Feature findFeature(Feature[] features, String action) {
         Feature output = null;
         for (Feature feature : features) {