Add tests for maximum length strings

Author: Mathias Oben

ocpp-v1_6/src/test/java/eu/chargetime/ocpp/model/securityext/test/CertificateSignedRequestTest.java

@@ -56,6 +56,17 @@ public void constructor_nullCertificateChain_throwsPropertyConstraintException()
     // Then throws
   }
 
+  @Test
+  public void setCertificateChain_maximumLengthString_nothingThrown() {
+    // Given
+    String certificateChain = TestUtilities.aString(10000);
+
+    // When
+    new CertificateSignedRequest(certificateChain);
+
+    // Then nothing thrown
+  }
+
   @Test(expected = PropertyConstraintException.class)
   public void setCertificateChain_exceedingLengthString_throwsPropertyConstraintException() {
     // Given

ocpp-v1_6/src/test/java/eu/chargetime/ocpp/model/securityext/test/GetLogConfirmationTest.java

@@ -28,6 +28,7 @@ of this software and associated documentation files (the "Software"), to deal
 
 import eu.chargetime.ocpp.PropertyConstraintException;
 import eu.chargetime.ocpp.model.securityext.GetLogConfirmation;
+import eu.chargetime.ocpp.model.securityext.types.CertificateHashDataType;
 import eu.chargetime.ocpp.model.securityext.types.LogStatusEnumType;
 import eu.chargetime.ocpp.utilities.TestUtilities;
 import org.junit.Test;
@@ -92,6 +93,18 @@ public void validate_setRequiredAndOptional_returnsTrue() {
     assertTrue(actual);
   }
 
+  @Test
+  public void setFilename_maximumLengthString_nothingThrown() {
+    // Given
+    String filename = TestUtilities.aString(255);
+    GetLogConfirmation confirmation = new GetLogConfirmation(null);
+
+    // When
+    confirmation.setFilename(filename);
+
+    // Then nothing thrown
+  }
+
   @Test(expected = PropertyConstraintException.class)
   public void setFilename_exceedingLengthString_throwsPropertyConstraintException() {
     // Given

ocpp-v1_6/src/test/java/eu/chargetime/ocpp/model/securityext/test/InstallCertificateRequestTest.java

@@ -61,14 +61,24 @@ public void constructor_nullCertificate_throwsPropertyConstraintException() {
     // Then throws
   }
 
+  @Test
+  public void setCertificate_maximumLengthString_nothingThrown() {
+    // Given
+    String certificate = TestUtilities.aString(5500);
+
+    // When
+    new InstallCertificateRequest(null, certificate);
+
+    // Then nothing thrown
+  }
+
   @Test(expected = PropertyConstraintException.class)
   public void setCertificate_exceedingLengthString_throwsPropertyConstraintException() {
     // Given
     String certificate = TestUtilities.aString(5501);
-    InstallCertificateRequest request = new InstallCertificateRequest(null, null);
 
     // When
-    request.setCertificate(certificate);
+    new InstallCertificateRequest(null, certificate);
 
     // Then throws
   }

ocpp-v1_6/src/test/java/eu/chargetime/ocpp/model/securityext/test/SecurityEventNotificationRequestTest.java

@@ -76,6 +76,18 @@ public void validate_returnFalse() {
     assertFalse(actual);
   }
 
+  @Test
+  public void setType_maximumLengthString_nothingThrown() {
+    // Given
+    String type = TestUtilities.aString(50);
+    ZonedDateTime timestamp = ZonedDateTime.now();
+
+    // When
+    new SecurityEventNotificationRequest(type, timestamp);
+
+    // Then nothing thrown
+  }
+
   @Test(expected = PropertyConstraintException.class)
   public void setType_exceedingLengthString_throwsPropertyConstraintException() {
     // Given
@@ -88,6 +100,20 @@ public void setType_exceedingLengthString_throwsPropertyConstraintException() {
     // Then throws
   }
 
+  @Test
+  public void setTechInfo_maximumLengthString_nothingThrown() {
+    // Given
+    String type = givenType();
+    ZonedDateTime timestamp = ZonedDateTime.now();
+    String techInfo = TestUtilities.aString(255);
+    SecurityEventNotificationRequest request = new SecurityEventNotificationRequest(type, timestamp);
+
+    // When
+    request.setTechInfo(techInfo);
+
+    // Then nothing thrown
+  }
+
   @Test(expected = PropertyConstraintException.class)
   public void setTechInfo_exceedingLengthString_throwsPropertyConstraintException() {
     // Given

ocpp-v1_6/src/test/java/eu/chargetime/ocpp/model/securityext/test/SignCertificateRequestTest.java

@@ -56,6 +56,17 @@ public void constructor_nullCsr_throwsPropertyConstraintException() {
     // Then throws
   }
 
+  @Test
+  public void setType_maximumLengthString_nothingThrown() {
+    // Given
+    String csr = TestUtilities.aString(5500);
+
+    // When
+    new SignCertificateRequest(csr);
+
+    // Then nothing thrown
+  }
+
   @Test(expected = PropertyConstraintException.class)
   public void setCsr_exceedingLengthString_throwsPropertyConstraintException() {
     // Given

ocpp-v1_6/src/test/java/eu/chargetime/ocpp/model/securityext/test/types/CertificateHashDataTypeTest.java

@@ -94,6 +94,18 @@ public void setIssuerKeyHash_nonIdentifierString_throwsPropertyConstraintExcepti
     // Then throws
   }
 
+  @Test
+  public void setSerialNumber_maximumLengthString_nothingThrown() {
+    // Given
+    String serialNumber = TestUtilities.aString(40);
+    CertificateHashDataType dataType = new CertificateHashDataType();
+
+    // When
+    dataType.setSerialNumber(serialNumber);
+
+    // Then nothing thrown
+  }
+
   @Test(expected = PropertyConstraintException.class)
   public void setSerialNumber_exceedingLengthString_throwsPropertyConstraintException() {
     // Given

ocpp-v1_6/src/test/java/eu/chargetime/ocpp/model/securityext/test/types/FirmwareTypeTest.java

@@ -71,6 +71,18 @@ public void validate_setRequired_returnsTrue() {
     assertTrue(actual);
   }
 
+  @Test
+  public void setLocation_maximumLengthString_nothingThrown() {
+    // Given
+    String location = TestUtilities.aString(512);
+    FirmwareType type = new FirmwareType();
+
+    // When
+    type.setLocation(location);
+
+    // Then nothing thrown
+  }
+
   @Test(expected = PropertyConstraintException.class)
   public void setLocation_exceedingLengthString_throwsPropertyConstraintException() {
     // Given
@@ -83,6 +95,18 @@ public void setLocation_exceedingLengthString_throwsPropertyConstraintException(
     // Then throws
   }
 
+  @Test
+  public void setSigningCertificate_maximumLengthString_nothingThrown() {
+    // Given
+    String signingCertificate = TestUtilities.aString(5500);
+    FirmwareType type = new FirmwareType();
+
+    // When
+    type.setSigningCertificate(signingCertificate);
+
+    // Then nothing thrown
+  }
+
   @Test(expected = PropertyConstraintException.class)
   public void setSigningCertificate_exceedingLengthString_throwsPropertyConstraintException() {
     // Given
@@ -95,6 +119,18 @@ public void setSigningCertificate_exceedingLengthString_throwsPropertyConstraint
     // Then throws
   }
 
+  @Test
+  public void setSignature_maximumLengthString_nothingThrown() {
+    // Given
+    String signature = TestUtilities.aString(800);
+    FirmwareType type = new FirmwareType();
+
+    // When
+    type.setSignature(signature);
+
+    // Then nothing thrown
+  }
+
   @Test(expected = PropertyConstraintException.class)
   public void setSignature_exceedingLengthString_throwsPropertyConstraintException() {
     // Given
@@ -108,11 +144,11 @@ public void setSignature_exceedingLengthString_throwsPropertyConstraintException
   }
 
   private String givenSigningCertificate() {
-    return "an-identifier-string";
+    return "PEM encoded X.509 certificate";
   }
 
   private String givenSignature() {
-    return "PEM encoded X.509 certificate";
+    return "Base64 encoded firmware signature";
   }
 
   private String givenLocation() {

ocpp-v1_6/src/test/java/eu/chargetime/ocpp/model/securityext/test/types/LogParametersTypeTest.java

@@ -84,6 +84,18 @@ public void validate_setRequiredAndOptional_returnsTrue() {
     assertTrue(actual);
   }
 
+  @Test
+  public void setLocation_maximumLengthString_nothingThrown() {
+    // Given
+    String location = TestUtilities.aString(512);
+    LogParametersType type = new LogParametersType();
+
+    // When
+    type.setRemoteLocation(location);
+
+    // Then nothing thrown
+  }
+
   @Test(expected = PropertyConstraintException.class)
   public void setLocation_exceedingLengthString_throwsPropertyConstraintException() {
     // Given