Skip to content

Commit f4c10a9

Browse files
committed
Cleanup state after future has completed - adjust tests for Java 8
1 parent 92aabc5 commit f4c10a9

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

ocpp-common/src/test/java/eu/chargetime/ocpp/test/ClientTest.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@ of this software and associated documentation files (the "Software"), to deal
4141
import java.util.UUID;
4242
import java.util.concurrent.CompletableFuture;
4343
import java.util.concurrent.ExecutionException;
44-
import java.util.concurrent.TimeUnit;
4544
import java.util.concurrent.TimeoutException;
4645

4746
import static org.hamcrest.CoreMatchers.*;
@@ -222,11 +221,11 @@ public void send_aMessage_promiseCompletesWithTimeout() throws Exception {
222221
// When
223222
CompletableFuture<Confirmation> returnedFuture = client.send(request);
224223
// If the client uses at least Java 9, it could use CompletableFuture::orTimeout(..) ..
225-
returnedFuture.orTimeout(50, TimeUnit.MILLISECONDS);
224+
// returnedFuture.orTimeout(50, TimeUnit.MILLISECONDS);
226225
assertThat(returnedFuture.isDone(), is(false));
227226
Thread.sleep(100);
228227
// .. alternatively, it can be implemented manually
229-
// returnedFuture.completeExceptionally(new TimeoutException());
228+
returnedFuture.completeExceptionally(new TimeoutException());
230229

231230
// Then
232231
assertThat(returnedFuture, is(internalFuture));

ocpp-common/src/test/java/eu/chargetime/ocpp/test/ServerTest.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
import java.util.UUID;
1717
import java.util.concurrent.CompletableFuture;
1818
import java.util.concurrent.ExecutionException;
19-
import java.util.concurrent.TimeUnit;
2019
import java.util.concurrent.TimeoutException;
2120

2221
import static org.hamcrest.CoreMatchers.equalTo;
@@ -211,11 +210,11 @@ public void send_aMessage_promiseCompletesWithTimeout() throws Exception {
211210
// When
212211
CompletableFuture<Confirmation> returnedFuture = server.send(sessionIndex, request);
213212
// If the client uses at least Java 9, it could use CompletableFuture::orTimeout(..).
214-
returnedFuture.orTimeout(50, TimeUnit.MILLISECONDS);
213+
// returnedFuture.orTimeout(50, TimeUnit.MILLISECONDS);
215214
assertThat(returnedFuture.isDone(), is(false));
216215
Thread.sleep(100);
217216
// .. alternatively, it can be implemented manually
218-
// returnedFuture.completeExceptionally(new TimeoutException());
217+
returnedFuture.completeExceptionally(new TimeoutException());
219218

220219
// Then
221220
assertThat(returnedFuture, is(internalFuture));

0 commit comments

Comments
 (0)