feat: implement date handling and room message retrieval enhancements

* Added a new function `_handle_room_search_dates` to manage date parsing for room-based searches, allowing for optional date filtering.
* Introduced `_run_date_range` to execute workflows over specified date ranges, improving the handling of date-based searches.
* Refactored the `main` function to streamline date handling logic and integrate new date management functions.
* Enhanced logging for better traceability during room-specific message retrieval processes.
* Updated the `run_app` function to utilize new helper functions for improved clarity and maintainability.

Author: aitestino

summarizer/cli.py

@@ -73,23 +73,23 @@ def _validate_room_parameters(
     person_name: str | None,
 ) -> str | None:
     """Validate room-specific parameters and return the search mode.
-    
+
     Returns:
         Search mode: 'room_id', 'room_name', 'person_name', or None if no room params.
-        
+
     Raises:
         typer.Exit on validation error.
     """
     room_params = [room_id, room_name, person_name]
     active_params = [p for p in room_params if p is not None]
-    
+
     if len(active_params) > 1:
         typer.echo(
             "[red]Cannot use multiple room identification options simultaneously. "
             "Please choose only one of --room-id, --room-name, or --person-name.[/red]"
         )
         raise typer.Exit(1)
-    
+
     if room_id:
         return "room_id"
     elif room_name:
@@ -137,6 +137,81 @@ def _validate_and_parse_dates(
     return parsed_date, None, None, "single"
 
 
+def _handle_room_search_dates(
+    room_search_mode: str | None,
+    target_date: str | None,
+    start_date: str | None,
+    end_date: str | None,
+) -> tuple[datetime | None, datetime | None, datetime | None, str | None]:
+    """Handle date parsing for room-based searches.
+
+    Returns:
+        (parsed_target_date, parsed_start_date, parsed_end_date, date_mode)
+    """
+    if room_search_mode:
+        # Room-based search - dates are optional for filtering
+        if target_date or start_date or end_date:
+            return _validate_and_parse_dates(target_date, start_date, end_date)
+        else:
+            # No date filtering - retrieve all messages from room
+            return None, None, None, None
+    else:
+        # Traditional date-based search - validate dates
+        parsed_target_date, parsed_start_date, parsed_end_date, date_mode = (
+            _validate_and_parse_dates(target_date, start_date, end_date)
+        )
+
+        # If no explicit date provided, prompt for one
+        if date_mode == "single" and target_date is None:
+            parsed_target_date = _handle_single_date(None)
+            date_mode = "single"
+        elif parsed_target_date is None and parsed_start_date is None:
+            typer.echo(
+                "[red]Please specify either date-based options (--target-date, "
+                "--start-date/--end-date) or room-based options (--room-id, "
+                "--room-name, --person-name).[/red]"
+            )
+            raise typer.Exit(1)
+
+        return parsed_target_date, parsed_start_date, parsed_end_date, date_mode
+
+
+def _run_date_range(
+    parsed_start_date: datetime,
+    parsed_end_date: datetime,
+    webex_token: str,
+    user_email: str,
+    context_window_minutes: int,
+    passive_participation: bool,
+    time_display_format: str,
+    room_chunk_size: int,
+    max_messages: int,
+    room_search_mode: str | None,
+    room_search_value: str | None,
+) -> None:
+    """Execute date range workflow."""
+    current = parsed_start_date
+    while current <= parsed_end_date:
+        config = AppConfig(
+            webex_token=webex_token,
+            user_email=user_email,
+            target_date=current,
+            context_window_minutes=context_window_minutes,
+            passive_participation=passive_participation,
+            time_display_format=time_display_format,
+            room_chunk_size=room_chunk_size,
+            max_messages=max_messages,
+        )
+        _run_for_date(
+            config,
+            date_header=True,
+            room_search_mode=room_search_mode,
+            room_search_value=room_search_value,
+            apply_date_filter=True,
+        )
+        current += timedelta(days=1)
+
+
 def _run_for_date(
     config: AppConfig,
     date_header: bool,
@@ -146,15 +221,25 @@ def _run_for_date(
 ) -> None:
     logger.info("Attempting to log into Webex API as user %s", config.user_email)
     if room_search_mode:
-        logger.info("Room search mode: %s with value: %s", room_search_mode, room_search_value)
+        logger.info(
+            "Room search mode: %s with value: %s",
+            room_search_mode,
+            room_search_value,
+        )
         logger.info("Max messages to retrieve: %d", config.max_messages)
     else:
         logger.info("Targeted date for summarization: %s", config.target_date)
     logger.info("Context window size: %d minutes", config.context_window_minutes)
     logger.info("Passive participation: %s", config.passive_participation)
     logger.info("Time display format: %s", config.time_display_format)
     logger.info("Room fetch chunk size: %d", config.room_chunk_size)
-    run_app(config, date_header=date_header, room_search_mode=room_search_mode, room_search_value=room_search_value, apply_date_filter=apply_date_filter)
+    run_app(
+        config,
+        date_header=date_header,
+        room_search_mode=room_search_mode,
+        room_search_value=room_search_value,
+        apply_date_filter=apply_date_filter,
+    )
 
 
 @app.command()
@@ -231,9 +316,7 @@ def main(
     ] = None,
     person_name: Annotated[
         str | None,
-        typer.Option(
-            help="Person name to find DM room with (exact match)"
-        ),
+        typer.Option(help="Person name to find DM room with (exact match)"),
     ] = None,
     max_messages: Annotated[
         int, typer.Option(help="Maximum number of messages to retrieve from room")
@@ -244,68 +327,41 @@ def main(
         logger.setLevel(logging.DEBUG)
         logger.debug("Debug logging enabled")
 
-    # Validate room parameters
+    # Validate room parameters and get search mode
     room_search_mode = _validate_room_parameters(room_id, room_name, person_name)
-    
+    room_search_value = room_id or room_name or person_name
+
     # Handle date parameters based on whether room search is specified
-    if room_search_mode:
-        # Room-based search - dates are optional for filtering
-        if target_date or start_date or end_date:
-            parsed_target_date, parsed_start_date, parsed_end_date, date_mode = (
-                _validate_and_parse_dates(target_date, start_date, end_date)
-            )
-        else:
-            # No date filtering - retrieve all messages from room
-            parsed_target_date, parsed_start_date, parsed_end_date, date_mode = None, None, None, None
-    else:
-        # Traditional date-based search - validate dates
-        parsed_target_date, parsed_start_date, parsed_end_date, date_mode = (
-            _validate_and_parse_dates(target_date, start_date, end_date)
-        )
-        
-        # If no explicit date provided, prompt for one
-        if date_mode == "single" and target_date is None:
-            parsed_target_date = _handle_single_date(None)
-            date_mode = "single"
-        elif parsed_target_date is None and parsed_start_date is None:
-            typer.echo(
-                "[red]Please specify either date-based options (--target-date, "
-                "--start-date/--end-date) or room-based options (--room-id, "
-                "--room-name, --person-name).[/red]"
-            )
-            raise typer.Exit(1)
+    parsed_target_date, parsed_start_date, parsed_end_date, date_mode = (
+        _handle_room_search_dates(room_search_mode, target_date, start_date, end_date)
+    )
 
-    # Get room search value for room-based searches
-    room_search_value = room_id or room_name or person_name
-    
+    # Handle date range mode
     if date_mode == "range":
-        # Iterate over date range (inclusive)
-        current = parsed_start_date
-        if current is None or parsed_end_date is None:
+        if parsed_start_date is None or parsed_end_date is None:
             raise ValueError(
                 "Both start_date and end_date must be provided for range mode"
             )
-        while current <= parsed_end_date:
-            config = AppConfig(
-                webex_token=webex_token,
-                user_email=user_email,
-                target_date=current,
-                context_window_minutes=context_window_minutes,
-                passive_participation=passive_participation,
-                time_display_format=time_display_format.value,
-                room_chunk_size=room_chunk_size,
-                max_messages=max_messages,
-            )
-            _run_for_date(config, date_header=True, room_search_mode=room_search_mode, room_search_value=room_search_value, apply_date_filter=True)
-            current += timedelta(days=1)
+        _run_date_range(
+            parsed_start_date,
+            parsed_end_date,
+            webex_token,
+            user_email,
+            context_window_minutes,
+            passive_participation,
+            time_display_format.value,
+            room_chunk_size,
+            max_messages,
+            room_search_mode,
+            room_search_value,
+        )
         return
 
     # Single date mode or room-only mode
     if parsed_target_date is None and not room_search_mode:
-        # Traditional date-based mode requires a date
         raise ValueError("Target date must be provided for single date mode")
-    
-    # Construct AppConfig
+
+    # Construct AppConfig and run
     config = AppConfig(
         webex_token=webex_token,
         user_email=user_email,
@@ -316,11 +372,17 @@ def main(
         room_chunk_size=room_chunk_size,
         max_messages=max_messages,
     )
+
     # Determine if we should apply date filtering
-    # Only skip date filtering for room-only searches (room specified but no date params)
     should_apply_date_filter = not (room_search_mode and parsed_target_date is None)
-    
-    _run_for_date(config, date_header=False, room_search_mode=room_search_mode, room_search_value=room_search_value, apply_date_filter=should_apply_date_filter)
+
+    _run_for_date(
+        config,
+        date_header=False,
+        room_search_mode=room_search_mode,
+        room_search_value=room_search_value,
+        apply_date_filter=should_apply_date_filter,
+    )
 
 
 if __name__ == "__main__":