From 5f9286c3fd79fa2a9366106570d67e6508460af6 Mon Sep 17 00:00:00 2001 From: Peter Dave Hello Date: Sat, 7 Jun 2025 06:38:50 -0700 Subject: [PATCH 1/3] fix: avoid crash when readability parser returns null --- src/utils/get-core-content-text.mjs | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/utils/get-core-content-text.mjs b/src/utils/get-core-content-text.mjs index 54c004cb..3309e9b4 100644 --- a/src/utils/get-core-content-text.mjs +++ b/src/utils/get-core-content-text.mjs @@ -71,11 +71,13 @@ export function getCoreContentText() { } if (isProbablyReaderable(document)) { - let article = new Readability(document.cloneNode(true), { + const article = new Readability(document.cloneNode(true), { keepClasses: true, }).parse() - console.log('readerable') - return postProcessText(article.textContent) + if (article?.textContent) { + console.log('readerable') + return postProcessText(article.textContent) + } } const largestElement = findLargestElement(document.body) From a29ca8d2edcb92031252119c7d3522b223a160ad Mon Sep 17 00:00:00 2001 From: Peter Dave Hello Date: Sun, 8 Jun 2025 03:02:27 +0800 Subject: [PATCH 2/3] Update src/utils/get-core-content-text.mjs --- src/utils/get-core-content-text.mjs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/utils/get-core-content-text.mjs b/src/utils/get-core-content-text.mjs index 3309e9b4..d93cbc52 100644 --- a/src/utils/get-core-content-text.mjs +++ b/src/utils/get-core-content-text.mjs @@ -71,7 +71,7 @@ export function getCoreContentText() { } if (isProbablyReaderable(document)) { - const article = new Readability(document.cloneNode(true), { + let article = new Readability(document.cloneNode(true), { keepClasses: true, }).parse() if (article?.textContent) { From 5179a19e0289a480cea2aee451e22816194e99a3 Mon Sep 17 00:00:00 2001 From: Peter Dave Hello Date: Sun, 8 Jun 2025 17:21:05 +0800 Subject: [PATCH 3/3] Update src/utils/get-core-content-text.mjs --- src/utils/get-core-content-text.mjs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/utils/get-core-content-text.mjs b/src/utils/get-core-content-text.mjs index d93cbc52..119836c9 100644 --- a/src/utils/get-core-content-text.mjs +++ b/src/utils/get-core-content-text.mjs @@ -75,8 +75,10 @@ export function getCoreContentText() { keepClasses: true, }).parse() if (article?.textContent) { - console.log('readerable') + console.log('readerable: successfully extracted content') return postProcessText(article.textContent) + } else { + console.log('readerable: parsing failed despite probability check') } }