Fixes

- Allow 16:9 `primarybackground`s
- Require a primary background in PRs (not yet forced for existing servers)
- Remove the `secondarybackground` requirement in PRs
- Increase the char limit of descriptions to 50
- Fixed `Electron Network`'s game types
- Fixed `Scala Network`'s logo
- Fixed `Scala Network`'s primarybackground
- Renamed `ViperMC`'s primarybackground
- Fixed `ElevateMC`'s primarybackground

Author: ShonP40

.github/pull_request_template.md

@@ -11,7 +11,7 @@
 * You can view our patterns here: [metadata.schema.json](https://github.com/CheatBreakerNet/Client-API/blob/master/mappings/metadata.schema.json), or take a look below and complete the field checklist:
   - [ ] `id`: a lowercase string, which should match the folder name *(ex. `goldenpvpnetwork`)*
   - [ ] `name`: a string *(ex. `GoldenPvP Network`)*
-  - [ ] `description`: hook between 16 and 40 characters *(ex. `We're the home of classic PvP gamemodes`)* 
+  - [ ] `description`: between 16 and 50 characters *(ex. `We're the home of classic PvP gamemodes`)* 
   - [ ] `addresses`: an array with lowercase strings *(ex. `["goldenpvp.net", "routing.center"]`)*
     - You do not need to specify subdomains, CheatBreaker services automatically detect them.
   - [ ] `primaryAddress`: the primary address that people connect to with (please include the subdomain if required) *(ex. `mc.goldenpvp.net`)*
@@ -58,16 +58,9 @@
 * [ ] My logo is between `512` and `1024` pixels in width and height.
 * [ ] My logo is my own/the server's property and complies with relevant copyright/privacy laws.
 
-#### Primary Background (Only required for partnered servers)
-* [ ] My primary background is a `png` file.
-* [ ] I have uploaded my primary background to my server folder *(ex. `goldenpvpnetwork`)* and named it `primarybackground.png`.
-* [ ] My primary background is `774` pixels in width and `363` pixels in height.
-* [ ] My primary background contains relevant content pertaining to the server, is my own/the server's property, and complies with relevant copyright/privacy laws.
-* [ ] My primary background doesn't contain any markings, text, or logos (unless part of a build).
-
-#### Secondary Background (Only required for partnered servers)
-* [ ] My secondary background is a `png` file.
-* [ ] I have uploaded my secondary background to my server folder *(ex. `goldenpvpnetwork`)* and named it `secondarybackground.png`.
-* [ ] My secondary background is `447` pixels in width and `172` pixels in height.
-* [ ] My secondary background contains relevant content pertaining to the server, is my own/the server's property, and complies with relevant copyright/privacy laws.
-* [ ] My secondary background doesn't contain any markings, text, or logos (unless part of a build).
+#### Background
+* [ ] My background is a `png` file.
+* [ ] I have uploaded my background to my server folder *(ex. `goldenpvpnetwork`)* and named it `primarybackground.png`.
+* [ ] My background has an aspect ratio of `16:9`.
+* [ ] My background contains relevant content pertaining to the server, is my own/the server's property, and complies with relevant copyright/privacy laws.
+* [ ] My background doesn't contain any markings, text, or logos (unless part of a build).

mappings/metadata.schema.json

@@ -20,7 +20,7 @@
         "description": {
             "type": "string",
             "minLength": 16,
-            "maxLength": 40
+            "maxLength": 50
         },
         "server_brand": {
             "type": "string",

mappings/scripts/utils.py

@@ -154,7 +154,7 @@ def validate_discord_logo(path, server_name) -> list:
 '''
 Validate that server primary background meets the following requirements:
   * is a PNG
-  * is 774x363
+  * is 774x363 or 16:9
 '''
 def validate_primary_background(path, server_name) -> list:
     # Check image exits - silently skip if not (as it is not yet a requirement)
@@ -170,10 +170,12 @@ def validate_primary_background(path, server_name) -> list:
         errors.append(
             f'{server_name}\'s server primary background is not a PNG (currently {primary_background_image.format})... Please ensure the image meets the requirements before proceeding.')
 
-    # Check image dimensions are 774x363
-    if primary_background_image.width != 774 or primary_background_image.height != 363:
-        errors.append(
-            f'{server_name}\'s server primary background resolution is not 774x363... Please ensure the image meets the requirements before proceeding.')
+    aspect_ratio = primary_background_image.width / primary_background_image.height
+    # Check image dimensions are 774x363 or if the aspect ratio is 16:9
+    if (abs(aspect_ratio - (16 / 9)) > 0.01):
+        if (primary_background_image.width != 774 or primary_background_image.height != 363):
+            errors.append(
+                f'{server_name}\'s server primary background resolution is not 774x363 or 16:9... Please ensure the image meets the requirements before proceeding.')
 
     return errors
 

mappings/servers/electronnetwork/metadata.json

@@ -1,7 +1,7 @@
 {
     "id": "electronnetwork",
     "name": "Electron Network",
-    "description": "A unique PVP server with HCF, PVP and minigames.",
+    "description": "A unique PVP server with HCF, PVP and minigames",
     "addresses": [
         "electronmc.club"
     ],
@@ -23,7 +23,7 @@
     ],
     "gameTypes": [
         "HCF",
-        "PVP",
+        "PvP",
         "Minigames"
     ],
     "website": "https://www.electronmc.club/",