Simplify declaration of categoryScore

cx-diogo-rocha · cx-diogo-rocha · commit 4887d6d8bec2 · 2025-12-12T16:36:02.000Z
diff --git a/engine/score/score.go b/engine/score/score.go
@@ -105,10 +105,9 @@ func getValidityScore(baseRiskScore float64, validationStatus secrets.Validation
 }
 
 func GetBaseRiskScore(category ruledefine.RuleCategory, ruleType uint8) float64 {
-	var categoryScore uint8
-	var ok bool
+	categoryScore, ok := CategoryScoreMap[category]
 	// default to the lowest score if category not found, should only happen on custom rules with undefined category
-	if categoryScore, ok = CategoryScoreMap[category]; !ok {
+	if !ok {
 		categoryScore = 1
 	}
 	return float64(categoryScore)*0.6 + float64(ruleType)*0.4

Original file line number	Diff line number	Diff line change
`@@ -105,10 +105,9 @@ func getValidityScore(baseRiskScore float64, validationStatus secrets.Validation`
`105`	`105`	`}`
`106`	`106`
`107`	`107`	`func GetBaseRiskScore(category ruledefine.RuleCategory, ruleType uint8) float64 {`
`108`		`- var categoryScore uint8`
`109`		`- var ok bool`
	`108`	`+ categoryScore, ok := CategoryScoreMap[category]`
`110`	`109`	`// default to the lowest score if category not found, should only happen on custom rules with undefined category`
`111`		`- if categoryScore, ok = CategoryScoreMap[category]; !ok {`
	`110`	`+ if !ok {`
`112`	`111`	`categoryScore = 1`
`113`	`112`	`}`
`114`	`113`	`return float64(categoryScore)0.6 + float64(ruleType)0.4`