fix linter

Author: cx-leonardo-fontes

engine/detect/baseline.go

@@ -9,10 +9,12 @@ import (
 	"github.com/zricethezav/gitleaks/v8/report"
 )
 
-func IsNew(finding report.Finding, redact uint, baseline []report.Finding) bool {
+//nolint:gocyclo // TODO: refactor this function to reduce cyclomatic complexity
+func IsNew(finding *report.Finding, redact uint, baseline []report.Finding) bool {
 	// Explicitly testing each property as it gives significantly better performance in comparison to cmp.Equal(). Drawback is that
 	// the code requires maintenance if/when the Finding struct changes
-	for _, b := range baseline {
+	for i := range baseline {
+		b := &baseline[i]
 		if finding.RuleID == b.RuleID &&
 			finding.Description == b.Description &&
 			finding.StartLine == b.StartLine &&
@@ -26,7 +28,7 @@ func IsNew(finding report.Finding, redact uint, baseline []report.Finding) bool
 			finding.Email == b.Email &&
 			finding.Date == b.Date &&
 			finding.Message == b.Message &&
-			// Omit checking finding.Fingerprint - if the format of the fingerprint changes, the users will see unexpected behaviour
+			// Omit checking finding.Fingerprint - if the format of the fingerprint changes, the users will see unexpected behavior
 			finding.Entropy == b.Entropy {
 			return false
 		}
@@ -49,7 +51,7 @@ func LoadBaseline(baselinePath string) ([]report.Finding, error) {
 	return previousFindings, nil
 }
 
-func (d *Detector) AddBaseline(baselinePath string, source string) error {
+func (d *Detector) AddBaseline(baselinePath, source string) error {
 	if baselinePath != "" {
 		absoluteSource, err := filepath.Abs(source)
 		if err != nil {
@@ -73,7 +75,6 @@ func (d *Detector) AddBaseline(baselinePath string, source string) error {
 
 		d.baseline = baseline
 		baselinePath = relativeBaseline
-
 	}
 
 	d.baselinePath = baselinePath

engine/detect/detect.go

@@ -731,7 +731,7 @@ func (d *Detector) AddFinding(finding *report.Finding) {
 		}
 	}
 
-	if d.baseline != nil && !IsNew(*finding, d.Redact, d.baseline) {
+	if d.baseline != nil && !IsNew(finding, d.Redact, d.baseline) {
 		logger.Debug().
 			Str("fingerprint", finding.Fingerprint).
 			Msgf("skipping finding: baseline")