Skip to content

Commit fefb6e8

Browse files
fix: remove rule pkcs12-file (#333)
We are removing this rule because it doesn’t fit our use case. The rule doesn’t include a regex for a specific result; it detects results only by file pattern.
1 parent c10b67d commit fefb6e8

File tree

3 files changed

+0
-7
lines changed

3 files changed

+0
-7
lines changed

docs/list-of-rules.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,6 @@ Here is a complete list of all the rules that are currently implemented.
164164
| prefect-api-token | Detected a Prefect API token, risking unauthorized access to workflow management and automation services. | api-token | |
165165
| privateai-api-token | Identified a PrivateAI Token, posing a risk of unauthorized access to AI services and data manipulation. | api-token | |
166166
| private-key | Identified a Private Key, which may compromise cryptographic security and sensitive data encryption. | private-key | |
167-
| pkcs12-file | Found a PKCS #12 file, which commonly contain bundled private keys. | private-key | |
168167
| pulumi-api-token | Found a Pulumi API token, posing a risk to infrastructure as code services and cloud resource management. | api-token | |
169168
| pypi-upload-token | Discovered a PyPI upload token, potentially compromising Python package distribution and repository integrity. | upload-token | |
170169
| rapidapi-access-token | Uncovered a RapidAPI Access Token, which could lead to unauthorized access to various APIs and data services. | access-token | |

engine/rules/rules.go

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -856,11 +856,6 @@ func GetDefaultRules() []*Rule { //nolint:funlen // This function contains all r
856856
Tags: []string{TagPrivateKey},
857857
ScoreParameters: ScoreParameters{Category: CategoryGeneralOrUnknown, RuleType: 4},
858858
},
859-
{
860-
Rule: *rules.PrivateKeyPKCS12File(),
861-
Tags: []string{TagPrivateKey},
862-
ScoreParameters: ScoreParameters{Category: CategoryGeneralOrUnknown, RuleType: 4},
863-
},
864859
{
865860
Rule: *rules.PulumiAPIToken(),
866861
Tags: []string{TagApiToken},

engine/score/score_test.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,6 @@ func TestScore(t *testing.T) {
171171
ruleConfig.Prefect().RuleID: {10, 5.2, 8.2},
172172
ruleConfig.PrivateAIToken().RuleID: {7.6, 1.6, 4.6},
173173
rules.PrivateKey().RuleID: {10, 5.2, 8.2},
174-
ruleConfig.PrivateKeyPKCS12File().RuleID: {10, 5.2, 8.2},
175174
ruleConfig.PulumiAPIToken().RuleID: {10, 5.2, 8.2},
176175
ruleConfig.PyPiUploadToken().RuleID: {10, 5.2, 8.2},
177176
ruleConfig.RapidAPIAccessToken().RuleID: {10, 5.2, 8.2},

0 commit comments

Comments
 (0)