fixed lint and added more unit tests

Author: cx-anjali-deore

internal/services/applications.go

@@ -64,7 +64,7 @@ func verifyApplicationNameExactMatch(applicationName string, resp *wrappers.Appl
 	return application
 }
 
-func findApplicationAndUpdate(applicationName string, applicationsWrapper wrappers.ApplicationsWrapper, projectName string, projectID string, featureFlagsWrapper wrappers.FeatureFlagsWrapper) error {
+func findApplicationAndUpdate(applicationName string, applicationsWrapper wrappers.ApplicationsWrapper, projectName, projectID string, featureFlagsWrapper wrappers.FeatureFlagsWrapper) error {
 	if applicationName == "" {
 		logger.PrintfIfVerbose("No application name provided. Skipping application update")
 		return nil
@@ -112,7 +112,7 @@ func updateApplication(applicationModel *wrappers.ApplicationConfiguration, appl
 	return handleApplicationUpdateResponse(errorModel, err)
 }
 
-func associateProjectToApplication(applicationID string, projectID string, associatedProjectIds []string, applicationsWrapper wrappers.ApplicationsWrapper) error {
+func associateProjectToApplication(applicationID, projectID string, associatedProjectIds []string, applicationsWrapper wrappers.ApplicationsWrapper) error {
 	associatedProjectIds = append(associatedProjectIds, projectID)
 	associateProjectsModel := &wrappers.AssociateProjectModel{
 		ProjectIds: associatedProjectIds,

internal/services/applications_test.go

@@ -1,7 +1,12 @@
 package services
 
 import (
+	errorConstants "github.com/checkmarx/ast-cli/internal/constants/errors"
+	"github.com/checkmarx/ast-cli/internal/wrappers"
+	"github.com/checkmarx/ast-cli/internal/wrappers/mock"
+	"gotest.tools/assert"
 	"reflect"
+	"strings"
 	"testing"
 )
 
@@ -36,3 +41,49 @@ func Test_createApplicationIds(t *testing.T) {
 		})
 	}
 }
+func Test_ProjectAssociation_ToApplicationDirectly(t *testing.T) {
+	applicationWrapper := &mock.ApplicationsMockWrapper{}
+
+	tests := []struct {
+		description     string
+		applicationName string
+		projectName     string
+		error           string
+	}{
+		{"Project association to  Application  should  fail with 403 forbidden permission error", mock.FakeForbidden403, "random-project", errorConstants.NoPermissionToUpdateApplication},
+		{"Project association to  Application should  fail with 401 unauthorized  error", mock.FakeUnauthorized401, "random-project", errorConstants.StatusUnauthorized},
+		{"Project association to  Application should  fail with 400  BadRequest  error", mock.FakeBadRequest400, "random-project", errorConstants.FailedToUpdateApplication},
+	}
+
+	for _, test := range tests {
+		tt := test
+		t.Run(tt.description, func(t *testing.T) {
+			err := associateProjectToApplication(tt.applicationName, tt.projectName, []string{}, applicationWrapper)
+			assert.Assert(t, strings.Contains(err.Error(), tt.error), err.Error())
+		})
+	}
+}
+
+func Test_ProjectAssociation_ToApplicationWithoutDirectAssociation(t *testing.T) {
+	applicationModel := wrappers.ApplicationConfiguration{}
+	applicationWrapper := &mock.ApplicationsMockWrapper{}
+
+	tests := []struct {
+		description   string
+		applicationId string
+		projectName   string
+		error         string
+	}{
+		{"Application update should  fail with 403 forbidden permission error", mock.FakeForbidden403, "random-project", errorConstants.NoPermissionToUpdateApplication},
+		{"Application update  should  fail with 401 unauthorized  error", mock.FakeUnauthorized401, "random-project", errorConstants.StatusUnauthorized},
+		{"Application update should  fail with 400  BadRequest  error", mock.FakeBadRequest400, "random-project", errorConstants.FailedToUpdateApplication},
+	}
+
+	for _, test := range tests {
+		tt := test
+		t.Run(tt.description, func(t *testing.T) {
+			err := updateApplication(&applicationModel, applicationWrapper, tt.applicationId)
+			assert.Assert(t, strings.Contains(err.Error(), tt.error), err.Error())
+		})
+	}
+}

internal/wrappers/mock/application-mock.go

@@ -61,6 +61,13 @@ func (a ApplicationsMockWrapper) Update(applicationID string, applicationBody *w
 	if applicationID == FakeUnauthorized401 {
 		return nil, errors.Errorf(errorConstants.StatusUnauthorized)
 	}
+	if applicationID == FakeBadRequest400 {
+		return &wrappers.ErrorModel{
+			Message: "invalid applicationBody",
+			Code:    355,
+			Type:    "validation",
+		}, nil
+	}
 	return nil, nil
 }
 
@@ -72,5 +79,14 @@ func (a ApplicationsMockWrapper) CreateProjectAssociation(applicationID string,
 	if applicationID == FakeUnauthorized401 {
 		return nil, errors.Errorf(errorConstants.StatusUnauthorized)
 	}
+
+	if applicationID == FakeBadRequest400 {
+		return &wrappers.ErrorModel{
+			Message: "invalid applicationBody",
+			Code:    355,
+			Type:    "validation",
+		}, nil
+	}
+
 	return nil, nil
 }

test/integration/scan_test.go

@@ -299,7 +299,7 @@ func TestScanCreate_ExistingApplicationAndExistingProject_CreateScanSuccessfully
 	_, projectName := createNewProject(t, nil, nil, GenerateRandomProjectNameForScan())
 	args := []string{
 		"scan", "create",
-		flag(params.ApplicationName), "my-application",
+		flag(params.ApplicationName), "test-app",
 		flag(params.ProjectName), projectName,
 		flag(params.SourcesFlag), ".",
 		flag(params.ScanTypes), params.IacType,