Skip to content

Commit 5b6b7ed

Browse files
validation logic for invalid image
1 parent 80fc90e commit 5b6b7ed

File tree

1 file changed

+14
-5
lines changed

1 file changed

+14
-5
lines changed

internal/commands/scan.go

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -867,8 +867,10 @@ func setupScanTypeProjectAndConfig(
867867
if apiSecConfig != nil {
868868
configArr = append(configArr, apiSecConfig)
869869
}
870-
var containersConfig = addContainersScan(cmd, resubmitConfig)
871-
if containersConfig != nil {
870+
var containersConfig, containersErr = addContainersScan(cmd, resubmitConfig)
871+
if containersErr != nil {
872+
return containersErr
873+
} else if containersConfig != nil {
872874
configArr = append(configArr, containersConfig)
873875
}
874876

@@ -1064,9 +1066,9 @@ func addScaScan(cmd *cobra.Command, resubmitConfig []wrappers.Config, hasContain
10641066
return nil
10651067
}
10661068

1067-
func addContainersScan(cmd *cobra.Command, resubmitConfig []wrappers.Config) map[string]interface{} {
1069+
func addContainersScan(cmd *cobra.Command, resubmitConfig []wrappers.Config) (map[string]interface{}, error) {
10681070
if !scanTypeEnabled(commonParams.ContainersType) {
1069-
return nil
1071+
return nil, nil
10701072
}
10711073
containerMapConfig := make(map[string]interface{})
10721074
containerMapConfig[resultsMapType] = commonParams.ContainersType
@@ -1092,11 +1094,18 @@ func addContainersScan(cmd *cobra.Command, resubmitConfig []wrappers.Config) map
10921094
}
10931095
userCustomImages, _ := cmd.Flags().GetString(commonParams.ContainerImagesFlag)
10941096
if userCustomImages != "" {
1097+
containerImagesList := strings.Split(strings.TrimSpace(userCustomImages), ",")
1098+
for _, containerImageName := range containerImagesList {
1099+
if containerImagesErr := validateContainerImageFormat(containerImageName); containerImagesErr != nil {
1100+
return nil, containerImagesErr
1101+
}
1102+
}
1103+
logger.PrintIfVerbose(fmt.Sprintf("User input container images identified: %v", strings.Join(containerImagesList, ", ")))
10951104
containerConfig.UserCustomImages = userCustomImages
10961105
}
10971106

10981107
containerMapConfig[resultsMapValue] = &containerConfig
1099-
return containerMapConfig
1108+
return containerMapConfig, nil
11001109
}
11011110

11021111
func initializeContainersConfigWithResubmitValues(resubmitConfig []wrappers.Config, containerConfig *wrappers.ContainerConfig) {

0 commit comments

Comments
 (0)