Support SCS Secret Detection results for Jetbrains agent in JSON report

cx-atish-jadhav · cx-atish-jadhav · commit c570a6715f59 · 2025-09-01T11:41:35.000+05:30
diff --git a/internal/commands/result.go b/internal/commands/result.go
@@ -1158,7 +1158,7 @@ func filterResultsByType(results *wrappers.ScanResultsCollection, excludedTypes
 func filterScsResultsByAgent(results *wrappers.ScanResultsCollection, agent string) *wrappers.ScanResultsCollection {
 	unsupportedTypesByAgent := map[string][]string{
 		commonParams.VSCodeAgent:       {commonParams.SCSScorecardType},
-		commonParams.JetbrainsAgent:    {commonParams.SCSScorecardType, commonParams.SCSSecretDetectionType},
+		commonParams.JetbrainsAgent:    {commonParams.SCSScorecardType},
 		commonParams.EclipseAgent:      {commonParams.SCSScorecardType, commonParams.SCSSecretDetectionType},
 		commonParams.VisualStudioAgent: {commonParams.SCSScorecardType, commonParams.SCSSecretDetectionType},
 	}
diff --git a/internal/commands/result_test.go b/internal/commands/result_test.go
@@ -206,8 +206,8 @@ func TestRunScsResultsShow_Other_AgentsShouldNotShowScsResults(t *testing.T) {
 
 	execCmdNilAssertion(t, "results", "show", "--scan-id", "SCS_ONLY", "--report-format", "json", "--agent", params.JetbrainsAgent)
 	assertTypePresentJSON(t, params.SCSScorecardType, 0)
-	assertTypePresentJSON(t, params.SCSSecretDetectionType, 0)
-	assertTotalCountJSON(t, 0)
+	assertTypePresentJSON(t, params.SCSSecretDetectionType, 2)
+	assertTotalCountJSON(t, 2)
 
 	removeFileBySuffix(t, printer.FormatJSON)
 	mock.SetScsMockVarsToDefault()

Original file line number	Diff line number	Diff line change
`@@ -1158,7 +1158,7 @@ func filterResultsByType(results *wrappers.ScanResultsCollection, excludedTypes`
`1158`	`1158`	`func filterScsResultsByAgent(results wrappers.ScanResultsCollection, agent string) wrappers.ScanResultsCollection {`
`1159`	`1159`	`unsupportedTypesByAgent := map[string][]string{`
`1160`	`1160`	`commonParams.VSCodeAgent: {commonParams.SCSScorecardType},`
`1161`		`- commonParams.JetbrainsAgent: {commonParams.SCSScorecardType, commonParams.SCSSecretDetectionType},`
	`1161`	`+ commonParams.JetbrainsAgent: {commonParams.SCSScorecardType},`
`1162`	`1162`	`commonParams.EclipseAgent: {commonParams.SCSScorecardType, commonParams.SCSSecretDetectionType},`
`1163`	`1163`	`commonParams.VisualStudioAgent: {commonParams.SCSScorecardType, commonParams.SCSSecretDetectionType},`
`1164`	`1164`	`}`