Fixed review constant mapping

Author: cx-anjali-deore

internal/constants/errors/errors.go

@@ -24,15 +24,17 @@ const (
 	NoASCALicense                          = "User doesn't have \"AI Protection\" or \"Checkmarx One Assist\" license"
 	FailedUploadFileMsgWithDomain          = "Unable to upload the file to the pre-signed URL. Try adding the domain: %s to your allow list."
 	FailedUploadFileMsgWithURL             = "Unable to upload the file to the pre-signed URL. Try adding the URL: %s to your allow list."
+	NoPermissionToUpdateApplication        = "you do not have permission to update the application"
+	FailedToUpdateApplication              = "failed to update application"
+	ApplicationNotFound                    = "Application not found"
 
 	// asca Engine
 	FileExtensionIsRequired = "file must have an extension"
 
 	// Realtime
-	RealtimeEngineErrFormat         = "realtime engine error: %s"
-	RealtimeEngineNotAvailable      = "Realtime engine is not available for this tenant"
-	RealtimeEngineFilePathRequired  = "file path is required for realtime scan"
-	NoPermissionToUpdateApplication = "you do not have permission to update the application"
+	RealtimeEngineErrFormat        = "realtime engine error: %s"
+	RealtimeEngineNotAvailable     = "Realtime engine is not available for this tenant"
+	RealtimeEngineFilePathRequired = "file path is required for realtime scan"
 )
 
 type RealtimeEngineError struct {

internal/services/applications.go

@@ -74,7 +74,7 @@ func findApplicationAndUpdate(applicationName string, applicationsWrapper wrappe
 		return errors.Wrapf(err, "%s:%s", errorConstants.FailedToGetApplication, applicationName)
 	}
 	if applicationResp == nil {
-		return errors.Errorf("Application not found: %s", applicationName)
+		return errors.Errorf("%s: %s", errorConstants.ApplicationNotFound, applicationName)
 	}
 	var applicationModel wrappers.ApplicationConfiguration
 	var newApplicationRule wrappers.Rule
@@ -101,7 +101,7 @@ func findApplicationAndUpdate(applicationName string, applicationsWrapper wrappe
 func updateApplication(applicationModel *wrappers.ApplicationConfiguration, applicationWrapper wrappers.ApplicationsWrapper, applicationID string) error {
 	errorModel, err := applicationWrapper.Update(applicationID, applicationModel)
 	if errorModel != nil {
-		err = errors.Errorf(ErrorCodeFormat, "failed to update application", errorModel.Code, errorModel.Message)
+		err = errors.Errorf(ErrorCodeFormat, errorConstants.FailedToUpdateApplication, errorModel.Code, errorModel.Message)
 	}
 	if errorModel == nil && err == nil {
 		logger.PrintIfVerbose("Successfully updated the application")

test/integration/scan_test.go

@@ -2710,17 +2710,3 @@ func TestCreateScanWithExistingProjectAnd_AssignApplication(t *testing.T) {
 	err, _ := executeCommand(t, args...)
 	assert.NilError(t, err, "Project should be assigned to application")
 }
-
-func TestCreateScanWithExistingProjectAnd_ApplicationNotFoundFailed(t *testing.T) {
-	_, projectName := createNewProject(t, nil, nil, GenerateRandomProjectNameForScan())
-
-	args := []string{
-		"scan", "create",
-		flag(params.ProjectName), projectName,
-		flag(params.BranchFlag), "dummy_branch",
-		flag(params.SourcesFlag), "data/sources-gitignore.zip",
-		flag(params.ApplicationName), "mock",
-	}
-	err, _ := executeCommand(t, args...)
-	assert.ErrorContains(t, err, "Application not found: mock")
-}