fix token (#1248)

Co-authored-by: Itay Paz <[email protected]>
Co-authored-by: Ben Alvo <[email protected]>

Author: 3 people

internal/services/realtimeengine/secretsrealtime/config.go

@@ -12,7 +12,7 @@ type SecretsRealtimeResult struct {
 }
 
 type IgnoredSecret struct {
-	Title    string `json:"Title"`
-	FilePath string `json:"FilePath"`
-	Line     int    `json:"Line"`
+	Title       string `json:"Title"`
+	FilePath    string `json:"FilePath"`
+	SecretValue string `json:"SecretValue"`
 }

internal/services/realtimeengine/secretsrealtime/secrets-realtime.go

@@ -45,11 +45,7 @@ func NewSecretsRealtimeService(
 func filterIgnoredSecrets(results []SecretsRealtimeResult, ignoreMap map[string]bool) []SecretsRealtimeResult {
 	filtered := make([]SecretsRealtimeResult, 0, len(results))
 	for _, r := range results {
-		if len(r.Locations) == 0 {
-			filtered = append(filtered, r)
-			continue
-		}
-		key := fmt.Sprintf("%s_%s_%d", r.Title, r.FilePath, r.Locations[0].Line)
+		key := fmt.Sprintf("%s_%s_%s", r.Title, r.FilePath, r.SecretValue)
 		if !ignoreMap[key] {
 			filtered = append(filtered, r)
 		}
@@ -60,7 +56,7 @@ func filterIgnoredSecrets(results []SecretsRealtimeResult, ignoreMap map[string]
 func buildIgnoreMap(ignored []IgnoredSecret) map[string]bool {
 	m := make(map[string]bool)
 	for _, s := range ignored {
-		key := fmt.Sprintf("%s_%s_%d", s.Title, s.FilePath, s.Line)
+		key := fmt.Sprintf("%s_%s_%s", s.Title, s.FilePath, s.SecretValue)
 		m[key] = true
 	}
 	return m
@@ -131,7 +127,6 @@ func readFile(filePath string) (string, error) {
 }
 
 func runScan(source, content string) (*reporting.Report, error) {
-
 	item := scanner.ScanItem{
 		Content: &content,
 		Source:  source,

internal/services/realtimeengine/secretsrealtime/secrets-realtime_test.go

@@ -73,12 +73,12 @@ func TestRunSecretsRealtimeScan_WithIgnoreFile_FiltersResult(t *testing.T) {
 	tempDir := t.TempDir()
 
 	testFile := filepath.Join(tempDir, "test.txt")
-	testContent := "pat = \"ghp_1234567890abcdef1234567890abcdef12345678\""
+	testContent := "pat = \"ghp_1234567890abcdef123\""
 	assert.NoError(t, os.WriteFile(testFile, []byte(testContent), 0644))
 
 	ignoreFile := filepath.Join(tempDir, "ignored.json")
 	ignored := []IgnoredSecret{
-		{Title: "github-pat", FilePath: testFile, Line: 0},
+		{Title: "github-pat", FilePath: testFile, SecretValue: "ghp_1234567890abcdef123"},
 	}
 	data, _ := json.Marshal(ignored)
 	assert.NoError(t, os.WriteFile(ignoreFile, data, 0644))