Skip to content

Commit e3576d7

Browse files
Itay PazItay Paz
authored andcommitted
Remove file path from secrets ignore flow
1 parent ede1a26 commit e3576d7

File tree

3 files changed

+3
-4
lines changed

3 files changed

+3
-4
lines changed

internal/services/realtimeengine/secretsrealtime/config.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,5 @@ type SecretsRealtimeResult struct {
1313

1414
type IgnoredSecret struct {
1515
Title string `json:"Title"`
16-
FilePath string `json:"FilePath"`
1716
SecretValue string `json:"SecretValue"`
1817
}

internal/services/realtimeengine/secretsrealtime/secrets-realtime.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ func NewSecretsRealtimeService(
4545
func filterIgnoredSecrets(results []SecretsRealtimeResult, ignoreMap map[string]bool) []SecretsRealtimeResult {
4646
filtered := make([]SecretsRealtimeResult, 0, len(results))
4747
for _, r := range results {
48-
key := fmt.Sprintf("%s_%s_%s", r.Title, r.FilePath, r.SecretValue)
48+
key := fmt.Sprintf("%s_%s", r.Title, r.SecretValue)
4949
if !ignoreMap[key] {
5050
filtered = append(filtered, r)
5151
}
@@ -56,7 +56,7 @@ func filterIgnoredSecrets(results []SecretsRealtimeResult, ignoreMap map[string]
5656
func buildIgnoreMap(ignored []IgnoredSecret) map[string]bool {
5757
m := make(map[string]bool)
5858
for _, s := range ignored {
59-
key := fmt.Sprintf("%s_%s_%s", s.Title, s.FilePath, s.SecretValue)
59+
key := fmt.Sprintf("%s_%s", s.Title, s.SecretValue)
6060
m[key] = true
6161
}
6262
return m

internal/services/realtimeengine/secretsrealtime/secrets-realtime_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ func TestRunSecretsRealtimeScan_WithIgnoreFile_FiltersResult(t *testing.T) {
7878

7979
ignoreFile := filepath.Join(tempDir, "ignored.json")
8080
ignored := []IgnoredSecret{
81-
{Title: "github-pat", FilePath: testFile, SecretValue: "ghp_1234567890abcdef123"},
81+
{Title: "github-pat", SecretValue: "ghp_1234567890abcdef123"},
8282
}
8383
data, _ := json.Marshal(ignored)
8484
assert.NoError(t, os.WriteFile(ignoreFile, data, 0644))

0 commit comments

Comments
 (0)