19078 FIX Fix rate calculation in clustered interface checks

SUP-26175

Change-Id: I7a13638879e7d68508f900401ced0b5ddce516de

Author: jherbel

.werks/19078.md

@@ -0,0 +1,15 @@
+[//]: # (werk v2)
+# Fix rate calculation in clustered interface checks
+
+key        | value
+---------- | ---
+date       | 2026-01-07T21:06:40+00:00
+version    | 2.4.0p19
+class      | fix
+edition    | cre
+component  | checks
+level      | 1
+compatible | yes
+
+Depending on the monitored device, clustered interface checks might have reported incorrect or missing rates.
+Note that this only affected clustered services using the native cluster mode.

cmk/plugins/aws/agent_based/aws_ec2.py

@@ -172,8 +172,8 @@ def check_aws_ec2_network_io(
                     out_octets=section["NetworkOut"] / 60,
                 ),
                 get_rate_errors=[],
+                timestamp=time.time(),
             ),
-            timestamp=time.time(),
             value_store=get_value_store(),
             params=params,
         )

cmk/plugins/aws/agent_based/aws_rds.py

@@ -124,8 +124,8 @@ def check_aws_rds_network_io(
                     out_octets=metrics["NetworkTransmitThroughput"],
                 ),
                 get_rate_errors=[],
+                timestamp=time.time(),
             ),
-            timestamp=time.time(),
             value_store=get_value_store(),
             params=params,
         )

cmk/plugins/azure/agent_based/azure_virtual_machine.py

@@ -469,8 +469,8 @@ def check_azure_vm_network_io(
             ),
             rates=interfaces.Rates(in_octets=in_octets, out_octets=out_octets),
             get_rate_errors=[],
+            timestamp=time.time(),
         ),
-        timestamp=time.time(),
         value_store=get_value_store(),
         params=params,
     )

cmk/plugins/collection/agent_based/aix_if.py

@@ -3,6 +3,8 @@
 # This file is part of Checkmk (https://checkmk.com). It is subject to the terms and
 # conditions defined in the file COPYING, which is part of this source code package.
 
+import time
+
 from cmk.agent_based.v2 import AgentSection, StringTable
 from cmk.plugins.lib import interfaces
 
@@ -20,6 +22,7 @@ def _consume_down_interfaces(string_table: StringTable) -> tuple[list[str], int]
 
 def _parse_aix_common(  # pylint: disable=too-many-branches
     string_table: StringTable,
+    timestamp: float,
 ) -> tuple[dict[str, interfaces.InterfaceWithCounters], dict[str, list[str]]]:
     ifaces = {}
     flags = {}
@@ -36,6 +39,7 @@ def _parse_aix_common(  # pylint: disable=too-many-branches
                     type="24" if nic.startswith("lo") else "6",
                 ),
                 interfaces.Counters(),
+                timestamp=timestamp,
             )
         elif line[0] == "Bytes:" and line[2] == "Bytes:":
             iface.counters.out_octets = interfaces.saveint(line[1])
@@ -69,9 +73,10 @@ def _parse_aix_common(  # pylint: disable=too-many-branches
 
 def _parse_aix_if_ifconfig_augmented(
     string_table: StringTable,
+    timestamp: float,
 ) -> interfaces.Section[interfaces.InterfaceWithCounters]:
     interfaces_in_down_state, idx = _consume_down_interfaces(string_table)
-    ifaces, flags = _parse_aix_common(string_table[idx:])
+    ifaces, flags = _parse_aix_common(string_table[idx:], timestamp)
     for nic, iface in ifaces.items():
         iface.attributes.oper_status = "2" if nic in interfaces_in_down_state else "1"
         iface.attributes.finalize()
@@ -80,8 +85,9 @@ def _parse_aix_if_ifconfig_augmented(
 
 def _parse_aix_if_entstat_only(
     string_table: StringTable,
+    timestamp: float,
 ) -> interfaces.Section[interfaces.InterfaceWithCounters]:
-    ifaces, flags = _parse_aix_common(string_table)
+    ifaces, flags = _parse_aix_common(string_table, timestamp)
 
     for nic, iface in ifaces.items():
         iface_flags = flags.get(nic, [])
@@ -99,12 +105,21 @@ def _parse_aix_if_entstat_only(
     return list(ifaces.values())
 
 
+def parse_aix_if_pure(
+    string_table: StringTable,
+    timestamp: float,
+) -> interfaces.Section[interfaces.InterfaceWithCounters]:
+    return (
+        _parse_aix_if_ifconfig_augmented(string_table, timestamp)
+        if string_table[0][0] == "[interfaces_in_down_state]"
+        else _parse_aix_if_entstat_only(string_table, timestamp)
+    )
+
+
 def parse_aix_if(
     string_table: StringTable,
 ) -> interfaces.Section[interfaces.InterfaceWithCounters]:
-    if string_table[0][0] == "[interfaces_in_down_state]":
-        return _parse_aix_if_ifconfig_augmented(string_table)
-    return _parse_aix_if_entstat_only(string_table)
+    return parse_aix_if_pure(string_table, time.time())
 
 
 agent_section_aix_if = AgentSection(

cmk/plugins/collection/agent_based/cadvisor_if.py

@@ -91,8 +91,8 @@ def check_cadvisor_if(item: str, section: Section) -> CheckResult:
                     out_disc=section["if_out_discards"],
                     out_err=section["if_out_errors"],
                 ),
+                timestamp=time.time(),
             ),
-            timestamp=time.time(),
             value_store=get_value_store(),
             params={},
         ),

cmk/plugins/collection/agent_based/emc_vplex_if.py

@@ -3,15 +3,17 @@
 # This file is part of Checkmk (https://checkmk.com). It is subject to the terms and
 # conditions defined in the file COPYING, which is part of this source code package.
 
+import time
 from collections.abc import Sequence
 
 from cmk.agent_based.v2 import OIDEnd, SNMPSection, SNMPTree, StringTable
 from cmk.plugins.lib import interfaces
 from cmk.plugins.lib.emc import DETECT_VPLEX
 
 
-def parse_emc_vplex_if(
+def parse_emc_vplex_if_pure(
     string_table: Sequence[StringTable],
+    timestamp: float,
 ) -> interfaces.Section[interfaces.InterfaceWithCounters]:
     directors = {}
     for director, ip in string_table[0]:
@@ -32,11 +34,18 @@ def parse_emc_vplex_if(
                 in_octets=int(frontend_info[1]),
                 out_octets=int(frontend_info[2]),
             ),
+            timestamp=timestamp,
         )
         for idx, frontend_info in enumerate(string_table[1] + string_table[2])
     ]
 
 
+def parse_emc_vplex_if(
+    string_table: Sequence[StringTable],
+) -> interfaces.Section[interfaces.InterfaceWithCounters]:
+    return parse_emc_vplex_if_pure(string_table, timestamp=time.time())
+
+
 snmp_section_emc_vplex_if = SNMPSection(
     name="emc_vplex_if",
     parse_function=parse_emc_vplex_if,

cmk/plugins/collection/agent_based/hitachi_hnas_fc_if.py

@@ -3,6 +3,7 @@
 # This file is part of Checkmk (https://checkmk.com). It is subject to the terms and
 # conditions defined in the file COPYING, which is part of this source code package.
 
+import time
 from collections.abc import Sequence
 
 from cmk.agent_based.v2 import CheckPlugin, RuleSetType, SNMPSection, SNMPTree, StringTable
@@ -12,6 +13,7 @@
 def parse_hitachi_hnas_fc_if(
     string_table: Sequence[StringTable],
 ) -> interfaces.Section[interfaces.InterfaceWithCounters]:
+    timestamp = time.time()
     return [
         interfaces.InterfaceWithCounters(
             interfaces.Attributes(
@@ -28,6 +30,7 @@ def parse_hitachi_hnas_fc_if(
                 in_err=sum(map(int, line[6:13])),
                 out_octets=interfaces.saveint(line[5]),
             ),
+            timestamp=timestamp,
         )
         for line in string_table[0]
     ]

cmk/plugins/collection/agent_based/hpux_if.py

@@ -3,6 +3,7 @@
 # This file is part of Checkmk (https://checkmk.com). It is subject to the terms and
 # conditions defined in the file COPYING, which is part of this source code package.
 
+import time
 
 from cmk.agent_based.v2 import AgentSection, CheckPlugin, RuleSetType, StringTable
 from cmk.plugins.lib import if64, interfaces
@@ -26,6 +27,7 @@
 def parse_hpux_if(
     string_table: StringTable,
 ) -> interfaces.Section[interfaces.InterfaceWithCounters]:
+    timestamp = time.time()
     nics = []
     for line in string_table:
         if "***" in line:
@@ -37,6 +39,7 @@ def parse_hpux_if(
                     type="6",
                 ),
                 interfaces.Counters(),
+                timestamp=timestamp,
             )
             nics.append(iface)
             continue

cmk/plugins/collection/agent_based/huawei_osn_if.py

@@ -23,6 +23,7 @@
 
 
 def parse_huawei_osn_if(string_table: Sequence[StringTable]) -> Section:
+    timestamp = time.time()
     return {
         name: interfaces.InterfaceWithCounters(
             interfaces.Attributes(
@@ -44,6 +45,7 @@ def parse_huawei_osn_if(string_table: Sequence[StringTable]) -> Section:
                 out_bcast=interfaces.saveint(line[6]),
                 out_err=interfaces.saveint(line[10]),
             ),
+            timestamp,
         )
         for line in string_table[0]
         for name in [line[0]]
@@ -93,7 +95,6 @@ def check_huawei_osn_if(
         params,
         interfaces.InterfaceWithRatesAndAverages.from_interface_with_counters_or_rates(
             interface,
-            timestamp=time.time(),
             value_store=get_value_store(),
             params=params,
         ),